From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 123272 invoked by alias); 13 Dec 2019 14:38:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 123238 invoked by uid 89); 13 Dec 2019 14:38:08 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1427, markers X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 13 Dec 2019 14:38:07 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id E753A202E5; Fri, 13 Dec 2019 09:38:05 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id E66422019C; Fri, 13 Dec 2019 09:38:01 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id C4FF420AF6; Fri, 13 Dec 2019 09:38:01 -0500 (EST) X-Gerrit-PatchSet: 1 Date: Fri, 13 Dec 2019 14:38:00 -0000 From: "Pedro Alves (Code Review)" To: Tom Tromey , gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] Remove "fix" call for "long long" from ARI X-Gerrit-Change-Id: I97bca2dc04b579fcf7c9dba7fe7fd939451bcefa X-Gerrit-Change-Number: 755 X-Gerrit-ChangeURL: X-Gerrit-Commit: 0ecf9a762e3bba675708f5e9a2c2c7af6d0f35a1 In-Reply-To: References: X-Gerrit-Comment-Date: Fri, 13 Dec 2019 09:38:01 -0500 Reply-To: gnutoolchain-gerrit@osci.io MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191213143801.C4FF420AF6@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-12/txt/msg00592.txt.bz2 Pedro Alves has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/755 ...................................................................... Patch Set 1: (1 comment) | --- /dev/null | +++ /COMMIT_MSG | @@ -1,0 +1,17 @@ | +Parent: 13e991b1 (Accept -Wno- prefix in ARI) | +Author: Tom Tromey | +AuthorDate: 2019-12-12 09:10:49 -0700 | +Commit: Tom Tromey | +CommitDate: 2019-12-12 10:31:38 -0700 | + | +Remove "fix" call for "long long" from ARI | + | +ARI has a "fix" call for "long long", but this call is incorrect. | +This patch removes it. PS1, Line 10: More like the definitions of ULONGEST/LONGEST moved from defs.h to gdbsupport/common-types.h. I don't see markers there, don't we need them? | + | +gdb/ChangeLog | +2019-12-12 Tom Tromey | + | + * contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long". | + | +Change-Id: I97bca2dc04b579fcf7c9dba7fe7fd939451bcefa -- Gerrit-Project: binutils-gdb Gerrit-Branch: master Gerrit-Change-Id: I97bca2dc04b579fcf7c9dba7fe7fd939451bcefa Gerrit-Change-Number: 755 Gerrit-PatchSet: 1 Gerrit-Owner: Tom Tromey Gerrit-CC: Pedro Alves Gerrit-Comment-Date: Fri, 13 Dec 2019 14:38:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment