From: "Sourceware to Gerrit sync (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Tom Tromey <tromey@sourceware.org>,
Pedro Alves <palves@redhat.com>,
gdb-patches@sourceware.org
Cc: Christian Biesinger <cbiesinger@google.com>
Subject: [pushed] Remove "boolean" and "var_boolean" checks from ARI
Date: Fri, 13 Dec 2019 22:17:00 -0000 [thread overview]
Message-ID: <20191213221708.1FAF020AF6@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1575560698000.Iaf449b51e8182ffa0b9ed25fe688e0ff64a07a67@gnutoolchain-gerrit.osci.io>
The original change was created by Tom Tromey.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/741
......................................................................
Remove "boolean" and "var_boolean" checks from ARI
The "boolean" and "var_boolean" checks from ARI seem only to generate
false reports.
Now that gdb is in C++, at least the "boolean" check seems unlikely to
ever generate a true report.
The "var_boolean" check likewise doesn't seem valuable any more --
presumably this refers to some ancient way of doing things in gdb, and
isn't likely to find a bug in the future.
Therefore, this patch removes these two checks.
gdb/ChangeLog
2019-12-13 Tom Tromey <tromey@adacore.com>
* contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
checks.
Change-Id: Iaf449b51e8182ffa0b9ed25fe688e0ff64a07a67
---
M gdb/ChangeLog
M gdb/contrib/ari/gdb_ari.sh
2 files changed, 5 insertions(+), 26 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index f3ee0ba..fea37ae 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
2019-12-13 Tom Tromey <tromey@adacore.com>
+ * contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
+ checks.
+
+2019-12-13 Tom Tromey <tromey@adacore.com>
+
* gdbsupport/safe-iterator.h (class basic_safe_range) <begin,
end>: No longer "const".
diff --git a/gdb/contrib/ari/gdb_ari.sh b/gdb/contrib/ari/gdb_ari.sh
index 7202563..ee9f16a 100755
--- a/gdb/contrib/ari/gdb_ari.sh
+++ b/gdb/contrib/ari/gdb_ari.sh
@@ -1110,18 +1110,6 @@
fail("strnicmp")
}
-# Boolean expressions and conditionals
-
-BEGIN { doc["boolean"] = "\
-Do not use `boolean'\'', use `bool'\'' instead"
- category["boolean"] = ari_regression
-}
-/(^|[^_[:alnum:]])boolean([^_[:alnum:]]|$)/ {
- if (is_yacc_or_lex == 0) {
- fail("boolean")
- }
-}
-
# Typedefs that are either redundant or can be reduced to `struct
# type *''.
# Must be placed before if assignment otherwise ARI exceptions
@@ -1143,20 +1131,6 @@
fail("strlen d_name")
}
-BEGIN { doc["var_boolean"] = "\
-Replace var_boolean with add_setshow_boolean_cmd"
- category["var_boolean"] = ari_regression
- fix("var_boolean", "gdb/command.h", 1)
- # fix only uses the last directory level
- fix("var_boolean", "cli/cli-decode.c", 2)
-}
-/(^|[^_[:alnum:]])var_boolean([^_[:alnum:]]|$)/ {
- if (($0 !~ /(^|[^_[:alnum:]])case *var_boolean:/) \
- && ($0 !~ /(^|[^_[:alnum:]])[=!]= *var_boolean/)) {
- fail("var_boolean")
- }
-}
-
BEGIN { doc["generic_use_struct_convention"] = "\
Replace generic_use_struct_convention with nothing, \
EXTRACT_STRUCT_VALUE_ADDRESS is a predicate"
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: Iaf449b51e8182ffa0b9ed25fe688e0ff64a07a67
Gerrit-Change-Number: 741
Gerrit-PatchSet: 3
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Pedro Alves <palves@redhat.com>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-CC: Christian Biesinger <cbiesinger@google.com>
Gerrit-MessageType: newpatchset
next prev parent reply other threads:[~2019-12-13 22:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-05 15:45 [review] " Tom Tromey (Code Review)
2019-12-05 16:47 ` Pedro Alves (Code Review)
2019-12-05 16:59 ` Christian Biesinger (Code Review)
2019-12-12 17:20 ` Tom Tromey (Code Review)
2019-12-12 17:51 ` [review v2] " Tom Tromey (Code Review)
2019-12-13 22:17 ` Sourceware to Gerrit sync (Code Review) [this message]
2019-12-13 22:17 ` [pushed] " Sourceware to Gerrit sync (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191213221708.1FAF020AF6@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
--cc=noreply@gnutoolchain-gerrit.osci.io \
--cc=palves@redhat.com \
--cc=tromey@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).