* [review] Accept -Wno- prefix in ARI
@ 2019-12-05 15:45 Tom Tromey (Code Review)
2019-12-05 17:04 ` Pedro Alves (Code Review)
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Tom Tromey (Code Review) @ 2019-12-05 15:45 UTC (permalink / raw)
To: gdb-patches
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/750
......................................................................
Accept -Wno- prefix in ARI
This adds -Wno- support to ARI, so that warnings can be disabled
selectively. I use this to ignore "deprecated" warnings.
gdb/ChangeLog
2019-12-05 Tom Tromey <tromey@adacore.com>
* contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
Change-Id: I6919faedf920e857df4f597df66f0ba3943e0eac
---
M gdb/ChangeLog
M gdb/contrib/ari/gdb_ari.sh
2 files changed, 20 insertions(+), 3 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 3c7e592..af815fc 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,9 @@
2019-12-05 Tom Tromey <tromey@adacore.com>
+ * contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
+
+2019-12-05 Tom Tromey <tromey@adacore.com>
+
* contrib/ari/gdb_ari.sh (usage): Use GNU style.
2019-12-05 Tom Tromey <tromey@adacore.com>
diff --git a/gdb/contrib/ari/gdb_ari.sh b/gdb/contrib/ari/gdb_ari.sh
index 5b74506..57ec9d3 100755
--- a/gdb/contrib/ari/gdb_ari.sh
+++ b/gdb/contrib/ari/gdb_ari.sh
@@ -60,7 +60,8 @@
-Werror Treat all problems as errors.
-Wall Report all problems.
-Wari Report problems that should be fixed in new code.
- -WCATEGORY Report problems in the specifed category. Valid categories
+ -WCATEGORY Report problems in the specifed category. The category
+ can be prefixed with "no-". Valid categories
are: ${all}
EOF
exit 1
@@ -102,6 +103,10 @@
# Validate all errors and warnings.
for w in ${warning} ${error}
do
+ case "$w" in
+ no-*) w=`echo x$w | sed -e 's/xno-//'`;;
+ esac
+
case " ${all} " in
*" ${w} "* ) ;;
* ) usage "Unknown option -W${w}" ;;
@@ -123,11 +128,19 @@
done
for w in ${warning}
do
- warnings="${warnings} warning[ari_${w}] = 1;"
+ val=1
+ case "$w" in
+ no-*) w=`echo x$w | sed -e 's/xno-//'`; val=0 ;;
+ esac
+ warnings="${warnings} warning[ari_${w}] = $val;"
done
for e in ${error}
do
- errors="${errors} error[ari_${e}] = 1;"
+ val=1
+ case "$e" in
+ no-*) e=`echo x$e | sed -e 's/xno-//'`; val=0 ;;
+ esac
+ errors="${errors} error[ari_${e}] = $val;"
done
if [ "$AWK" = "" ] ; then
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I6919faedf920e857df4f597df66f0ba3943e0eac
Gerrit-Change-Number: 750
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-MessageType: newchange
^ permalink raw reply [flat|nested] 5+ messages in thread
* [review] Accept -Wno- prefix in ARI
2019-12-05 15:45 [review] Accept -Wno- prefix in ARI Tom Tromey (Code Review)
@ 2019-12-05 17:04 ` Pedro Alves (Code Review)
2019-12-12 17:51 ` [review v2] " Tom Tromey (Code Review)
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Pedro Alves (Code Review) @ 2019-12-05 17:04 UTC (permalink / raw)
To: Tom Tromey, gdb-patches
Pedro Alves has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/750
......................................................................
Patch Set 1: Code-Review+2
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I6919faedf920e857df4f597df66f0ba3943e0eac
Gerrit-Change-Number: 750
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Pedro Alves <palves@redhat.com>
Gerrit-Comment-Date: Thu, 05 Dec 2019 17:04:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
^ permalink raw reply [flat|nested] 5+ messages in thread
* [review v2] Accept -Wno- prefix in ARI
2019-12-05 15:45 [review] Accept -Wno- prefix in ARI Tom Tromey (Code Review)
2019-12-05 17:04 ` Pedro Alves (Code Review)
@ 2019-12-12 17:51 ` Tom Tromey (Code Review)
2019-12-13 22:17 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-12-13 22:17 ` Sourceware to Gerrit sync (Code Review)
3 siblings, 0 replies; 5+ messages in thread
From: Tom Tromey (Code Review) @ 2019-12-12 17:51 UTC (permalink / raw)
To: Pedro Alves, gdb-patches
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/750
......................................................................
Accept -Wno- prefix in ARI
This adds -Wno- support to ARI, so that warnings can be disabled
selectively. I use this to ignore "deprecated" warnings.
2019-12-05 Tom Tromey <tromey@adacore.com>
* contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
Change-Id: I6919faedf920e857df4f597df66f0ba3943e0eac
---
M gdb/ChangeLog
M gdb/contrib/ari/gdb_ari.sh
2 files changed, 20 insertions(+), 3 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index e743677..0c810e3 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,9 @@
2019-12-05 Tom Tromey <tromey@adacore.com>
+ * contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
+
+2019-12-05 Tom Tromey <tromey@adacore.com>
+
* contrib/ari/gdb_ari.sh (usage): Use GNU style.
2019-12-05 Tom Tromey <tromey@adacore.com>
diff --git a/gdb/contrib/ari/gdb_ari.sh b/gdb/contrib/ari/gdb_ari.sh
index 4b0fddf..02c3647 100755
--- a/gdb/contrib/ari/gdb_ari.sh
+++ b/gdb/contrib/ari/gdb_ari.sh
@@ -60,7 +60,8 @@
-Werror Treat all problems as errors.
-Wall Report all problems.
-Wari Report problems that should be fixed in new code.
- -WCATEGORY Report problems in the specifed category. Valid categories
+ -WCATEGORY Report problems in the specifed category. The category
+ can be prefixed with "no-". Valid categories
are: ${all}
EOF
exit 1
@@ -102,6 +103,10 @@
# Validate all errors and warnings.
for w in ${warning} ${error}
do
+ case "$w" in
+ no-*) w=`echo x$w | sed -e 's/xno-//'`;;
+ esac
+
case " ${all} " in
*" ${w} "* ) ;;
* ) usage "Unknown option -W${w}" ;;
@@ -123,11 +128,19 @@
done
for w in ${warning}
do
- warnings="${warnings} warning[ari_${w}] = 1;"
+ val=1
+ case "$w" in
+ no-*) w=`echo x$w | sed -e 's/xno-//'`; val=0 ;;
+ esac
+ warnings="${warnings} warning[ari_${w}] = $val;"
done
for e in ${error}
do
- errors="${errors} error[ari_${e}] = 1;"
+ val=1
+ case "$e" in
+ no-*) e=`echo x$e | sed -e 's/xno-//'`; val=0 ;;
+ esac
+ errors="${errors} error[ari_${e}] = $val;"
done
if [ "$AWK" = "" ] ; then
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I6919faedf920e857df4f597df66f0ba3943e0eac
Gerrit-Change-Number: 750
Gerrit-PatchSet: 2
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Pedro Alves <palves@redhat.com>
Gerrit-MessageType: newpatchset
^ permalink raw reply [flat|nested] 5+ messages in thread
* [pushed] Accept -Wno- prefix in ARI
2019-12-05 15:45 [review] Accept -Wno- prefix in ARI Tom Tromey (Code Review)
2019-12-05 17:04 ` Pedro Alves (Code Review)
2019-12-12 17:51 ` [review v2] " Tom Tromey (Code Review)
@ 2019-12-13 22:17 ` Sourceware to Gerrit sync (Code Review)
2019-12-13 22:17 ` Sourceware to Gerrit sync (Code Review)
3 siblings, 0 replies; 5+ messages in thread
From: Sourceware to Gerrit sync (Code Review) @ 2019-12-13 22:17 UTC (permalink / raw)
To: Tom Tromey, gdb-patches; +Cc: Pedro Alves
Sourceware to Gerrit sync has submitted this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/750
......................................................................
Accept -Wno- prefix in ARI
This adds -Wno- support to ARI, so that warnings can be disabled
selectively. I use this to ignore "deprecated" warnings.
gdb/ChangeLog
2019-12-13 Tom Tromey <tromey@adacore.com>
* contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
Change-Id: I6919faedf920e857df4f597df66f0ba3943e0eac
---
M gdb/ChangeLog
M gdb/contrib/ari/gdb_ari.sh
2 files changed, 20 insertions(+), 3 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 93b0762..d30611f 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,9 @@
2019-12-13 Tom Tromey <tromey@adacore.com>
+ * contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
+
+2019-12-13 Tom Tromey <tromey@adacore.com>
+
* contrib/ari/gdb_ari.sh (usage): Use GNU style.
2019-12-13 Tom Tromey <tromey@adacore.com>
diff --git a/gdb/contrib/ari/gdb_ari.sh b/gdb/contrib/ari/gdb_ari.sh
index 4b0fddf..02c3647 100755
--- a/gdb/contrib/ari/gdb_ari.sh
+++ b/gdb/contrib/ari/gdb_ari.sh
@@ -60,7 +60,8 @@
-Werror Treat all problems as errors.
-Wall Report all problems.
-Wari Report problems that should be fixed in new code.
- -WCATEGORY Report problems in the specifed category. Valid categories
+ -WCATEGORY Report problems in the specifed category. The category
+ can be prefixed with "no-". Valid categories
are: ${all}
EOF
exit 1
@@ -102,6 +103,10 @@
# Validate all errors and warnings.
for w in ${warning} ${error}
do
+ case "$w" in
+ no-*) w=`echo x$w | sed -e 's/xno-//'`;;
+ esac
+
case " ${all} " in
*" ${w} "* ) ;;
* ) usage "Unknown option -W${w}" ;;
@@ -123,11 +128,19 @@
done
for w in ${warning}
do
- warnings="${warnings} warning[ari_${w}] = 1;"
+ val=1
+ case "$w" in
+ no-*) w=`echo x$w | sed -e 's/xno-//'`; val=0 ;;
+ esac
+ warnings="${warnings} warning[ari_${w}] = $val;"
done
for e in ${error}
do
- errors="${errors} error[ari_${e}] = 1;"
+ val=1
+ case "$e" in
+ no-*) e=`echo x$e | sed -e 's/xno-//'`; val=0 ;;
+ esac
+ errors="${errors} error[ari_${e}] = $val;"
done
if [ "$AWK" = "" ] ; then
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I6919faedf920e857df4f597df66f0ba3943e0eac
Gerrit-Change-Number: 750
Gerrit-PatchSet: 3
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Pedro Alves <palves@redhat.com>
Gerrit-MessageType: merged
^ permalink raw reply [flat|nested] 5+ messages in thread
* [pushed] Accept -Wno- prefix in ARI
2019-12-05 15:45 [review] Accept -Wno- prefix in ARI Tom Tromey (Code Review)
` (2 preceding siblings ...)
2019-12-13 22:17 ` [pushed] " Sourceware to Gerrit sync (Code Review)
@ 2019-12-13 22:17 ` Sourceware to Gerrit sync (Code Review)
3 siblings, 0 replies; 5+ messages in thread
From: Sourceware to Gerrit sync (Code Review) @ 2019-12-13 22:17 UTC (permalink / raw)
To: Tom Tromey, Pedro Alves, gdb-patches
The original change was created by Tom Tromey.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/750
......................................................................
Accept -Wno- prefix in ARI
This adds -Wno- support to ARI, so that warnings can be disabled
selectively. I use this to ignore "deprecated" warnings.
gdb/ChangeLog
2019-12-13 Tom Tromey <tromey@adacore.com>
* contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
Change-Id: I6919faedf920e857df4f597df66f0ba3943e0eac
---
M gdb/ChangeLog
M gdb/contrib/ari/gdb_ari.sh
2 files changed, 20 insertions(+), 3 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 93b0762..d30611f 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,9 @@
2019-12-13 Tom Tromey <tromey@adacore.com>
+ * contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
+
+2019-12-13 Tom Tromey <tromey@adacore.com>
+
* contrib/ari/gdb_ari.sh (usage): Use GNU style.
2019-12-13 Tom Tromey <tromey@adacore.com>
diff --git a/gdb/contrib/ari/gdb_ari.sh b/gdb/contrib/ari/gdb_ari.sh
index 4b0fddf..02c3647 100755
--- a/gdb/contrib/ari/gdb_ari.sh
+++ b/gdb/contrib/ari/gdb_ari.sh
@@ -60,7 +60,8 @@
-Werror Treat all problems as errors.
-Wall Report all problems.
-Wari Report problems that should be fixed in new code.
- -WCATEGORY Report problems in the specifed category. Valid categories
+ -WCATEGORY Report problems in the specifed category. The category
+ can be prefixed with "no-". Valid categories
are: ${all}
EOF
exit 1
@@ -102,6 +103,10 @@
# Validate all errors and warnings.
for w in ${warning} ${error}
do
+ case "$w" in
+ no-*) w=`echo x$w | sed -e 's/xno-//'`;;
+ esac
+
case " ${all} " in
*" ${w} "* ) ;;
* ) usage "Unknown option -W${w}" ;;
@@ -123,11 +128,19 @@
done
for w in ${warning}
do
- warnings="${warnings} warning[ari_${w}] = 1;"
+ val=1
+ case "$w" in
+ no-*) w=`echo x$w | sed -e 's/xno-//'`; val=0 ;;
+ esac
+ warnings="${warnings} warning[ari_${w}] = $val;"
done
for e in ${error}
do
- errors="${errors} error[ari_${e}] = 1;"
+ val=1
+ case "$e" in
+ no-*) e=`echo x$e | sed -e 's/xno-//'`; val=0 ;;
+ esac
+ errors="${errors} error[ari_${e}] = $val;"
done
if [ "$AWK" = "" ] ; then
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I6919faedf920e857df4f597df66f0ba3943e0eac
Gerrit-Change-Number: 750
Gerrit-PatchSet: 3
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Pedro Alves <palves@redhat.com>
Gerrit-MessageType: newpatchset
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-12-13 22:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-05 15:45 [review] Accept -Wno- prefix in ARI Tom Tromey (Code Review)
2019-12-05 17:04 ` Pedro Alves (Code Review)
2019-12-12 17:51 ` [review v2] " Tom Tromey (Code Review)
2019-12-13 22:17 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-12-13 22:17 ` Sourceware to Gerrit sync (Code Review)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).