From: "Sourceware to Gerrit sync (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Tom Tromey <tromey@sourceware.org>, gdb-patches@sourceware.org
Cc: Pedro Alves <palves@redhat.com>
Subject: [pushed] Accept -Wno- prefix in ARI
Date: Fri, 13 Dec 2019 22:17:00 -0000 [thread overview]
Message-ID: <20191213221710.411512817F@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1575560698000.I6919faedf920e857df4f597df66f0ba3943e0eac@gnutoolchain-gerrit.osci.io>
Sourceware to Gerrit sync has submitted this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/750
......................................................................
Accept -Wno- prefix in ARI
This adds -Wno- support to ARI, so that warnings can be disabled
selectively. I use this to ignore "deprecated" warnings.
gdb/ChangeLog
2019-12-13 Tom Tromey <tromey@adacore.com>
* contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
Change-Id: I6919faedf920e857df4f597df66f0ba3943e0eac
---
M gdb/ChangeLog
M gdb/contrib/ari/gdb_ari.sh
2 files changed, 20 insertions(+), 3 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 93b0762..d30611f 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,9 @@
2019-12-13 Tom Tromey <tromey@adacore.com>
+ * contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
+
+2019-12-13 Tom Tromey <tromey@adacore.com>
+
* contrib/ari/gdb_ari.sh (usage): Use GNU style.
2019-12-13 Tom Tromey <tromey@adacore.com>
diff --git a/gdb/contrib/ari/gdb_ari.sh b/gdb/contrib/ari/gdb_ari.sh
index 4b0fddf..02c3647 100755
--- a/gdb/contrib/ari/gdb_ari.sh
+++ b/gdb/contrib/ari/gdb_ari.sh
@@ -60,7 +60,8 @@
-Werror Treat all problems as errors.
-Wall Report all problems.
-Wari Report problems that should be fixed in new code.
- -WCATEGORY Report problems in the specifed category. Valid categories
+ -WCATEGORY Report problems in the specifed category. The category
+ can be prefixed with "no-". Valid categories
are: ${all}
EOF
exit 1
@@ -102,6 +103,10 @@
# Validate all errors and warnings.
for w in ${warning} ${error}
do
+ case "$w" in
+ no-*) w=`echo x$w | sed -e 's/xno-//'`;;
+ esac
+
case " ${all} " in
*" ${w} "* ) ;;
* ) usage "Unknown option -W${w}" ;;
@@ -123,11 +128,19 @@
done
for w in ${warning}
do
- warnings="${warnings} warning[ari_${w}] = 1;"
+ val=1
+ case "$w" in
+ no-*) w=`echo x$w | sed -e 's/xno-//'`; val=0 ;;
+ esac
+ warnings="${warnings} warning[ari_${w}] = $val;"
done
for e in ${error}
do
- errors="${errors} error[ari_${e}] = 1;"
+ val=1
+ case "$e" in
+ no-*) e=`echo x$e | sed -e 's/xno-//'`; val=0 ;;
+ esac
+ errors="${errors} error[ari_${e}] = $val;"
done
if [ "$AWK" = "" ] ; then
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I6919faedf920e857df4f597df66f0ba3943e0eac
Gerrit-Change-Number: 750
Gerrit-PatchSet: 3
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Pedro Alves <palves@redhat.com>
Gerrit-MessageType: merged
prev parent reply other threads:[~2019-12-13 22:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-05 15:45 [review] " Tom Tromey (Code Review)
2019-12-05 17:04 ` Pedro Alves (Code Review)
2019-12-12 17:51 ` [review v2] " Tom Tromey (Code Review)
2019-12-13 22:17 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-12-13 22:17 ` Sourceware to Gerrit sync (Code Review) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191213221710.411512817F@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=gdb-patches@sourceware.org \
--cc=noreply@gnutoolchain-gerrit.osci.io \
--cc=palves@redhat.com \
--cc=tromey@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).