* [review] Remove "fix" call for "long long" from ARI
@ 2019-12-12 17:51 Tom Tromey (Code Review)
2019-12-13 14:38 ` Pedro Alves (Code Review)
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Tom Tromey (Code Review) @ 2019-12-12 17:51 UTC (permalink / raw)
To: gdb-patches
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/755
......................................................................
Remove "fix" call for "long long" from ARI
ARI has a "fix" call for "long long", but this call is incorrect.
This patch removes it.
gdb/ChangeLog
2019-12-12 Tom Tromey <tromey@adacore.com>
* contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
Change-Id: I97bca2dc04b579fcf7c9dba7fe7fd939451bcefa
---
M gdb/ChangeLog
M gdb/contrib/ari/gdb_ari.sh
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 0c810e3..2911956 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2019-12-12 Tom Tromey <tromey@adacore.com>
+
+ * contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
+
2019-12-05 Tom Tromey <tromey@adacore.com>
* contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
diff --git a/gdb/contrib/ari/gdb_ari.sh b/gdb/contrib/ari/gdb_ari.sh
index 02c3647..5f05890 100755
--- a/gdb/contrib/ari/gdb_ari.sh
+++ b/gdb/contrib/ari/gdb_ari.sh
@@ -587,8 +587,6 @@
BEGIN { doc["long long"] = "\
Do not use `long long'\'', instead use LONGEST"
category["long long"] = ari_code
- # defs.h needs two such patterns for LONGEST and ULONGEST definitions
- fix("long long", "gdb/defs.h", 2)
}
/(^|[^_[:alnum:]])long[[:space:]]+long([^_[:alnum:]]|$)/ {
fail("long long")
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I97bca2dc04b579fcf7c9dba7fe7fd939451bcefa
Gerrit-Change-Number: 755
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-MessageType: newchange
^ permalink raw reply [flat|nested] 5+ messages in thread
* [review] Remove "fix" call for "long long" from ARI
2019-12-12 17:51 [review] Remove "fix" call for "long long" from ARI Tom Tromey (Code Review)
@ 2019-12-13 14:38 ` Pedro Alves (Code Review)
2019-12-13 19:27 ` Tom Tromey (Code Review)
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Pedro Alves (Code Review) @ 2019-12-13 14:38 UTC (permalink / raw)
To: Tom Tromey, gdb-patches
Pedro Alves has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/755
......................................................................
Patch Set 1:
(1 comment)
| --- /dev/null
| +++ /COMMIT_MSG
| @@ -1,0 +1,17 @@
| +Parent: 13e991b1 (Accept -Wno- prefix in ARI)
| +Author: Tom Tromey <tromey@adacore.com>
| +AuthorDate: 2019-12-12 09:10:49 -0700
| +Commit: Tom Tromey <tromey@adacore.com>
| +CommitDate: 2019-12-12 10:31:38 -0700
| +
| +Remove "fix" call for "long long" from ARI
| +
| +ARI has a "fix" call for "long long", but this call is incorrect.
| +This patch removes it.
PS1, Line 10:
More like the definitions of ULONGEST/LONGEST moved from defs.h to
gdbsupport/common-types.h. I don't see markers there, don't we need
them?
| +
| +gdb/ChangeLog
| +2019-12-12 Tom Tromey <tromey@adacore.com>
| +
| + * contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
| +
| +Change-Id: I97bca2dc04b579fcf7c9dba7fe7fd939451bcefa
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I97bca2dc04b579fcf7c9dba7fe7fd939451bcefa
Gerrit-Change-Number: 755
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-CC: Pedro Alves <palves@redhat.com>
Gerrit-Comment-Date: Fri, 13 Dec 2019 14:38:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
^ permalink raw reply [flat|nested] 5+ messages in thread
* [review] Remove "fix" call for "long long" from ARI
2019-12-12 17:51 [review] Remove "fix" call for "long long" from ARI Tom Tromey (Code Review)
2019-12-13 14:38 ` Pedro Alves (Code Review)
@ 2019-12-13 19:27 ` Tom Tromey (Code Review)
2019-12-13 22:17 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-12-13 22:17 ` Sourceware to Gerrit sync (Code Review)
3 siblings, 0 replies; 5+ messages in thread
From: Tom Tromey (Code Review) @ 2019-12-13 19:27 UTC (permalink / raw)
To: gdb-patches; +Cc: Pedro Alves
Tom Tromey has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/755
......................................................................
Patch Set 1:
(1 comment)
| --- /dev/null
| +++ /COMMIT_MSG
| @@ -1,0 +1,17 @@
| +Parent: 13e991b1 (Accept -Wno- prefix in ARI)
| +Author: Tom Tromey <tromey@adacore.com>
| +AuthorDate: 2019-12-12 09:10:49 -0700
| +Commit: Tom Tromey <tromey@adacore.com>
| +CommitDate: 2019-12-12 10:31:38 -0700
| +
| +Remove "fix" call for "long long" from ARI
| +
| +ARI has a "fix" call for "long long", but this call is incorrect.
| +This patch removes it.
PS1, Line 10:
> More like the definitions of ULONGEST/LONGEST moved from defs.h to gdbsupport/common-types.h. I don't see markers there, don't we need them?
Yeah, probably so. There are a few ways of running ARI, and
the one I'm mostly using doesn't note these. If you do enable
more warnings, you'll see a lot -- my "-Wari" run shows 637
(but some of these are warnings about deprecated or legacy
things, which I think aren't very interesting).
| +
| +gdb/ChangeLog
| +2019-12-12 Tom Tromey <tromey@adacore.com>
| +
| + * contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
| +
| +Change-Id: I97bca2dc04b579fcf7c9dba7fe7fd939451bcefa
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I97bca2dc04b579fcf7c9dba7fe7fd939451bcefa
Gerrit-Change-Number: 755
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-CC: Pedro Alves <palves@redhat.com>
Gerrit-Comment-Date: Fri, 13 Dec 2019 19:27:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Pedro Alves <palves@redhat.com>
Gerrit-MessageType: comment
^ permalink raw reply [flat|nested] 5+ messages in thread
* [pushed] Remove "fix" call for "long long" from ARI
2019-12-12 17:51 [review] Remove "fix" call for "long long" from ARI Tom Tromey (Code Review)
` (2 preceding siblings ...)
2019-12-13 22:17 ` [pushed] " Sourceware to Gerrit sync (Code Review)
@ 2019-12-13 22:17 ` Sourceware to Gerrit sync (Code Review)
3 siblings, 0 replies; 5+ messages in thread
From: Sourceware to Gerrit sync (Code Review) @ 2019-12-13 22:17 UTC (permalink / raw)
To: Tom Tromey, gdb-patches; +Cc: Pedro Alves
Sourceware to Gerrit sync has submitted this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/755
......................................................................
Remove "fix" call for "long long" from ARI
ARI has a "fix" call for "long long", but this call is incorrect.
This patch removes it.
gdb/ChangeLog
2019-12-13 Tom Tromey <tromey@adacore.com>
* contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
Change-Id: I97bca2dc04b579fcf7c9dba7fe7fd939451bcefa
---
M gdb/ChangeLog
M gdb/contrib/ari/gdb_ari.sh
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index d30611f..90c3742 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,9 @@
2019-12-13 Tom Tromey <tromey@adacore.com>
+ * contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
+
+2019-12-13 Tom Tromey <tromey@adacore.com>
+
* contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
2019-12-13 Tom Tromey <tromey@adacore.com>
diff --git a/gdb/contrib/ari/gdb_ari.sh b/gdb/contrib/ari/gdb_ari.sh
index 02c3647..5f05890 100755
--- a/gdb/contrib/ari/gdb_ari.sh
+++ b/gdb/contrib/ari/gdb_ari.sh
@@ -587,8 +587,6 @@
BEGIN { doc["long long"] = "\
Do not use `long long'\'', instead use LONGEST"
category["long long"] = ari_code
- # defs.h needs two such patterns for LONGEST and ULONGEST definitions
- fix("long long", "gdb/defs.h", 2)
}
/(^|[^_[:alnum:]])long[[:space:]]+long([^_[:alnum:]]|$)/ {
fail("long long")
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I97bca2dc04b579fcf7c9dba7fe7fd939451bcefa
Gerrit-Change-Number: 755
Gerrit-PatchSet: 2
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-CC: Pedro Alves <palves@redhat.com>
Gerrit-MessageType: merged
^ permalink raw reply [flat|nested] 5+ messages in thread
* [pushed] Remove "fix" call for "long long" from ARI
2019-12-12 17:51 [review] Remove "fix" call for "long long" from ARI Tom Tromey (Code Review)
2019-12-13 14:38 ` Pedro Alves (Code Review)
2019-12-13 19:27 ` Tom Tromey (Code Review)
@ 2019-12-13 22:17 ` Sourceware to Gerrit sync (Code Review)
2019-12-13 22:17 ` Sourceware to Gerrit sync (Code Review)
3 siblings, 0 replies; 5+ messages in thread
From: Sourceware to Gerrit sync (Code Review) @ 2019-12-13 22:17 UTC (permalink / raw)
To: Tom Tromey, gdb-patches; +Cc: Pedro Alves
The original change was created by Tom Tromey.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/755
......................................................................
Remove "fix" call for "long long" from ARI
ARI has a "fix" call for "long long", but this call is incorrect.
This patch removes it.
gdb/ChangeLog
2019-12-13 Tom Tromey <tromey@adacore.com>
* contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
Change-Id: I97bca2dc04b579fcf7c9dba7fe7fd939451bcefa
---
M gdb/ChangeLog
M gdb/contrib/ari/gdb_ari.sh
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index d30611f..90c3742 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,9 @@
2019-12-13 Tom Tromey <tromey@adacore.com>
+ * contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
+
+2019-12-13 Tom Tromey <tromey@adacore.com>
+
* contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
2019-12-13 Tom Tromey <tromey@adacore.com>
diff --git a/gdb/contrib/ari/gdb_ari.sh b/gdb/contrib/ari/gdb_ari.sh
index 02c3647..5f05890 100755
--- a/gdb/contrib/ari/gdb_ari.sh
+++ b/gdb/contrib/ari/gdb_ari.sh
@@ -587,8 +587,6 @@
BEGIN { doc["long long"] = "\
Do not use `long long'\'', instead use LONGEST"
category["long long"] = ari_code
- # defs.h needs two such patterns for LONGEST and ULONGEST definitions
- fix("long long", "gdb/defs.h", 2)
}
/(^|[^_[:alnum:]])long[[:space:]]+long([^_[:alnum:]]|$)/ {
fail("long long")
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I97bca2dc04b579fcf7c9dba7fe7fd939451bcefa
Gerrit-Change-Number: 755
Gerrit-PatchSet: 2
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-Reviewer: Tom Tromey <tromey@sourceware.org>
Gerrit-CC: Pedro Alves <palves@redhat.com>
Gerrit-MessageType: newpatchset
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-12-13 22:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-12 17:51 [review] Remove "fix" call for "long long" from ARI Tom Tromey (Code Review)
2019-12-13 14:38 ` Pedro Alves (Code Review)
2019-12-13 19:27 ` Tom Tromey (Code Review)
2019-12-13 22:17 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-12-13 22:17 ` Sourceware to Gerrit sync (Code Review)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).