From: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>
To: gdb-patches@sourceware.org
Cc: Christian Biesinger <cbiesinger@google.com>
Subject: [PATCH 2/3] Cast the log10 argument to double to disambiguate it
Date: Thu, 19 Dec 2019 00:01:00 -0000 [thread overview]
Message-ID: <20191219000103.36667-4-cbiesinger@google.com> (raw)
In-Reply-To: <20191219000103.36667-1-cbiesinger@google.com>
On Solaris 11 with gcc 5.5.0 (gcc211 on the compile farm), math.h has a
using std::log10; directive. This is unfortunate because std::log10 has
overloads for float/double/long double. To disambiguate this call,
cast the argument to double to fix the build.
Change-Id: I6c0c52e9c172b529c899a435d430e5916aeef69f
---
gdb/tui/tui-source.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/tui/tui-source.c b/gdb/tui/tui-source.c
index 32877d7bc8..1274e81674 100644
--- a/gdb/tui/tui-source.c
+++ b/gdb/tui/tui-source.c
@@ -85,7 +85,7 @@ tui_source_window::set_contents (struct gdbarch *arch,
int digits = 0;
if (compact_source)
{
- double l = log10 (offsets->size ());
+ double l = log10 ((double) offsets->size ());
digits = 1 + (int) l;
}
--
2.24.1.735.g03f4e72817-goog
next prev parent reply other threads:[~2019-12-19 0:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 0:01 [PATCH 0/3] Fix Solaris build with enable-targets=all Christian Biesinger via gdb-patches
2019-12-19 0:01 ` [PATCH 1/3] Undef REG_Y in s12z.h, it may be defined in a system header Christian Biesinger via gdb-patches
2019-12-19 18:18 ` Tom Tromey
2019-12-19 0:01 ` [PATCH 3/3] Make the literal argument to pow a double, not an integer Christian Biesinger via gdb-patches
2019-12-19 18:19 ` Tom Tromey
2019-12-19 19:13 ` Christian Biesinger via gdb-patches
2019-12-19 0:01 ` Christian Biesinger via gdb-patches [this message]
2019-12-19 3:35 ` [PATCH 2/3] Cast the log10 argument to double to disambiguate it Eli Zaretskii
2019-12-19 18:17 ` Tom Tromey
2019-12-19 19:11 ` Christian Biesinger via gdb-patches
2019-12-19 0:01 ` [PATCH] Rename "sun" variable to avoid conflicts on Solaris Christian Biesinger via gdb-patches
2019-12-19 19:14 ` [PATCH 0/3] Fix Solaris build with enable-targets=all Christian Biesinger via gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191219000103.36667-4-cbiesinger@google.com \
--to=gdb-patches@sourceware.org \
--cc=cbiesinger@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).