public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* [review] Remove parameters from tui_show_source
@ 2019-11-14 23:35 Tom Tromey (Code Review)
  2019-12-12  2:35 ` [review v2] " Tom Tromey (Code Review)
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Tom Tromey (Code Review) @ 2019-11-14 23:35 UTC (permalink / raw)
  To: gdb-patches

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/631
......................................................................

Remove parameters from tui_show_source

tui_show_source does not need its parameters, so this removes them.

gdb/ChangeLog
2019-11-14  Tom Tromey  <tom@tromey.com>

	* tui/tui.h (tui_show_source): Remove parameters.
	* tui/tui.c (tui_show_source): Remove parameters.
	* tui/tui-out.c (tui_ui_out::do_field_string): Update.

Change-Id: I7cbcf20175b459c269549f1832d4fb844cc573db
---
M gdb/ChangeLog
M gdb/tui/tui-out.c
M gdb/tui/tui.c
M gdb/tui/tui.h
4 files changed, 10 insertions(+), 4 deletions(-)



diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 9876734..b2a7b24 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,11 @@
 2019-11-14  Tom Tromey  <tom@tromey.com>
 
+	* tui/tui.h (tui_show_source): Remove parameters.
+	* tui/tui.c (tui_show_source): Remove parameters.
+	* tui/tui-out.c (tui_ui_out::do_field_string): Update.
+
+2019-11-14  Tom Tromey  <tom@tromey.com>
+
 	* tui/tui.c (tui_show_source): Update.
 	* tui/tui-winsource.c (tui_display_main): Update.
 	* tui/tui-stack.h (tui_update_locator_fullname): Change parameter
diff --git a/gdb/tui/tui-out.c b/gdb/tui/tui-out.c
index 0d3f3be..95543ff 100644
--- a/gdb/tui/tui-out.c
+++ b/gdb/tui/tui-out.c
@@ -61,7 +61,7 @@
 
   if (fldname && m_line > 0 && strcmp (fldname, "fullname") == 0)
     {
-      tui_show_source (string, m_line);
+      tui_show_source ();
       return;
     }
 
diff --git a/gdb/tui/tui.c b/gdb/tui/tui.c
index 0ec10b6..472d0da 100644
--- a/gdb/tui/tui.c
+++ b/gdb/tui/tui.c
@@ -626,14 +626,14 @@
 #endif
 
 void
-tui_show_source (const char *fullname, int line)
+tui_show_source ()
 {
   struct symtab_and_line cursal = get_current_source_symtab_and_line ();
 
   /* Make sure that the source window is displayed.  */
   tui_add_win_to_layout (SRC_WIN);
 
-  tui_update_source_windows_with_line (cursal.symtab, line);
+  tui_update_source_windows_with_line (cursal.symtab, cursal.line);
   tui_update_locator_fullname (cursal.symtab);
 }
 
diff --git a/gdb/tui/tui.h b/gdb/tui/tui.h
index dac410f..0ac1fb4 100644
--- a/gdb/tui/tui.h
+++ b/gdb/tui/tui.h
@@ -83,6 +83,6 @@
 
 extern int tui_active;
 
-extern void tui_show_source (const char *fullname, int line);
+extern void tui_show_source ();
 
 #endif /* TUI_TUI_H */

-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I7cbcf20175b459c269549f1832d4fb844cc573db
Gerrit-Change-Number: 631
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-MessageType: newchange

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [review v2] Remove parameters from tui_show_source
  2019-11-14 23:35 [review] Remove parameters from tui_show_source Tom Tromey (Code Review)
@ 2019-12-12  2:35 ` Tom Tromey (Code Review)
  2019-12-20 16:20 ` [pushed] " Sourceware to Gerrit sync (Code Review)
  2019-12-20 16:29 ` Sourceware to Gerrit sync (Code Review)
  2 siblings, 0 replies; 4+ messages in thread
From: Tom Tromey (Code Review) @ 2019-12-12  2:35 UTC (permalink / raw)
  To: gdb-patches

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/631
......................................................................

Remove parameters from tui_show_source

tui_show_source does not need its parameters, so this removes them.

gdb/ChangeLog
2019-12-11  Tom Tromey  <tom@tromey.com>

	* tui/tui.h (tui_show_source): Remove parameters.
	* tui/tui.c (tui_show_source): Remove parameters.
	* tui/tui-out.c (tui_ui_out::do_field_string): Update.

Change-Id: I7cbcf20175b459c269549f1832d4fb844cc573db
---
M gdb/ChangeLog
M gdb/tui/tui-out.c
M gdb/tui/tui.c
M gdb/tui/tui.h
4 files changed, 10 insertions(+), 4 deletions(-)



diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 3dd12c3..ed79ccd 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,11 @@
 2019-12-11  Tom Tromey  <tom@tromey.com>
 
+	* tui/tui.h (tui_show_source): Remove parameters.
+	* tui/tui.c (tui_show_source): Remove parameters.
+	* tui/tui-out.c (tui_ui_out::do_field_string): Update.
+
+2019-12-11  Tom Tromey  <tom@tromey.com>
+
 	* tui/tui.c (tui_show_source): Update.
 	* tui/tui-winsource.c (tui_display_main): Update.
 	* tui/tui-stack.h (tui_update_locator_fullname): Change parameter
diff --git a/gdb/tui/tui-out.c b/gdb/tui/tui-out.c
index 0d3f3be..95543ff 100644
--- a/gdb/tui/tui-out.c
+++ b/gdb/tui/tui-out.c
@@ -61,7 +61,7 @@
 
   if (fldname && m_line > 0 && strcmp (fldname, "fullname") == 0)
     {
-      tui_show_source (string, m_line);
+      tui_show_source ();
       return;
     }
 
diff --git a/gdb/tui/tui.c b/gdb/tui/tui.c
index 8bffb30..deb6bb2 100644
--- a/gdb/tui/tui.c
+++ b/gdb/tui/tui.c
@@ -627,14 +627,14 @@
 #endif
 
 void
-tui_show_source (const char *fullname, int line)
+tui_show_source ()
 {
   struct symtab_and_line cursal = get_current_source_symtab_and_line ();
 
   /* Make sure that the source window is displayed.  */
   tui_add_win_to_layout (SRC_WIN);
 
-  tui_update_source_windows_with_line (cursal.symtab, line);
+  tui_update_source_windows_with_line (cursal.symtab, cursal.line);
   tui_update_locator_fullname (cursal.symtab);
 }
 
diff --git a/gdb/tui/tui.h b/gdb/tui/tui.h
index dac410f..0ac1fb4 100644
--- a/gdb/tui/tui.h
+++ b/gdb/tui/tui.h
@@ -83,6 +83,6 @@
 
 extern int tui_active;
 
-extern void tui_show_source (const char *fullname, int line);
+extern void tui_show_source ();
 
 #endif /* TUI_TUI_H */

-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I7cbcf20175b459c269549f1832d4fb844cc573db
Gerrit-Change-Number: 631
Gerrit-PatchSet: 2
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-MessageType: newpatchset

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [pushed] Remove parameters from tui_show_source
  2019-11-14 23:35 [review] Remove parameters from tui_show_source Tom Tromey (Code Review)
  2019-12-12  2:35 ` [review v2] " Tom Tromey (Code Review)
@ 2019-12-20 16:20 ` Sourceware to Gerrit sync (Code Review)
  2019-12-20 16:29 ` Sourceware to Gerrit sync (Code Review)
  2 siblings, 0 replies; 4+ messages in thread
From: Sourceware to Gerrit sync (Code Review) @ 2019-12-20 16:20 UTC (permalink / raw)
  To: Tom Tromey, gdb-patches

The original change was created by Tom Tromey.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/631
......................................................................

Remove parameters from tui_show_source

tui_show_source does not need its parameters, so this removes them.

gdb/ChangeLog
2019-12-20  Tom Tromey  <tom@tromey.com>

	* tui/tui.h (tui_show_source): Remove parameters.
	* tui/tui.c (tui_show_source): Remove parameters.
	* tui/tui-out.c (tui_ui_out::do_field_string): Update.

Change-Id: I7cbcf20175b459c269549f1832d4fb844cc573db
---
M gdb/ChangeLog
M gdb/tui/tui-out.c
M gdb/tui/tui.c
M gdb/tui/tui.h
4 files changed, 10 insertions(+), 4 deletions(-)



diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 5a79f6a..3815b59 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,11 @@
 2019-12-20  Tom Tromey  <tom@tromey.com>
 
+	* tui/tui.h (tui_show_source): Remove parameters.
+	* tui/tui.c (tui_show_source): Remove parameters.
+	* tui/tui-out.c (tui_ui_out::do_field_string): Update.
+
+2019-12-20  Tom Tromey  <tom@tromey.com>
+
 	* tui/tui.c (tui_show_source): Update.
 	* tui/tui-winsource.c (tui_display_main): Update.
 	* tui/tui-stack.h (tui_update_locator_fullname): Change parameter
diff --git a/gdb/tui/tui-out.c b/gdb/tui/tui-out.c
index 0d3f3be..95543ff 100644
--- a/gdb/tui/tui-out.c
+++ b/gdb/tui/tui-out.c
@@ -61,7 +61,7 @@
 
   if (fldname && m_line > 0 && strcmp (fldname, "fullname") == 0)
     {
-      tui_show_source (string, m_line);
+      tui_show_source ();
       return;
     }
 
diff --git a/gdb/tui/tui.c b/gdb/tui/tui.c
index 8bffb30..deb6bb2 100644
--- a/gdb/tui/tui.c
+++ b/gdb/tui/tui.c
@@ -627,14 +627,14 @@
 #endif
 
 void
-tui_show_source (const char *fullname, int line)
+tui_show_source ()
 {
   struct symtab_and_line cursal = get_current_source_symtab_and_line ();
 
   /* Make sure that the source window is displayed.  */
   tui_add_win_to_layout (SRC_WIN);
 
-  tui_update_source_windows_with_line (cursal.symtab, line);
+  tui_update_source_windows_with_line (cursal.symtab, cursal.line);
   tui_update_locator_fullname (cursal.symtab);
 }
 
diff --git a/gdb/tui/tui.h b/gdb/tui/tui.h
index dac410f..0ac1fb4 100644
--- a/gdb/tui/tui.h
+++ b/gdb/tui/tui.h
@@ -83,6 +83,6 @@
 
 extern int tui_active;
 
-extern void tui_show_source (const char *fullname, int line);
+extern void tui_show_source ();
 
 #endif /* TUI_TUI_H */

-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I7cbcf20175b459c269549f1832d4fb844cc573db
Gerrit-Change-Number: 631
Gerrit-PatchSet: 3
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-MessageType: newpatchset

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [pushed] Remove parameters from tui_show_source
  2019-11-14 23:35 [review] Remove parameters from tui_show_source Tom Tromey (Code Review)
  2019-12-12  2:35 ` [review v2] " Tom Tromey (Code Review)
  2019-12-20 16:20 ` [pushed] " Sourceware to Gerrit sync (Code Review)
@ 2019-12-20 16:29 ` Sourceware to Gerrit sync (Code Review)
  2 siblings, 0 replies; 4+ messages in thread
From: Sourceware to Gerrit sync (Code Review) @ 2019-12-20 16:29 UTC (permalink / raw)
  To: Tom Tromey, gdb-patches

Sourceware to Gerrit sync has submitted this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/631
......................................................................

Remove parameters from tui_show_source

tui_show_source does not need its parameters, so this removes them.

gdb/ChangeLog
2019-12-20  Tom Tromey  <tom@tromey.com>

	* tui/tui.h (tui_show_source): Remove parameters.
	* tui/tui.c (tui_show_source): Remove parameters.
	* tui/tui-out.c (tui_ui_out::do_field_string): Update.

Change-Id: I7cbcf20175b459c269549f1832d4fb844cc573db
---
M gdb/ChangeLog
M gdb/tui/tui-out.c
M gdb/tui/tui.c
M gdb/tui/tui.h
4 files changed, 10 insertions(+), 4 deletions(-)


diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 5a79f6a..3815b59 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,11 @@
 2019-12-20  Tom Tromey  <tom@tromey.com>
 
+	* tui/tui.h (tui_show_source): Remove parameters.
+	* tui/tui.c (tui_show_source): Remove parameters.
+	* tui/tui-out.c (tui_ui_out::do_field_string): Update.
+
+2019-12-20  Tom Tromey  <tom@tromey.com>
+
 	* tui/tui.c (tui_show_source): Update.
 	* tui/tui-winsource.c (tui_display_main): Update.
 	* tui/tui-stack.h (tui_update_locator_fullname): Change parameter
diff --git a/gdb/tui/tui-out.c b/gdb/tui/tui-out.c
index 0d3f3be..95543ff 100644
--- a/gdb/tui/tui-out.c
+++ b/gdb/tui/tui-out.c
@@ -61,7 +61,7 @@
 
   if (fldname && m_line > 0 && strcmp (fldname, "fullname") == 0)
     {
-      tui_show_source (string, m_line);
+      tui_show_source ();
       return;
     }
 
diff --git a/gdb/tui/tui.c b/gdb/tui/tui.c
index 8bffb30..deb6bb2 100644
--- a/gdb/tui/tui.c
+++ b/gdb/tui/tui.c
@@ -627,14 +627,14 @@
 #endif
 
 void
-tui_show_source (const char *fullname, int line)
+tui_show_source ()
 {
   struct symtab_and_line cursal = get_current_source_symtab_and_line ();
 
   /* Make sure that the source window is displayed.  */
   tui_add_win_to_layout (SRC_WIN);
 
-  tui_update_source_windows_with_line (cursal.symtab, line);
+  tui_update_source_windows_with_line (cursal.symtab, cursal.line);
   tui_update_locator_fullname (cursal.symtab);
 }
 
diff --git a/gdb/tui/tui.h b/gdb/tui/tui.h
index dac410f..0ac1fb4 100644
--- a/gdb/tui/tui.h
+++ b/gdb/tui/tui.h
@@ -83,6 +83,6 @@
 
 extern int tui_active;
 
-extern void tui_show_source (const char *fullname, int line);
+extern void tui_show_source ();
 
 #endif /* TUI_TUI_H */

-- 
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I7cbcf20175b459c269549f1832d4fb844cc573db
Gerrit-Change-Number: 631
Gerrit-PatchSet: 3
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-MessageType: merged

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-12-20 16:28 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-14 23:35 [review] Remove parameters from tui_show_source Tom Tromey (Code Review)
2019-12-12  2:35 ` [review v2] " Tom Tromey (Code Review)
2019-12-20 16:20 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-12-20 16:29 ` Sourceware to Gerrit sync (Code Review)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).