* [review] Use bool in tui_before_prompt
@ 2019-11-14 23:41 Tom Tromey (Code Review)
2019-12-12 2:41 ` [review v2] " Tom Tromey (Code Review)
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Tom Tromey (Code Review) @ 2019-11-14 23:41 UTC (permalink / raw)
To: gdb-patches
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/648
......................................................................
Use bool in tui_before_prompt
This changes tui_before_prompt to take a bool rather than an int.
gdb/ChangeLog
2019-11-14 Tom Tromey <tom@tromey.com>
* tui/tui-hooks.c (tui_before_prompt): Change parameter to bool.
(tui_before_prompt, tui_normal_stop): Update.
Change-Id: I9c7f2b764748fe19621851dc4fed4775a6db211a
---
M gdb/ChangeLog
M gdb/tui/tui-hooks.c
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index dbe3a93..f47d517 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
2019-11-14 Tom Tromey <tom@tromey.com>
+ * tui/tui-hooks.c (tui_before_prompt): Change parameter to bool.
+ (tui_before_prompt, tui_normal_stop): Update.
+
+2019-11-14 Tom Tromey <tom@tromey.com>
+
* tui/tui-winsource.c
(tui_source_window_base::update_source_window_as_is): Don't call
set_current_source_symtab_and_line.
diff --git a/gdb/tui/tui-hooks.c b/gdb/tui/tui-hooks.c
index bb96f4d..35a9259 100644
--- a/gdb/tui/tui-hooks.c
+++ b/gdb/tui/tui-hooks.c
@@ -112,7 +112,7 @@
if frame information hasn't changed. */
static void
-tui_refresh_frame_and_register_information (int registers_too_p)
+tui_refresh_frame_and_register_information (bool registers_too_p)
{
struct frame_info *fi;
CORE_ADDR pc;
@@ -188,7 +188,7 @@
refresh registers here unless the frame actually changed by one of these
commands. Registers will otherwise be refreshed after a normal stop or by
our tui_register_changed_hook. */
- tui_refresh_frame_and_register_information (/*registers_too_p=*/0);
+ tui_refresh_frame_and_register_information (/*registers_too_p=*/false);
}
/* Observer for the normal_stop notification. */
@@ -198,7 +198,7 @@
{
/* This refresh is intended to catch changes to the selected frame and to
registers following a normal stop. */
- tui_refresh_frame_and_register_information (/*registers_too_p=*/1);
+ tui_refresh_frame_and_register_information (/*registers_too_p=*/true);
}
/* Token associated with observers registered while TUI hooks are
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I9c7f2b764748fe19621851dc4fed4775a6db211a
Gerrit-Change-Number: 648
Gerrit-PatchSet: 1
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-MessageType: newchange
^ permalink raw reply [flat|nested] 4+ messages in thread
* [review v2] Use bool in tui_before_prompt
2019-11-14 23:41 [review] Use bool in tui_before_prompt Tom Tromey (Code Review)
@ 2019-12-12 2:41 ` Tom Tromey (Code Review)
2019-12-20 16:21 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-12-20 16:21 ` Sourceware to Gerrit sync (Code Review)
2 siblings, 0 replies; 4+ messages in thread
From: Tom Tromey (Code Review) @ 2019-12-12 2:41 UTC (permalink / raw)
To: gdb-patches
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/648
......................................................................
Use bool in tui_before_prompt
This changes tui_before_prompt to take a bool rather than an int.
2019-12-11 Tom Tromey <tom@tromey.com>
* tui/tui-hooks.c (tui_before_prompt): Change parameter to bool.
(tui_before_prompt, tui_normal_stop): Update.
Change-Id: I9c7f2b764748fe19621851dc4fed4775a6db211a
---
M gdb/ChangeLog
M gdb/tui/tui-hooks.c
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index da348cd..3c30e38 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
2019-12-11 Tom Tromey <tom@tromey.com>
+ * tui/tui-hooks.c (tui_before_prompt): Change parameter to bool.
+ (tui_before_prompt, tui_normal_stop): Update.
+
+2019-12-11 Tom Tromey <tom@tromey.com>
+
* tui/tui-winsource.c
(tui_source_window_base::update_source_window_as_is): Don't call
set_current_source_symtab_and_line.
diff --git a/gdb/tui/tui-hooks.c b/gdb/tui/tui-hooks.c
index bb96f4d..35a9259 100644
--- a/gdb/tui/tui-hooks.c
+++ b/gdb/tui/tui-hooks.c
@@ -112,7 +112,7 @@
if frame information hasn't changed. */
static void
-tui_refresh_frame_and_register_information (int registers_too_p)
+tui_refresh_frame_and_register_information (bool registers_too_p)
{
struct frame_info *fi;
CORE_ADDR pc;
@@ -188,7 +188,7 @@
refresh registers here unless the frame actually changed by one of these
commands. Registers will otherwise be refreshed after a normal stop or by
our tui_register_changed_hook. */
- tui_refresh_frame_and_register_information (/*registers_too_p=*/0);
+ tui_refresh_frame_and_register_information (/*registers_too_p=*/false);
}
/* Observer for the normal_stop notification. */
@@ -198,7 +198,7 @@
{
/* This refresh is intended to catch changes to the selected frame and to
registers following a normal stop. */
- tui_refresh_frame_and_register_information (/*registers_too_p=*/1);
+ tui_refresh_frame_and_register_information (/*registers_too_p=*/true);
}
/* Token associated with observers registered while TUI hooks are
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I9c7f2b764748fe19621851dc4fed4775a6db211a
Gerrit-Change-Number: 648
Gerrit-PatchSet: 2
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-MessageType: newpatchset
^ permalink raw reply [flat|nested] 4+ messages in thread
* [pushed] Use bool in tui_before_prompt
2019-11-14 23:41 [review] Use bool in tui_before_prompt Tom Tromey (Code Review)
2019-12-12 2:41 ` [review v2] " Tom Tromey (Code Review)
2019-12-20 16:21 ` [pushed] " Sourceware to Gerrit sync (Code Review)
@ 2019-12-20 16:21 ` Sourceware to Gerrit sync (Code Review)
2 siblings, 0 replies; 4+ messages in thread
From: Sourceware to Gerrit sync (Code Review) @ 2019-12-20 16:21 UTC (permalink / raw)
To: Tom Tromey, gdb-patches
The original change was created by Tom Tromey.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/648
......................................................................
Use bool in tui_before_prompt
This changes tui_before_prompt to take a bool rather than an int.
gdb/ChangeLog
2019-12-20 Tom Tromey <tom@tromey.com>
* tui/tui-hooks.c (tui_before_prompt): Change parameter to bool.
(tui_before_prompt, tui_normal_stop): Update.
Change-Id: I9c7f2b764748fe19621851dc4fed4775a6db211a
---
M gdb/ChangeLog
M gdb/tui/tui-hooks.c
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 2bdfba7..f910703 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
2019-12-20 Tom Tromey <tom@tromey.com>
+ * tui/tui-hooks.c (tui_before_prompt): Change parameter to bool.
+ (tui_before_prompt, tui_normal_stop): Update.
+
+2019-12-20 Tom Tromey <tom@tromey.com>
+
* tui/tui-winsource.c
(tui_source_window_base::update_source_window_as_is): Don't call
set_current_source_symtab_and_line.
diff --git a/gdb/tui/tui-hooks.c b/gdb/tui/tui-hooks.c
index bb96f4d..35a9259 100644
--- a/gdb/tui/tui-hooks.c
+++ b/gdb/tui/tui-hooks.c
@@ -112,7 +112,7 @@
if frame information hasn't changed. */
static void
-tui_refresh_frame_and_register_information (int registers_too_p)
+tui_refresh_frame_and_register_information (bool registers_too_p)
{
struct frame_info *fi;
CORE_ADDR pc;
@@ -188,7 +188,7 @@
refresh registers here unless the frame actually changed by one of these
commands. Registers will otherwise be refreshed after a normal stop or by
our tui_register_changed_hook. */
- tui_refresh_frame_and_register_information (/*registers_too_p=*/0);
+ tui_refresh_frame_and_register_information (/*registers_too_p=*/false);
}
/* Observer for the normal_stop notification. */
@@ -198,7 +198,7 @@
{
/* This refresh is intended to catch changes to the selected frame and to
registers following a normal stop. */
- tui_refresh_frame_and_register_information (/*registers_too_p=*/1);
+ tui_refresh_frame_and_register_information (/*registers_too_p=*/true);
}
/* Token associated with observers registered while TUI hooks are
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I9c7f2b764748fe19621851dc4fed4775a6db211a
Gerrit-Change-Number: 648
Gerrit-PatchSet: 3
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-MessageType: newpatchset
^ permalink raw reply [flat|nested] 4+ messages in thread
* [pushed] Use bool in tui_before_prompt
2019-11-14 23:41 [review] Use bool in tui_before_prompt Tom Tromey (Code Review)
2019-12-12 2:41 ` [review v2] " Tom Tromey (Code Review)
@ 2019-12-20 16:21 ` Sourceware to Gerrit sync (Code Review)
2019-12-20 16:21 ` Sourceware to Gerrit sync (Code Review)
2 siblings, 0 replies; 4+ messages in thread
From: Sourceware to Gerrit sync (Code Review) @ 2019-12-20 16:21 UTC (permalink / raw)
To: Tom Tromey, gdb-patches
Sourceware to Gerrit sync has submitted this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/648
......................................................................
Use bool in tui_before_prompt
This changes tui_before_prompt to take a bool rather than an int.
gdb/ChangeLog
2019-12-20 Tom Tromey <tom@tromey.com>
* tui/tui-hooks.c (tui_before_prompt): Change parameter to bool.
(tui_before_prompt, tui_normal_stop): Update.
Change-Id: I9c7f2b764748fe19621851dc4fed4775a6db211a
---
M gdb/ChangeLog
M gdb/tui/tui-hooks.c
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 2bdfba7..f910703 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
2019-12-20 Tom Tromey <tom@tromey.com>
+ * tui/tui-hooks.c (tui_before_prompt): Change parameter to bool.
+ (tui_before_prompt, tui_normal_stop): Update.
+
+2019-12-20 Tom Tromey <tom@tromey.com>
+
* tui/tui-winsource.c
(tui_source_window_base::update_source_window_as_is): Don't call
set_current_source_symtab_and_line.
diff --git a/gdb/tui/tui-hooks.c b/gdb/tui/tui-hooks.c
index bb96f4d..35a9259 100644
--- a/gdb/tui/tui-hooks.c
+++ b/gdb/tui/tui-hooks.c
@@ -112,7 +112,7 @@
if frame information hasn't changed. */
static void
-tui_refresh_frame_and_register_information (int registers_too_p)
+tui_refresh_frame_and_register_information (bool registers_too_p)
{
struct frame_info *fi;
CORE_ADDR pc;
@@ -188,7 +188,7 @@
refresh registers here unless the frame actually changed by one of these
commands. Registers will otherwise be refreshed after a normal stop or by
our tui_register_changed_hook. */
- tui_refresh_frame_and_register_information (/*registers_too_p=*/0);
+ tui_refresh_frame_and_register_information (/*registers_too_p=*/false);
}
/* Observer for the normal_stop notification. */
@@ -198,7 +198,7 @@
{
/* This refresh is intended to catch changes to the selected frame and to
registers following a normal stop. */
- tui_refresh_frame_and_register_information (/*registers_too_p=*/1);
+ tui_refresh_frame_and_register_information (/*registers_too_p=*/true);
}
/* Token associated with observers registered while TUI hooks are
--
Gerrit-Project: binutils-gdb
Gerrit-Branch: master
Gerrit-Change-Id: I9c7f2b764748fe19621851dc4fed4775a6db211a
Gerrit-Change-Number: 648
Gerrit-PatchSet: 3
Gerrit-Owner: Tom Tromey <tromey@sourceware.org>
Gerrit-MessageType: merged
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-12-20 16:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-14 23:41 [review] Use bool in tui_before_prompt Tom Tromey (Code Review)
2019-12-12 2:41 ` [review v2] " Tom Tromey (Code Review)
2019-12-20 16:21 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-12-20 16:21 ` Sourceware to Gerrit sync (Code Review)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).