From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 130225 invoked by alias); 4 Jan 2020 18:34:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 130119 invoked by uid 89); 4 Jan 2020 18:34:17 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-21.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=origin, row X-HELO: gateway34.websitewelcome.com Received: from gateway34.websitewelcome.com (HELO gateway34.websitewelcome.com) (192.185.148.109) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 04 Jan 2020 18:34:15 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway34.websitewelcome.com (Postfix) with ESMTP id D177892418 for ; Sat, 4 Jan 2020 12:34:13 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id noFZiygxXiJ43noFZiI6GB; Sat, 04 Jan 2020 12:34:13 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=EMG9IENdC6ZEtQiqwpGmn+lCAzM+3AfTs7GYyyryNZM=; b=xMi7l8zQW6x1Lsz4bu9VgMjX2n QW2aT444cbTAfI+SDip8ZzczK/Xb2hxItjcQUpMLoVXXVM4Uj6lLx2cEoXFlSsKh/jm4/4VpnUnrM i88ozX9CUti70P9+4O6Mp25NB; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:48942 helo=bapiya.Home) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1inoFZ-0026Lh-Lt; Sat, 04 Jan 2020 11:34:13 -0700 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH 03/24] Fix latent display bug in tui_data_window Date: Sat, 04 Jan 2020 18:34:00 -0000 Message-Id: <20200104183410.17114-4-tom@tromey.com> In-Reply-To: <20200104183410.17114-1-tom@tromey.com> References: <20200104183410.17114-1-tom@tromey.com> X-SW-Source: 2020-01/txt/msg00078.txt.bz2 tui_data_window creates new curses windows, but does not pass in coordinates relative to the data window's origin. This means that the data window could only ever be displayed as the topmost window in a layout. This is not a currently problem, because all the existing layouts do this; but a subsequent patch will add user-defined layouts, which could do otherwise. gdb/ChangeLog 2020-01-04 Tom Tromey * tui/tui-regs.c (tui_data_window::display_registers_from): Use correct coordinates. Change-Id: I5101f2b2869557b87381ebdeebd9b7fd28687831 --- gdb/ChangeLog | 5 +++++ gdb/tui/tui-regs.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gdb/tui/tui-regs.c b/gdb/tui/tui-regs.c index 50b3e72e510..41b8f0d933c 100644 --- a/gdb/tui/tui-regs.c +++ b/gdb/tui/tui-regs.c @@ -274,7 +274,7 @@ tui_data_window::display_registers_from (int start_element_no) { /* Create the window if necessary. */ m_regs_content[i].resize (1, item_win_width, - (item_win_width * j) + 1, cur_y); + x + (item_win_width * j) + 1, y + cur_y); i++; /* Next register. */ } cur_y++; /* Next row. */ -- 2.17.2