From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 81321 invoked by alias); 9 Jan 2020 00:58:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 81240 invoked by uid 89); 9 Jan 2020 00:58:28 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-21.3 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway21.websitewelcome.com Received: from gateway21.websitewelcome.com (HELO gateway21.websitewelcome.com) (192.185.45.163) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 09 Jan 2020 00:58:23 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway21.websitewelcome.com (Postfix) with ESMTP id 8730E400C85D1 for ; Wed, 8 Jan 2020 18:58:22 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id pM9Wi5NZ6W4frpM9WiLCxq; Wed, 08 Jan 2020 18:58:22 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=kNV8DERdoTeHNY62fsCg/yaFhrt3jwFsQp5oPcRfU40=; b=adDbFcQkvesFaq1hGOenqXZ72h F+oCoaJG869OH2GfHf01ZVzArvSeeA2TLXA3wSvj1CZUCYAkSQZg1xcGjD/mDTvSi0liOnd5ceXdc /mIhHHxnU5/ve+UjJNewkqWRA; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:33552 helo=bapiya.Home) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1ipM9W-004IGu-6s; Wed, 08 Jan 2020 17:58:22 -0700 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH v2 5/6] Add gdbsupport check-defines script Date: Thu, 09 Jan 2020 00:58:00 -0000 Message-Id: <20200109005807.7314-6-tom@tromey.com> In-Reply-To: <20200109005807.7314-1-tom@tromey.com> References: <20200109005807.7314-1-tom@tromey.com> X-SW-Source: 2020-01/txt/msg00192.txt.bz2 This adds a new script that tries to check that none of the support code uses defines that are not defined by common.m4. This check is necessarily inexact, but this script caught all the issues fixed in the previous patches. 2020-01-08 Tom Tromey * Makefile.in: Rebuild. * Makefile.am (check-defines): New target. * check-defines.el: New file. Change-Id: I59450e91394d5e6a7fa59e9ab53c95843c4bacd9 --- gdbsupport/ChangeLog | 6 +++ gdbsupport/Makefile.am | 4 ++ gdbsupport/Makefile.in | 4 ++ gdbsupport/check-defines.el | 77 +++++++++++++++++++++++++++++++++++++ 4 files changed, 91 insertions(+) create mode 100644 gdbsupport/check-defines.el diff --git a/gdbsupport/Makefile.am b/gdbsupport/Makefile.am index 48e6079fb9f..1a001a00817 100644 --- a/gdbsupport/Makefile.am +++ b/gdbsupport/Makefile.am @@ -68,3 +68,7 @@ libgdbsupport_a_SOURCES = \ thread-pool.c \ xml-utils.c \ $(selftest) + +# Double-check that no defines are missing from our configury. +check-defines: + cd $(srcdir) && emacs --script check-defines.el diff --git a/gdbsupport/Makefile.in b/gdbsupport/Makefile.in index a2e174d8fc4..5723ae5e97e 100644 --- a/gdbsupport/Makefile.in +++ b/gdbsupport/Makefile.in @@ -691,6 +691,10 @@ uninstall-am: override CC := $(CXX) override CFLAGS := $(CXXFLAGS) +# Double-check that no defines are missing from our configury. +check-defines: + cd $(srcdir) && emacs --script check-defines.el + # Tell versions [3.59,3.63) of GNU make to not export all variables. # Otherwise a system limit (for SysV at least) may be exceeded. .NOEXPORT: diff --git a/gdbsupport/check-defines.el b/gdbsupport/check-defines.el new file mode 100644 index 00000000000..b59748f0054 --- /dev/null +++ b/gdbsupport/check-defines.el @@ -0,0 +1,77 @@ +;; Verify that preprocessor symbols are defined in config.in. + +;; Copyright (C) 2020 Free Software Foundation, Inc. +;; +;; This file is part of GDB. +;; +;; This program is free software; you can redistribute it and/or modify +;; it under the terms of the GNU General Public License as published by +;; the Free Software Foundation; either version 3 of the License, or +;; (at your option) any later version. +;; +;; This program is distributed in the hope that it will be useful, +;; but WITHOUT ANY WARRANTY; without even the implied warranty of +;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;; GNU General Public License for more details. +;; +;; You should have received a copy of the GNU General Public License +;; along with this program. If not, see . + +;; To use: +;; cd gdbsupport +;; emacs --script check-defines.el + +(require 'cl-lib) + +(setq-default case-fold-search nil) + +;; The currently recognized macros. +(defconst check-regexp "\\_<\\(\\(HAVE\\|PTRACE_TYPE\\|SIZEOF\\)_[a-zA-Z0-9_]+\\)\\_>") + +(defvar check-seen 0) + +;; Whitelist. These are things that have names like autoconf-created +;; macros, but that are managed directly in the code. +(put (intern "HAVE_USEFUL_SBRK") :check-ok t) +(put (intern "HAVE_SOCKETS") :check-ok t) +(put (intern "HAVE_F_GETFD") :check-ok t) +(put (intern "HAVE_IS_TRIVIALLY_COPYABLE") :check-ok t) +(put (intern "HAVE_IS_TRIVIALLY_CONSTRUCTIBLE") :check-ok t) +(put (intern "HAVE_DOS_BASED_FILE_SYSTEM") :check-ok t) + +(defun check-read-config.in (file) + (save-excursion + (find-file-read-only file) + (goto-char (point-min)) + (while (re-search-forward "^#undef \\(.+\\)$" nil t) + (let ((name (match-string 1))) + (put (intern name) :check-ok t))))) + +(defun check-one-file (file) + (save-excursion + (find-file-read-only file) + (goto-char (point-min)) + (while (re-search-forward check-regexp nil t) + (let ((name (match-string 1))) + (unless (get (intern name) :check-ok) + (save-excursion + (goto-char (match-beginning 0)) + (cl-incf check-seen) + (message "%s:%d:%d: error: name %s not defined" + file + (line-number-at-pos) + (current-column) + name))))))) + +(defun check-directory (dir) + (dolist (file (directory-files dir t "\\.[ch]$")) + (check-one-file file))) + +(check-read-config.in "config.in") +(check-read-config.in "../gnulib/config.in") +(check-directory ".") +(check-directory "../gdb/nat") +(check-directory "../gdb/target") + +(when (> check-seen 0) + (message "%d errors seen" check-seen)) -- 2.17.2