public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
To: gdb-patches@sourceware.org
Subject: [RFAv2 0/3] New option 'set exec-file-mismatch (ask|warn|off)'.  Fixes PR gdb/17626.
Date: Sat, 11 Jan 2020 18:11:00 -0000	[thread overview]
Message-ID: <20200111181041.7163-1-philippe.waroquiers@skynet.be> (raw)

New option 'set exec-file-mismatch (ask|warn|off)'.  Fixes PR gdb/17626.

This option allows to tell GDB to detect and possibly handle mismatched
exec-files.

A recurrent problem with GDB is that GDB uses the wrong exec-file
when using the attach/detach commands successively.
Also, in case the user specifies a file on the command line but attaches
to the wrong PID, this error is not made visible and gives a not user
understandable behaviour.

RFA 1/3 Implement 'set/show exec-file-mismatch'.
   implements the option.
RFA 2/2 modifies gdb.base/attach.exp to test the option.
RFA 3/3 documents the option in NEWS and in gdb.texinfo

This is the second version of the RFA.
This version handles the comments of Eli about the documentation.
As discussed, the option values have been changed to 'ask|warn|off'
(ask was previouly reload).

Some early comments were given by Tom on the RFC.
Some feedback related to these comments:
  * I have styled the warning/error messages mentionning files in exec.c

  * Related to new lines in the warning message: many other warning
    messages have new lines.  I have kept them, as it looks to me that
    the message is more clear like that.  Of course, I can remove them
    if deemed better without.

  * What happens if the inferior execs another program ?
    This option only controls the behaviour when attaching to a running
    program.  The behaviour of 'exec' is not changed: GDB already properly
    determines the executable to use after exec.



             reply	other threads:[~2020-01-11 18:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-11 18:11 Philippe Waroquiers [this message]
2020-01-11 18:11 ` [RFAv2 2/3] Test 'set exec-file-mismatch ask|warn|off' Philippe Waroquiers
2020-01-11 18:11 ` [RFAv2 1/3] Implement 'set/show exec-file-mismatch' Philippe Waroquiers
2020-01-11 18:19 ` [RFAv2 3/3] Document 'set|show exec-file-mismatch (ask|warn|off)' Philippe Waroquiers
2020-01-11 18:44   ` Eli Zaretskii
2020-01-23 14:55 ` PING Re: [RFAv2 0/3] New option 'set exec-file-mismatch (ask|warn|off)'. Fixes PR gdb/17626 Philippe Waroquiers
2020-01-23 21:23   ` Tom Tromey
2020-01-25 16:47     ` Philippe Waroquiers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200111181041.7163-1-philippe.waroquiers@skynet.be \
    --to=philippe.waroquiers@skynet.be \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).