Re: [PATCH] gdb/testsuite: Regenerate the testglue if it is not in path

[Shahab Vahedi <shahab.vahedi@gmail.com>]

On Tue, Feb 11, 2020 at 08:39:03AM -0700, Tom Tromey wrote:
> >>>>> "Shahab" == Shahab Vahedi <shahab.vahedi@gmail.com> writes:
> 
> Shahab> For running the  DejaGnu  tests,  some  esoteric  configurations
> Shahab> may require a testglue.
> 
> Thank you for the patch.  I wasn't aware of this code at all :-)
> 
> Shahab> This patch checks if the wrapper file ("gdb_tg.o") is  still  in
> Shahab> reach and if it is not, it will stimulate the generation of  the
> Shahab> wrapper again.
> 
> I wonder if it would make sense to instead set gdb_wrapper_file to the
> absolute path.

This is how "gdb_wrapper_file" is set in gdb/testsuite/lib/gdb.exp:

  proc gdb_wrapper_init { args } {
  ...
  global gdb_wrapper_file
  ...
      set result [build_wrapper "testglue.o"]
      if { $result != "" } {
          set gdb_wrapper_file [lindex $result 0]
          ...
  }

The "build_wrapper" is a procedure form DejaGnu  itself  (libgloss.exp),
and it does not provide the full path.  Maybe we  can  get  the  current
working directory from somewhere else and append it here?

> It could perhaps be put in the cache directory.  This might help avoid
> recompiling it many times when running the tests in parallel.
> 
> What do you think of that?

I absolutely like this idea and believe this is how it should  be  done,
but am not sure where to begin. Any pointers?

> 
> Shahab> +    # if the wrapper is initialized but the wrapper file cannot be
> 
> GNU style is to start a comment with an upper-case letter, so "If".

I will fix this in next patch (whatever approach we take).

> 
> Shahab> +    # found anymore, the wrapper file must be built again.
> Shahab> +    if { $gdb_wrapper_initialized == 1 && \
> Shahab> +	    [info exists gdb_wrapper_file] && \
> Shahab> +	    ![file exists $gdb_wrapper_file] } {
> Shahab> +	verbose "reinitializing the wrapper"
> Shahab> +	set gdb_wrapper_initialized 0
> Shahab> +    }
> Shahab> +
> Shahab>      if { $gdb_wrapper_initialized == 0 } { gdb_wrapper_init }
> 
> If you don't like the absolute path idea, maybe just having all this
> logic be in the wrapper code would be better, and this could just call
> gdb_wrapper_init unconditionally.

I agree with your suggestion and if we opt for  this  approach,  I  will
adapt it as such.

> 
> Tom

Cheers,
Shahab