From: Simon Marchi <simon.marchi@efficios.com>
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: [PATCH 4/5] gdb: print unknown part of flag enum in hex
Date: Thu, 13 Feb 2020 20:38:00 -0000 [thread overview]
Message-ID: <20200213203035.30157-4-simon.marchi@efficios.com> (raw)
In-Reply-To: <20200213203035.30157-1-simon.marchi@efficios.com>
When we print the "unknown" part of a flag enum, it is printed in
decimal. I think it would be more useful if it was printed in hex, as
it helps to determine which bits are set more than a decimal value.
gdb/ChangeLog:
* valprint.c (generic_val_print_enum_1): Print unknown part of
flag enum in hex.
gdb/testsuite/ChangeLog:
* gdb.base/printcmds.exp (test_print_enums): Expect hex values
for "unknown".
---
gdb/testsuite/gdb.base/printcmds.exp | 4 ++--
gdb/valprint.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/gdb/testsuite/gdb.base/printcmds.exp b/gdb/testsuite/gdb.base/printcmds.exp
index 6afb965af066..d6f5c75650bf 100644
--- a/gdb/testsuite/gdb.base/printcmds.exp
+++ b/gdb/testsuite/gdb.base/printcmds.exp
@@ -743,10 +743,10 @@ proc test_print_enums {} {
gdb_test "print (enum flag_enum) 0x0" [string_to_regexp " = FE_NONE"]
# Print a flag enum with value 0, where no enumerator has value 0.
- gdb_test "print flag_enum_without_zero" [string_to_regexp " = (unknown: 0)"]
+ gdb_test "print flag_enum_without_zero" [string_to_regexp " = (unknown: 0x0)"]
# Print a flag enum with unknown bits set.
- gdb_test "print (enum flag_enum) 0xf1" [string_to_regexp " = (FE_ONE | unknown: 240)"]
+ gdb_test "print (enum flag_enum) 0xf1" [string_to_regexp " = (FE_ONE | unknown: 0xf0)"]
# Test printing an enum not considered a "flag enum" (because one of its
# enumerators has multiple bits set).
diff --git a/gdb/valprint.c b/gdb/valprint.c
index 77b9a4993d79..bd21be69e1bf 100644
--- a/gdb/valprint.c
+++ b/gdb/valprint.c
@@ -659,8 +659,8 @@ generic_val_print_enum_1 (struct type *type, LONGEST val,
{
if (!first)
fputs_filtered (" | ", stream);
- fputs_filtered ("unknown: ", stream);
- print_longest (stream, 'd', 0, val);
+ fputs_filtered ("unknown: 0x", stream);
+ print_longest (stream, 'x', 0, val);
}
fputs_filtered (")", stream);
--
2.25.0
next prev parent reply other threads:[~2020-02-13 20:38 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 20:30 [PATCH 1/5] gnulib: import count-one-bits module and use it Simon Marchi
2020-02-13 20:30 ` [PATCH 2/5] gdb: fix printing of flag enums with multi-bit enumerators Simon Marchi
2020-02-17 10:56 ` Luis Machado
2020-02-17 17:27 ` Simon Marchi
2020-02-17 17:40 ` Luis Machado
2020-02-17 19:20 ` Simon Marchi
2020-02-18 20:42 ` Tom Tromey
2020-02-13 20:30 ` [PATCH 5/5] gdb: change print format of flag enums with value 0 Simon Marchi
2020-02-17 12:08 ` Luis Machado
2020-02-17 19:02 ` Simon Marchi
2020-02-18 20:45 ` Tom Tromey
2020-02-18 20:52 ` Simon Marchi
2020-02-13 20:30 ` [PATCH 3/5] gdb: allow duplicate enumerators in flag enums Simon Marchi
2020-02-17 11:01 ` Luis Machado
2020-02-18 20:38 ` Tom Tromey
2020-02-18 20:42 ` Tom Tromey
2020-02-18 20:48 ` Simon Marchi
2020-02-18 21:57 ` Tom Tromey
2020-02-18 22:25 ` Simon Marchi
2020-02-13 20:38 ` Simon Marchi [this message]
2020-02-17 11:04 ` [PATCH 4/5] gdb: print unknown part of flag enum in hex Luis Machado
2020-02-17 18:59 ` Simon Marchi
2020-02-18 20:43 ` Tom Tromey
2020-02-14 19:53 ` [PATCH 1/5] gnulib: import count-one-bits module and use it Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200213203035.30157-4-simon.marchi@efficios.com \
--to=simon.marchi@efficios.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).