From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25039 invoked by alias); 2 Mar 2020 12:02:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24983 invoked by uid 89); 2 Mar 2020 12:02:13 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-23.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Spam-Relays-External:209.85.221.68, HX-Languages-Length:2050, H*RU:209.85.221.68, tel X-HELO: mail-wr1-f68.google.com Received: from mail-wr1-f68.google.com (HELO mail-wr1-f68.google.com) (209.85.221.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 02 Mar 2020 12:02:11 +0000 Received: by mail-wr1-f68.google.com with SMTP id y17so12257438wrn.6 for ; Mon, 02 Mar 2020 04:02:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=GrcBbW0MhJExggsvIvVrdyWKzDnepXUzQWphwDqtLsw=; b=aF123WskAhkBPcIM4KXtTYwBTEM4mN5BqkdfX7N9FFzyZnXkKn6X671QpMK9GFozRJ 8DIBB8mgNxNA7PEjyHz0hXazabYOcCeNxEew9oQLnMF6zD2TQqJE87bel0YOfYXQAfsT u6Bk9kF0TAMzDboezS++eKiEfedpYDdLTeWC+aQe1Bg99MPh++1hM768ZXFthw0PReSQ I9kRhkg7dcO+fZOQQZ4PjlgYMw6ppJeWbI8fiCrTCvyNEiZOF3N0tBcrqqnvBa4kbcp7 JFb4SwTFKQOD5y/epRRz+iKAfEJlSsmlfFHuVx4btpJUEv+AQwCAbGjAC6lv39PY1kr7 46CQ== Return-Path: Received: from localhost ([212.69.42.53]) by smtp.gmail.com with ESMTPSA id l4sm29305968wrv.22.2020.03.02.04.02.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 02 Mar 2020 04:02:09 -0800 (PST) Date: Mon, 02 Mar 2020 12:02:00 -0000 From: Andrew Burgess To: "Aktemur, Tankut Baris" Cc: "gdb-patches@sourceware.org" Subject: Re: [PATCH] gdbserver: Add .dir-locals.el file Message-ID: <20200302120208.GP3317@embecosm.com> References: <20200302095303.4474-1-andrew.burgess@embecosm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Fortune: Error in operator: add beer X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.9.2 (2017-12-15) X-IsSubscribed: yes X-SW-Source: 2020-03/txt/msg00018.txt * Aktemur, Tankut Baris [2020-03-02 10:19:28 +0000]: > On Monday, March 2, 2020 10:53 AM, Andrew Burgess wrote: > > Add a .dir-locals.el file into the gdbserver directory so that we get > > the GNU style when editing these files in Emacs. > > > > I copied this file over from the gdb/ directory and the only change I > > made was to remove (mode . c++) from the c-mode settings. The reason > > for this is that all C++ files in the gdbserver/ directory now have > > the .cc suffix, and we don't (currently) have any .c files in there. I > > assume that if did add a .c file in the future, it really would be C, > > not C++, so forcing c++-mode seems like the wrong thing to do. > > > > The copyright date in the new file is left as for gdb/.dir-locals.el, > > as the new file is an exact copy with one line removed. > > > > gdbserver/ChangeLog: > > > > * .dir-locals.el: New file. > > --- > > gdbserver/.dir-locals.el | 36 ++++++++++++++++++++++++++++++++++++ > > gdbserver/ChangeLog | 4 ++++ > > 2 files changed, 40 insertions(+) > > create mode 100644 gdbserver/.dir-locals.el > > > > diff --git a/gdbserver/.dir-locals.el b/gdbserver/.dir-locals.el > > new file mode 100644 > > index 00000000000..28a6df0de07 > > --- /dev/null > > +++ b/gdbserver/.dir-locals.el > > @@ -0,0 +1,36 @@ > > +;; Emacs settings. > > +;; Copyright (C) 2012-2020 Free Software Foundation, Inc. > > ... and I think they year needs to be just '2020'. As per this rule: https://sourceware.org/gdb/wiki/ContributionChecklist#Copyright_Header When copying a file the start date of the original file should be maintained I think. Thanks, Andrew > > Thanks. > -Baris > > > Intel Deutschland GmbH > Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany > Tel: +49 89 99 8853-0, www.intel.de > Managing Directors: Christin Eisenschmid, Gary Kershaw > Chairperson of the Supervisory Board: Nicole Lau > Registered Office: Munich > Commercial Register: Amtsgericht Muenchen HRB 186928