From: Simon Marchi <simon.marchi@efficios.com>
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: [PATCH] gdb: enable -Wmissing-prototypes warning
Date: Tue, 03 Mar 2020 22:34:00 -0000 [thread overview]
Message-ID: <20200303223442.330-1-simon.marchi@efficios.com> (raw)
While compiling with clang, I noticed it didn't catch cases where my
function declaration didn't match my function definition. This is
normally caught by gcc with -Wmissing-declarations.
On clang, this is caught by -Wmissing-prototypes instead.
Note that on gcc, -Wmissing-prototypes also exists, but is only valid
for C and Objective-C. It gets correctly rejected by the configure
script since gcc rejects it with:
cc1plus: error: command line option '-Wmissing-prototypes' is valid for C/ObjC but not for C++ -Werror
So this warning flag ends up not used for gcc (which is what we want).
gdb/ChangeLog:
* configure: Re-generate.
gdbserver/ChangeLog:
* configure: Re-generate.
gdbsupport/ChangeLog:
* configure: Re-generate.
* warning.m4: Enable -Wmissing-prototypes.
---
gdb/configure | 1 +
gdbserver/configure | 1 +
gdbsupport/configure | 1 +
gdbsupport/warning.m4 | 1 +
4 files changed, 4 insertions(+)
diff --git a/gdb/configure b/gdb/configure
index f99cbe40f11f..47ca77f400c8 100755
--- a/gdb/configure
+++ b/gdb/configure
@@ -16323,6 +16323,7 @@ build_warnings="-Wall -Wpointer-arith \
-Wdeprecated-copy-dtor \
-Wredundant-move \
-Wmissing-declarations \
+-Wmissing-prototypes \
-Wstrict-null-sentinel \
"
diff --git a/gdbserver/configure b/gdbserver/configure
index be5719eb77aa..13ac7188454d 100755
--- a/gdbserver/configure
+++ b/gdbserver/configure
@@ -9616,6 +9616,7 @@ build_warnings="-Wall -Wpointer-arith \
-Wdeprecated-copy-dtor \
-Wredundant-move \
-Wmissing-declarations \
+-Wmissing-prototypes \
-Wstrict-null-sentinel \
"
diff --git a/gdbsupport/configure b/gdbsupport/configure
index a4871f8d5bce..11ebee513c40 100755
--- a/gdbsupport/configure
+++ b/gdbsupport/configure
@@ -10871,6 +10871,7 @@ build_warnings="-Wall -Wpointer-arith \
-Wdeprecated-copy-dtor \
-Wredundant-move \
-Wmissing-declarations \
+-Wmissing-prototypes \
-Wstrict-null-sentinel \
"
diff --git a/gdbsupport/warning.m4 b/gdbsupport/warning.m4
index 81939ed76102..649be7552dd1 100644
--- a/gdbsupport/warning.m4
+++ b/gdbsupport/warning.m4
@@ -51,6 +51,7 @@ build_warnings="-Wall -Wpointer-arith \
-Wdeprecated-copy-dtor \
-Wredundant-move \
-Wmissing-declarations \
+-Wmissing-prototypes \
-Wstrict-null-sentinel \
"
--
2.25.1
next reply other threads:[~2020-03-03 22:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 22:34 Simon Marchi [this message]
2020-03-11 19:16 ` Simon Marchi
2021-11-04 12:00 ` gdb: disable -Wmissing-prototypes warning w/gcc Mike Frysinger
2021-11-04 12:17 ` Andrew Burgess
2021-11-04 12:59 ` Simon Marchi
2021-11-04 18:43 ` Simon Marchi
2021-11-04 20:18 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200303223442.330-1-simon.marchi@efficios.com \
--to=simon.marchi@efficios.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).