From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 64359 invoked by alias); 4 Mar 2020 10:53:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 64333 invoked by uid 89); 4 Mar 2020 10:53:35 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:961 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 04 Mar 2020 10:53:34 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 93D0D56029; Wed, 4 Mar 2020 05:53:32 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id TWatU+cRPT15; Wed, 4 Mar 2020 05:53:32 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 57C8756027; Wed, 4 Mar 2020 05:53:32 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 1600B83859; Wed, 4 Mar 2020 11:53:30 +0100 (CET) Date: Wed, 04 Mar 2020 10:53:00 -0000 From: Joel Brobecker To: Sergio Durigan Junior Cc: Andrew Burgess , GDB Patches , Philippe Waroquiers , Pedro Alves Subject: Re: [PATCH] Fix printf of a convenience variable holding an inferior address Message-ID: <20200304105330.GA4745@adacore.com> References: <20190610211622.15237-1-philippe.waroquiers@skynet.be> <20200302024616.1049417-1-sergiodj@redhat.com> <20200303133918.GV3317@embecosm.com> <877e01h06g.fsf@redhat.com> <87wo81criy.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87wo81criy.fsf@redhat.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2020-03/txt/msg00082.txt Hi Sergio, > >>> gdb/ChangeLog: > >>> 2020-03-02 Sergio Durigan Junior > >>> > >>> * printcmd.c (print_c_string): Check also for TYPE_CODE_PTR > >>> when verifying if dealing with a convenience variable. > >>> > >>> gdb/testsuite/ChangeLog: > >>> 2020-03-02 Sergio Durigan Junior > >>> > >>> * gdb.base/printcmds.exp: Add test to verify printf of a > >>> variable holding an address. > >> > >> LGTM. > > > > Thanks, pushed: > > > > 7b973adce2b486518d3150db257b179e1b9a5d33 > > BTW, this also affects 9.1 (in fact, that's where I found the bug). I > can create a tracking bug and backport it to the branch if the issue and > fix are deemed important enough. Do you know if this issue is a regression, compared to previous released versions? In terms of putting it in 9.2, I think we could do it; the patch does look safe to me. -- Joel