From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58449 invoked by alias); 4 Mar 2020 14:08:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 58440 invoked by uid 89); 4 Mar 2020 14:08:08 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-23.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mail-wm1-f53.google.com Received: from mail-wm1-f53.google.com (HELO mail-wm1-f53.google.com) (209.85.128.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 04 Mar 2020 14:08:06 +0000 Received: by mail-wm1-f53.google.com with SMTP id g134so2241844wme.3 for ; Wed, 04 Mar 2020 06:08:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ZrW38022slhv0t/Wdxn2jM7t4F1d7HhHZ7Sytk5Y3BM=; b=gKELUiGmGHB03ABZMD1rNR+V5Vq4xo5/UfoydsMAJWRYphudMe+TJj8IFHXDHjplKT ppT04zMeJ/sOT5671qreBiezmVo9Bp/HoSe72GrEDberhMst7j8b5HYDXhLFXKHMiyVL dlv1qgjCfkck4PTDSwv/1KAeEvXVJIcz2kMS74SHEtUQfpaCp6ZRxK55Oer/m21SjDwH j01ZAqEB/YEkniV7BFWykNEMSZsB7HmA3RsAhD7i9pY3XQQSR1ZL4RsEL3trrSsGBr0q 92vStJVpTNvTLXyFyXSizXZK7NZHgnv75wGF2BJhrXATDvzqgpStIk0qKTvkKY6Re35S cryQ== Return-Path: Received: from localhost (host86-186-80-160.range86-186.btcentralplus.com. [86.186.80.160]) by smtp.gmail.com with ESMTPSA id m3sm19806608wrx.9.2020.03.04.06.08.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 04 Mar 2020 06:08:03 -0800 (PST) Date: Wed, 04 Mar 2020 14:08:00 -0000 From: Andrew Burgess To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH][gdb] Remove trailing "done" after "Reading symbols from" message Message-ID: <20200304140757.GZ3317@embecosm.com> References: <20200304132133.GA26507@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200304132133.GA26507@delia> X-Fortune: TONY RANDALL! Is YOUR life a PATIO of FUN?? X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.9.2 (2017-12-15) X-IsSubscribed: yes X-SW-Source: 2020-03/txt/msg00085.txt * Tom de Vries [2020-03-04 14:21:34 +0100]: > Hi, > > Using verbose, we get some detail on symbol loading: > ... > $ gdb a.out -iex "set verbose on" > Reading symbols from a.out... > Reading in symbols for /home/vries/hello.c...done. > (gdb) > ... > > And using debug symtab-create, much more detail: > ... > $ gdb a.out -iex "set verbose on" -iex "set debug symtab-create 1" > Reading symbols from a.out... > Reading minimal symbols of objfile /data/gdb_versions/devel/lto/a.out ... > Installing 30 minimal symbols of objfile /data/gdb_versions/devel/lto/a.out. > Done reading minimal symbols. > Creating one or more psymtabs for objfile /data/gdb_versions/devel/lto/a.out ... > Created psymtab 0x35a3de0 for module ../sysdeps/x86_64/start.S. > Created psymtab 0x353e4e0 for module init.c. > Created psymtab 0x353e560 for module ../sysdeps/x86_64/crti.S. > Created psymtab 0x353e5e0 for module /home/vries/hello.c. > Created psymtab 0x35bd530 for module elf-init.c. > Created psymtab 0x35bd5b0 for module ../sysdeps/x86_64/crtn.S. > Reading in symbols for /home/vries/hello.c...Created compunit symtab 0x354bd20 for hello.c. > done. > (gdb) I'm struggling to understand what problem you're trying to solve here. In general, if we switch on any of the 'set debug ...' flags the output from GDB gets confused. These flags aren't intended for general use, and trying to "fix" GDB's output in the face of these flags is going to be a huge task, for I'm not sure what benefit. Other than the output looking a little neater, is there an actual problem solved here? Thanks, Andrew > ... > > The "Created compunit symtab" message gets inbetween the "Reading in symbols" > and the trailing "done.". [ Strictly speaking this is a regression since > commit faa17681cc "Make gdb_flush also flush the wrap buffer", but the > same problem happens when using -batch before this commit. ] > > Fix this by removing the trailing "done." altogether, such that we get: > ... > Created psymtab 0x3590520 for module ../sysdeps/x86_64/crtn.S. > Reading in symbols for /home/vries/hello.c... > Created compunit symtab 0x359dd20 for hello.c. > (gdb) > ... > > [ Alternatively, we could fix this emitting a "Done reading in symbols" line > or some such, like is done for minimal symbols. See above. ] > > [ Note: Removing the trailing "done." for the "Reading symbols from" message > was done in commit 3453e7e409 'Clean up "Reading symbols" output'. ] > > Build and reg-tested on x86_64-linux. > > OK for trunk? > > Thanks, > - Tom > > [gdb] Remove trailing "done" after "Reading symbols from" message > > gdb/ChangeLog: > > 2020-03-04 Tom de Vries > > * psymtab.c (psymtab_to_symtab): Don't print "done.". > > --- > gdb/psymtab.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/gdb/psymtab.c b/gdb/psymtab.c > index fd7fc8feff..7d33dea0d4 100644 > --- a/gdb/psymtab.c > +++ b/gdb/psymtab.c > @@ -760,16 +760,12 @@ psymtab_to_symtab (struct objfile *objfile, struct partial_symtab *pst) > > if (info_verbose) > { > - printf_filtered (_("Reading in symbols for %s..."), > + printf_filtered (_("Reading in symbols for %s...\n"), > pst->filename); > gdb_flush (gdb_stdout); > } > > pst->read_symtab (objfile); > - > - /* Finish up the debug error message. */ > - if (info_verbose) > - printf_filtered (_("done.\n")); > } > > return pst->get_compunit_symtab ();