From: Kamil Rytarowski <n54@gmx.com>
To: gdb-patches@sourceware.org
Subject: [PATCH] Implement nbsd_nat_target::thread_name
Date: Wed, 25 Mar 2020 19:35:41 +0100 [thread overview]
Message-ID: <20200325183541.6662-1-n54@gmx.com> (raw)
Return the name assigned to a thread by an application. Return
the string in a static buffer.
gdb/ChangeLog:
* nbsd-nat.h (nbsd_nat_target::thread_name): Add.
(struct thread_info): Add forward declaration.
* nbsd-nat.c: Include "gdbthread.h".
(nbsd_nat_target::thread_name): Add.
---
gdb/ChangeLog | 7 +++++++
gdb/nbsd-nat.c | 39 +++++++++++++++++++++++++++++++++++++++
gdb/nbsd-nat.h | 4 ++++
3 files changed, 50 insertions(+)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 5400a4e3484..4f6de3767d7 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -53,6 +53,13 @@
* nat/gdb_ptrace.h: Don't declare ptrace if HAVE_DECL_PTRACE is
not defined.
+2020-03-20 Kamil Rytarowski <n54@gmx.com>
+
+ * nbsd-nat.h (nbsd_nat_target::thread_name): Add.
+ (struct thread_info): Add forward declaration.
+ * nbsd-nat.c: Include "gdbthread.h".
+ (nbsd_nat_target::thread_name): Add.
+
2020-03-20 Kamil Rytarowski <n54@gmx.com>
* amd64-bsd-nat.c (gdb_ptrace): Change return type from `int' to
diff --git a/gdb/nbsd-nat.c b/gdb/nbsd-nat.c
index 326bbe3aec3..59c311e840c 100644
--- a/gdb/nbsd-nat.c
+++ b/gdb/nbsd-nat.c
@@ -20,6 +20,7 @@
#include "defs.h"
#include "nbsd-nat.h"
+#include "gdbthread.h"
#include <sys/types.h>
#include <sys/ptrace.h>
@@ -39,3 +40,41 @@ nbsd_nat_target::pid_to_exec_file (int pid)
return NULL;
return buf;
}
+
+/* Return the name assigned to a thread by an application. Returns
+ the string in a static buffer. */
+
+const char *
+nbsd_nat_target::thread_name (struct thread_info *thr)
+{
+ ptid_t ptid = thr->ptid;
+ pid_t pid = ptid.pid ();
+ int lwp = ptid.lwp ();
+ int mib[5] = {CTL_KERN, KERN_LWP, pid, sizeof (struct kinfo_lwp), 0};
+ size_t size;
+
+ if (sysctl (mib, 5, NULL, &size, NULL, 0) == -1 || size == 0)
+ perror_with_name (("sysctl"));
+
+ mib[4] = size / sizeof (size_t);
+
+ gdb::unique_xmalloc_ptr<struct kinfo_lwp> kl
+ ((struct kinfo_lwp *) xcalloc (size, 1));
+ if (kl == NULL)
+ perror_with_name (("calloc"));
+
+ if (sysctl (mib, 5, kl.get (), &size, NULL, 0) == -1 || size == 0)
+ perror_with_name (("sysctl"));
+
+ static char buf[KI_LNAMELEN] = {};
+ for (size_t i = 0; i < size / sizeof (struct kinfo_lwp); i++)
+ {
+ if (kl.get ()[i].l_lid == lwp)
+ {
+ xsnprintf (buf, sizeof buf, "%s", kl.get ()[i].l_name);
+ break;
+ }
+ }
+
+ return buf;
+}
diff --git a/gdb/nbsd-nat.h b/gdb/nbsd-nat.h
index a752fbe572d..3909bdf67a2 100644
--- a/gdb/nbsd-nat.h
+++ b/gdb/nbsd-nat.h
@@ -22,11 +22,15 @@
#include "inf-ptrace.h"
+struct thread_info;
+
/* A prototype NetBSD target. */
struct nbsd_nat_target : public inf_ptrace_target
{
char *pid_to_exec_file (int pid) override;
+
+ const char *thread_name (struct thread_info *thr) override;
};
#endif /* nbsd-nat.h */
--
2.25.0
next reply other threads:[~2020-03-25 18:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 18:35 Kamil Rytarowski [this message]
2020-04-01 19:28 ` Tom Tromey
2020-04-01 20:17 ` Kamil Rytarowski
2020-04-01 20:45 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200325183541.6662-1-n54@gmx.com \
--to=n54@gmx.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).