From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by sourceware.org (Postfix) with ESMTPS id 825AE385E006 for ; Fri, 27 Mar 2020 13:57:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 825AE385E006 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-wm1-x344.google.com with SMTP id c187so11536525wme.1 for ; Fri, 27 Mar 2020 06:57:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=NuDgXeyrwPqMFLbnhRAeLf9pOnvMjxg3lMREmP2gRcg=; b=U03VUbHOkpA5rQV9qQUFFykMEhfSOeQCq+prTBKCZmUEvxn4HPeMDnJt2THp3yWbnk nA8GKh8RElgm1mjwoibIRhjC0PvJpcCzE4Q8/Cp7l0fbBNP5VpbSx+WnTt1vexlEL2y7 nJrMXk9yC2hSTp4KP/HsJFudCTxzyCWWMgyhIB9hM/djDqAgce1kty638l2zrTbTYpjN BqSzQK4bVHRb12Bt5ZUxFvw7LQ3gqK+iFSOleYSfqQNZSoxCvo4HLuWaQekU5TZI/Hk7 KyOdr4xvShIIhhhT1YawaZkyCFga+WavEbi6zrWkv71UZ+UdgSgPnX/YCJ394igPnjCr c3Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=NuDgXeyrwPqMFLbnhRAeLf9pOnvMjxg3lMREmP2gRcg=; b=dDIVDLchJw22ozBO2+rZqZNN3nDnV57lezTZf8p8HypFwAGxkh8KSj4ctZuvNsC/gC VJhNDhS5DKL8t4arqHlg/pijzr0g9H/gd/zfrPZ3r1NT7ZiJXEkForbJ5EsmCai/S0nw T91dWxO1pDC647t24ROnTvOLXSI4B6PUCRqRhS3KTMzeoeRWV/ATLGuw5PLFFn6UqhH4 ttAdIEoC1lO8Koi8iEPsGmLL9GLqyvz+VEVv9DoCq9fzre5i5aVBRELnzMTxiIHkiQEv rdfXGyAaGnlRZXpgcXKcCUGgCqB26ULH5p0+Gpm64bZnyW+uY8t2H6OkjErGKgmp4WhO kVHQ== X-Gm-Message-State: ANhLgQ1utndAnSyTjvnRxc2TgXvm7bJeOFFs7vUt6SrDxGXyGRMuMIrq 6IzA91ChWV7iZ+AjvEyRqL+B7g== X-Google-Smtp-Source: ADFU+vtmCqoYdlnZraX0Z22cGqDGVhgt9GyzMMH3Hcqj87iaEbGgZ2WcCgyN9hbQs+7yN/eN4F7N3Q== X-Received: by 2002:a7b:cd89:: with SMTP id y9mr5694682wmj.142.1585317446672; Fri, 27 Mar 2020 06:57:26 -0700 (PDT) Received: from localhost (host86-186-80-207.range86-186.btcentralplus.com. [86.186.80.207]) by smtp.gmail.com with ESMTPSA id c85sm8187029wmd.48.2020.03.27.06.57.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 27 Mar 2020 06:57:25 -0700 (PDT) Date: Fri, 27 Mar 2020 13:57:25 +0000 From: Andrew Burgess To: Simon Marchi Cc: gdb-patches@sourceware.org, Joel Brobecker Subject: Re: [PATCH 1/2] gdbsupport: Resolve shellcheck issues in create-version.sh script Message-ID: <20200327135724.GB587@embecosm.com> References: <0784fb919936e8e5afa466c7597c37c574a44bb9.1585311874.git.andrew.burgess@embecosm.com> <62636013-06cb-ec3e-132d-780c307f1fb5@simark.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <62636013-06cb-ec3e-132d-780c307f1fb5@simark.ca> X-Operating-System: Linux/4.18.19-100.fc27.x86_64 (x86_64) X-Uptime: 13:56:56 up 42 days, 1:25, X-Fortune: Can I have an IMPULSE ITEM instead? X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.9.2 (2017-12-15) X-Spam-Status: No, score=-26.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Mar 2020 13:57:29 -0000 * Simon Marchi [2020-03-27 09:11:33 -0400]: > On 2020-03-27 8:27 a.m., Andrew Burgess wrote: > > Run shellcheck (version 0.4.7) on the create-version.sh script, and > > resolve the issues it highlighter - they all seemed reasonable. > > > > gdbsupport/ChangeLog: > > > > * create-version.sh: Resolve issues highlighted by shellcheck. > > --- > > gdbsupport/ChangeLog | 4 ++++ > > gdbsupport/create-version.sh | 18 ++++++++++-------- > > 2 files changed, 14 insertions(+), 8 deletions(-) > > > > diff --git a/gdbsupport/create-version.sh b/gdbsupport/create-version.sh > > index 81d6dbf8c1f..6135d219d94 100755 > > --- a/gdbsupport/create-version.sh > > +++ b/gdbsupport/create-version.sh > > @@ -27,12 +27,14 @@ host_alias="$2" > > target_alias="$3" > > output="$4" > > > > -rm -f version.c-tmp $output version.tmp > > -date=`sed -n -e 's/^.* BFD_VERSION_DATE \(.*\)$/\1/p' $srcdir/../bfd/version.h` > > -sed -e "s/DATE/$date/" < $srcdir/version.in > version.tmp > > -echo '#include "gdbsupport/version.h"' >> version.c-tmp > > -echo 'const char version[] = "'"`sed q version.tmp`"'";' >> version.c-tmp > > -echo 'const char host_name[] = "'"$host_alias"'";' >> version.c-tmp > > -echo 'const char target_name[] = "'"$target_alias"'";' >> version.c-tmp > > -mv version.c-tmp $output > > +rm -f version.c-tmp "$output" version.tmp > > +date=$(sed -n -e 's/^.* BFD_VERSION_DATE \(.*\)$/\1/p' "$srcdir/../bfd/version.h") > > +sed -e "s/DATE/$date/" < "$srcdir/version.in" > version.tmp > > +{ > > + echo '#include "gdbsupport/version.h"' > > + echo 'const char version[] = "'"$(sed q version.tmp)"'";' > > + echo 'const char host_name[] = "'"$host_alias"'";' > > + echo 'const char target_name[] = "'"$target_alias"'";' > > +} >> version.c-tmp > > +mv version.c-tmp "$output" > > rm -f version.tmp > > -- > > 2.14.5 > > > > Thanks, I think it's probably worth pushing this patch right away, it's an improvement > in its own right. Thanks. I went ahead and pushed this. Andrew