From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by sourceware.org (Postfix) with ESMTPS id 1A55D385BF83 for ; Tue, 14 Apr 2020 11:18:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1A55D385BF83 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-wr1-x444.google.com with SMTP id h9so13845351wrc.8 for ; Tue, 14 Apr 2020 04:18:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Fc0mktBjezwwEG+JVEszMBC/rUwewVJaNe6e7uGwaCQ=; b=EcVScxoIwju1Esm7C0OwJ4nlZD3++AaOWF2pDj9BXDLwBH1/RTnyhq2ASPMXxfQgb1 s8c/H8gAXbVjyym6R5hLrLayfgxnjnLPLqPFc5RNc0hLizS+BTLmbq++0Ur6RlDJ3H3j rEKnrwIZsleD2rqXeD/i3RjxWz0peKyXxZ0FW6PE1NCVF7yfnt+pzgMV5dSaENxtU5lA JYWhlXMcD1nfqhAf9Op8dHcqDKSowECJf8sv3D3y+UM6VZK7eBDsFpKCj3svq/2065OK oVJqsYxikUEDmISCRplcynm5UTYorNeQp6RGSlx88MDmPP3AbQCTUqQBaB+1BG6pDjLv uywA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Fc0mktBjezwwEG+JVEszMBC/rUwewVJaNe6e7uGwaCQ=; b=rmJm2hTx1tyL6ysRgqKrxAXNMWlXXmoJ/VQOw4u1TxKG6JaDNIa8R3HUjJ/kaXtwK6 bHQWdaU3o1LgaPdoBsgNOLUwoV0mYWIKsGr8x/9g74hKHnNF4g02BUHoXPwxM6uTMBsg F77J/NbKWS5tf3fa7iBfIGIP6lGgswA2pluBBYMdc0XFSPpq8r4HfN1RDsevoXj9dOSP RTGu6IVshzuPBNXN6b2B8GiZ0qXeAlRgZR15qAXXj+62xGWRVEoMKTb32WJBhv3XQK3/ Z8hG9nyenwoKUR3O/PupD5rrP23jpzHzRITxtA5cW5J+Uw3MLYrt8iAg9M/ANG4HJ3OQ kiXQ== X-Gm-Message-State: AGi0PuZRipsdgSyGkoyUkGVsAGoFMe71sAq+D8tVJL369wLxpM7Zz9Ry UeiC5zTnEffrInWQjNJFlaquwA== X-Google-Smtp-Source: APiQypLGrL2uGg1JK6+SeklCtROWkGkxydVkEd7/3TpUyPs50t7pj046rFic7Xp2kSMYEjnP9ZuHPg== X-Received: by 2002:adf:f881:: with SMTP id u1mr17909467wrp.348.1586863096080; Tue, 14 Apr 2020 04:18:16 -0700 (PDT) Received: from localhost (host81-151-181-184.range81-151.btcentralplus.com. [81.151.181.184]) by smtp.gmail.com with ESMTPSA id m1sm13469761wro.64.2020.04.14.04.18.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2020 04:18:15 -0700 (PDT) Date: Tue, 14 Apr 2020 12:18:14 +0100 From: Andrew Burgess To: Tom Tromey Cc: gdb-patches@sourceware.org, Bernd Edlinger Subject: Re: [PATCH 1/2] gdb/testsuite: Move helper function into lib/dwarf.exp Message-ID: <20200414111814.GB2366@embecosm.com> References: <87blo4bc6j.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87blo4bc6j.fsf@tromey.com> X-Operating-System: Linux/5.5.13-200.fc31.x86_64 (x86_64) X-Uptime: 12:17:20 up 6 days, 2:32, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-Spam-Status: No, score=-13.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Apr 2020 11:18:18 -0000 * Tom Tromey [2020-04-06 14:18:28 -0600]: > >>>>> "Andrew" == Andrew Burgess writes: > > Andrew> gdb/testsuite/ChangeLog: > > Andrew> * gdb.dwarf2/dw2-inline-many-frames.exp (get_func_info): Delete. > Andrew> * gdb.dwarf2/dw2-inline-small-func.exp: Pass options to > Andrew> get_func_info. > Andrew> (get_func_info): Delete. > Andrew> * gdb.dwarf2/dw2-is-stmt-2.exp (get_func_info): Delete. > Andrew> * gdb.dwarf2/dw2-is-stmt.exp (get_func_info): Delete. > Andrew> * lib/dwarf.exp (get_func_info): New function. > > Thanks for doing this. I didn't realize this function was copied so > many times, or I would have merged them myself. Looks good. Thanks for reviewing this. I've gone ahead and pushed this patch as it is a nice clean up independent of the second patch, which is still under discussion. Thanks, Andrew