From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by sourceware.org (Postfix) with ESMTP id D559C3887025 for ; Tue, 14 Apr 2020 17:54:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D559C3887025 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-273-6rDZuSEsMsSWLu6XXfUU-A-1; Tue, 14 Apr 2020 13:54:43 -0400 X-MC-Unique: 6rDZuSEsMsSWLu6XXfUU-A-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AD9DF1083E80 for ; Tue, 14 Apr 2020 17:54:42 +0000 (UTC) Received: from cascais.Home (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4C4789F99D for ; Tue, 14 Apr 2020 17:54:42 +0000 (UTC) From: Pedro Alves To: gdb-patches@sourceware.org Subject: [PATCH 09/28] Don't write to inferior_ptid in tracefile-tfile.c Date: Tue, 14 Apr 2020 18:54:15 +0100 Message-Id: <20200414175434.8047-10-palves@redhat.com> In-Reply-To: <20200414175434.8047-1-palves@redhat.com> References: <20200414175434.8047-1-palves@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-29.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Apr 2020 17:54:47 -0000 gdb/ChangeLog: yyyy-mm-dd Pedro Alves =09* tracefile-tfile.c (tfile_target_open): Don't write to =09inferior_ptid directly, instead switch to added thread. =09(tfile_target::close): Use switch_to_no_thread instead of writing =09to inferior_ptid directly. --- gdb/tracefile-tfile.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/gdb/tracefile-tfile.c b/gdb/tracefile-tfile.c index ea19177475..fd7bab822a 100644 --- a/gdb/tracefile-tfile.c +++ b/gdb/tracefile-tfile.c @@ -556,8 +556,9 @@ tfile_target_open (const char *arg, int from_tty) } =20 inferior_appeared (current_inferior (), TFILE_PID); - inferior_ptid =3D ptid_t (TFILE_PID); - add_thread_silent (&tfile_ops, inferior_ptid); + + thread_info *thr =3D add_thread_silent (&tfile_ops, ptid_t (TFILE_PID)); + switch_to_thread (thr); =20 if (ts->traceframe_count <=3D 0) warning (_("No traceframes present in this file.")); @@ -618,7 +619,7 @@ tfile_target::close () { gdb_assert (trace_fd !=3D -1); =20 - inferior_ptid =3D null_ptid;=09/* Avoid confusion from thread stuff. */ + switch_to_no_thread ();=09/* Avoid confusion from thread stuff. */ exit_inferior_silent (current_inferior ()); =20 ::close (trace_fd); --=20 2.14.5