From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by sourceware.org (Postfix) with ESMTP id 0CDBE3945C08 for ; Tue, 14 Apr 2020 17:54:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0CDBE3945C08 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-507-qXrRX3tvOAaZM25eQOCkVA-1; Tue, 14 Apr 2020 13:54:55 -0400 X-MC-Unique: qXrRX3tvOAaZM25eQOCkVA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6FEE0107ACC7 for ; Tue, 14 Apr 2020 17:54:54 +0000 (UTC) Received: from cascais.Home (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0DE8E9F9B4 for ; Tue, 14 Apr 2020 17:54:53 +0000 (UTC) From: Pedro Alves To: gdb-patches@sourceware.org Subject: [PATCH 24/28] Don't write to inferior_ptid in windows-nat.c, part I Date: Tue, 14 Apr 2020 18:54:30 +0100 Message-Id: <20200414175434.8047-25-palves@redhat.com> In-Reply-To: <20200414175434.8047-1-palves@redhat.com> References: <20200414175434.8047-1-palves@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-29.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Apr 2020 17:55:00 -0000 The inferior_ptid hack in do_initial_win32_stuff, added back in 2008: https://sourceware.org/ml/gdb-patches/2008-10/msg00012.html with: commit 9f9d052e600ed9436f9fd558d62a189c8cc3d43e Author: Pierre Muller AuthorDate: Thu Oct 2 14:20:07 2008 +0000 =09 * win32-nat.c (do_initial_win32_stuff): Set inferior_ptid. is no longer needed. Back then, current_inferior looked like this: struct inferior* current_inferior (void) { struct inferior *inf =3D find_inferior_pid (ptid_get_pid (inferior_ptid= )); gdb_assert (inf); return inf; } Nowadays, current_inferior() just returns the global current_inferior_ pointer, which didn't exist back then. gdb/ChangeLog: yyyy-mm-dd Pedro Alves =09* windows-nat.c (do_initial_windows_stuff): No longer set inferior_ptid. --- gdb/windows-nat.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c index 881240c693..1bbebf00b9 100644 --- a/gdb/windows-nat.c +++ b/gdb/windows-nat.c @@ -1985,12 +1985,6 @@ do_initial_windows_stuff (struct target_ops *ops, DW= ORD pid, int attaching) inferior_appeared (inf, pid); inf->attach_flag =3D attaching; =20 - /* Make the new process the current inferior, so terminal handling - can rely on it. When attaching, we don't know about any thread - id here, but that's OK --- nothing should be referencing the - current thread until we report an event out of windows_wait. */ - inferior_ptid =3D ptid_t (pid); - target_terminal::init (); target_terminal::inferior (); =20 --=20 2.14.5