From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
Subject: Re: [PATCH] Fix compilation of python/python.c for Python 3.9
Date: Thu, 16 Apr 2020 05:19:32 -0700 [thread overview]
Message-ID: <20200416051932.60f544ae@f31-4.lan> (raw)
In-Reply-To: <875ze08neu.fsf@tromey.com>
On Wed, 15 Apr 2020 15:11:21 -0600
Tom Tromey <tom@tromey.com> wrote:
> >>>>> "Kevin" == Kevin Buettner via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> >> Since it is not needed as of 3.7, would it make sense for the #if to
> >> be on 0x03070000 instead?
>
> Kevin> It does make sense, and I'm willing to change it if that's the
> Kevin> consensus. I simply chose to use the version number where the call in
> Kevin> question became deprecated.
>
> Either one is fine by me. The patch looks good.
Thanks for looking it over.
I've pushed this commit.
Kevin
prev parent reply other threads:[~2020-04-16 12:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 17:54 Kevin Buettner
2020-04-15 18:02 ` Paul Koning
2020-04-15 18:14 ` Kevin Buettner
2020-04-15 21:11 ` Tom Tromey
2020-04-16 12:19 ` Kevin Buettner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200416051932.60f544ae@f31-4.lan \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).