From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by sourceware.org (Postfix) with ESMTP id EB3CE385BF81 for ; Thu, 16 Apr 2020 12:19:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org EB3CE385BF81 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-202-17xKyW5ZOqKQPqgRI36bWA-1; Thu, 16 Apr 2020 08:19:35 -0400 X-MC-Unique: 17xKyW5ZOqKQPqgRI36bWA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EF0F38017F3; Thu, 16 Apr 2020 12:19:34 +0000 (UTC) Received: from f31-4.lan (ovpn-112-106.phx2.redhat.com [10.3.112.106]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B22ECA0997; Thu, 16 Apr 2020 12:19:34 +0000 (UTC) Date: Thu, 16 Apr 2020 05:19:32 -0700 From: Kevin Buettner To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: Re: [PATCH] Fix compilation of python/python.c for Python 3.9 Message-ID: <20200416051932.60f544ae@f31-4.lan> In-Reply-To: <875ze08neu.fsf@tromey.com> References: <20200415175434.7055-1-kevinb@redhat.com> <20200415111453.14453278@f31-4.lan> <875ze08neu.fsf@tromey.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Apr 2020 12:19:39 -0000 On Wed, 15 Apr 2020 15:11:21 -0600 Tom Tromey wrote: > >>>>> "Kevin" == Kevin Buettner via Gdb-patches writes: > > >> Since it is not needed as of 3.7, would it make sense for the #if to > >> be on 0x03070000 instead? > > Kevin> It does make sense, and I'm willing to change it if that's the > Kevin> consensus. I simply chose to use the version number where the call in > Kevin> question became deprecated. > > Either one is fine by me. The patch looks good. Thanks for looking it over. I've pushed this commit. Kevin