* [PATCH] gdb: change duplicate test name in gdb.base/jit-so.exp
@ 2020-04-20 14:05 Simon Marchi
2020-05-12 0:11 ` Simon Marchi
0 siblings, 1 reply; 2+ messages in thread
From: Simon Marchi @ 2020-04-20 14:05 UTC (permalink / raw)
To: gdb-patches; +Cc: Strasuns, Mihails, Simon Marchi
When running gdb.base/jit-so.exp, we see duplicate test names:
$ grep PASS testsuite/gdb.sum | sort | uniq -c | sort -n
...
2 PASS: gdb.base/jit-so.exp: one_jit_test-1: info function jit_function
2 PASS: gdb.base/jit-so.exp: one_jit_test-2: info function jit_function
Give an explicit name to one test to avoid this.
gdb/testsuite/ChangeLog:
* gdb.base/jit-so.exp (one_jit_test): Change test name.
---
gdb/testsuite/gdb.base/jit-so.exp | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/gdb/testsuite/gdb.base/jit-so.exp b/gdb/testsuite/gdb.base/jit-so.exp
index 27dcdfa58e21..9183df69a03d 100644
--- a/gdb/testsuite/gdb.base/jit-so.exp
+++ b/gdb/testsuite/gdb.base/jit-so.exp
@@ -110,7 +110,8 @@ proc one_jit_test {count match_str} {
gdb_continue_to_breakpoint "break here 2"
# All jit librares must have been unregistered
gdb_test "info function jit_function" \
- "All functions matching regular expression \"jit_function\":"
+ "All functions matching regular expression \"jit_function\":" \
+ "info function jit_function after unregistration"
}
}
--
2.26.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] gdb: change duplicate test name in gdb.base/jit-so.exp
2020-04-20 14:05 [PATCH] gdb: change duplicate test name in gdb.base/jit-so.exp Simon Marchi
@ 2020-05-12 0:11 ` Simon Marchi
0 siblings, 0 replies; 2+ messages in thread
From: Simon Marchi @ 2020-05-12 0:11 UTC (permalink / raw)
To: gdb-patches; +Cc: Strasuns, Mihails
On 2020-04-20 10:05 a.m., Simon Marchi wrote:
> When running gdb.base/jit-so.exp, we see duplicate test names:
>
> $ grep PASS testsuite/gdb.sum | sort | uniq -c | sort -n
> ...
> 2 PASS: gdb.base/jit-so.exp: one_jit_test-1: info function jit_function
> 2 PASS: gdb.base/jit-so.exp: one_jit_test-2: info function jit_function
>
> Give an explicit name to one test to avoid this.
>
> gdb/testsuite/ChangeLog:
>
> * gdb.base/jit-so.exp (one_jit_test): Change test name.
> ---
> gdb/testsuite/gdb.base/jit-so.exp | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gdb/testsuite/gdb.base/jit-so.exp b/gdb/testsuite/gdb.base/jit-so.exp
> index 27dcdfa58e21..9183df69a03d 100644
> --- a/gdb/testsuite/gdb.base/jit-so.exp
> +++ b/gdb/testsuite/gdb.base/jit-so.exp
> @@ -110,7 +110,8 @@ proc one_jit_test {count match_str} {
> gdb_continue_to_breakpoint "break here 2"
> # All jit librares must have been unregistered
> gdb_test "info function jit_function" \
> - "All functions matching regular expression \"jit_function\":"
> + "All functions matching regular expression \"jit_function\":" \
> + "info function jit_function after unregistration"
> }
> }
>
> --
> 2.26.1
>
I had forgotten about this patch but remembered while reviewing the JIT test patchset. I've
pushed it now.
Simon
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-12 0:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-20 14:05 [PATCH] gdb: change duplicate test name in gdb.base/jit-so.exp Simon Marchi
2020-05-12 0:11 ` Simon Marchi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).