From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from barracuda.ebox.ca (barracuda.ebox.ca [96.127.255.19]) by sourceware.org (Postfix) with ESMTPS id A74EE38708AC for ; Sun, 10 May 2020 15:59:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A74EE38708AC X-ASG-Debug-ID: 1589126380-0c856e314b7f0cb0001-fS2M51 Received: from smtp.ebox.ca (smtp.ebox.ca [96.127.255.82]) by barracuda.ebox.ca with ESMTP id X3kivJC6rWmiz30I (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 10 May 2020 11:59:40 -0400 (EDT) X-Barracuda-Envelope-From: simon.marchi@efficios.com X-Barracuda-RBL-Trusted-Forwarder: 96.127.255.82 Received: from smarchi-efficios.lan (unknown [192.222.164.54]) by smtp.ebox.ca (Postfix) with ESMTP id 0D138441B21; Sun, 10 May 2020 11:59:40 -0400 (EDT) From: Simon Marchi X-Barracuda-Effective-Source-IP: 192-222-164-54.qc.cable.ebox.net[192.222.164.54] X-Barracuda-Apparent-Source-IP: 192.222.164.54 X-Barracuda-RBL-IP: 192.222.164.54 To: gdb-patches@sourceware.org Cc: Michael Weghorn , Simon Marchi Subject: [PATCH 1/2] gdb/testsuite: support passing inferior arguments with native-gdbserver board Date: Sun, 10 May 2020 11:59:36 -0400 X-ASG-Orig-Subj: [PATCH 1/2] gdb/testsuite: support passing inferior arguments with native-gdbserver board Message-Id: <20200510155937.1064329-1-simon.marchi@efficios.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <1190e73a-8f10-dc6d-4d59-b9a2929530ad@simark.ca> References: <1190e73a-8f10-dc6d-4d59-b9a2929530ad@simark.ca> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Barracuda-Connect: smtp.ebox.ca[96.127.255.82] X-Barracuda-Start-Time: 1589126380 X-Barracuda-Encrypted: DHE-RSA-AES256-SHA X-Barracuda-URL: https://96.127.255.19:443/cgi-mod/mark.cgi X-Barracuda-Scan-Msg-Size: 12208 X-Virus-Scanned: by bsmtpd at ebox.ca X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.50 X-Barracuda-Spam-Status: No, SCORE=0.50 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=8.0 tests=BSF_RULE7568M X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.81756 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.50 BSF_RULE7568M Custom Rule 7568M X-Spam-Status: No, score=-31.2 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_NONE, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_SOFTFAIL, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 May 2020 15:59:43 -0000 This patch makes it possible to run tests requiring passing arguments to the inferior with the native-gdbserver board. The end goal is to write a test that verifies passing arguments to the inferior works, and to have that test exercise inferior arguments passed on the gdbserver command line, when using the native-gdbserver target board (in addition to the other boards). This is done in the next patch. With the native-gdbserver target board, gdbserver is started in gdb_reload (implemented in config/gdbserver.exp), called in gdb_run_cmd. gdb_run_cmd already supposedly accepts inferior arguments (although that feature does not seem to be used anywhere), which it passes to the `run` command, for non-stub target boards. I've changed gdb_run_cmd so that it forwards these arguments to gdb_reload as well. gdb_reload passes them to gdbserver_run, and they eventually make their way to the gdbserver command line. gdb_run_cmd currently accepts `args` (the varargs of tcl), which means it receives inferior arguments as a list. This won't work with arguments with spaces, because they will end up being formatted with curly braces like this: % set args [list hello "with spaces" world] hello {with spaces} world % puts "run $args" run hello {with spaces} world I've changed it to accept a single string that is passed to `run` and gdb_reload. I've done the same change in gdb_start_cmd and gdb_starti_cmd, although these two are not used with native-gdbserver. I've changed all gdb_reload implementations in the tree to accept a new inferior_args argument, although most of them don't do anything with it (and don't need to). People maintaining target boards out of tree will need to do the same. I found two tests to adjust to avoid adding new failures or errors. These tests needed new [use_gdb_stub] checks, because they rely on having GDB run new processes. These are guarded by a [target_info exists noargs], which made them get skipped on native-gdbserver. But now that the native-gdbserver board supports args, this is no longer enough. Note that with this change, noargs and use_gdb_stub are orthogonal. It took me a moment to grasp this, so I thought I would spell out the different possible situations: - !noargs and !use_gdb_stub: inferior process started by gdb, can pass args - noargs and !use_gdb_stub: inferior process started by gdb (perhaps through extended-remote protocol, the simulator, some other target), but that target doesn't support inferior arguments - noargs and use_gdb_stub: inferior process started by some other program to which GDB connects using the remote protocol, that program does not support passing args to the inferior process - !noargs and use_gdb_stub: inferior process started by some other program to which GDB connects u sing the remote protocol, that program supports passing args to the inferior process gdb/testsuite/ChangeLog: * lib/gdb.exp (gdb_run_cmd): Change argument from args to inferior_args. Pass it to gdb_reload. (gdb_start_cmd, gdb_starti_cmd): Change argument from args to inferior_args. (gdb_reload): Add inferior_args argument. * config/gdbserver.exp (gdb_reload): Add inferior_args argument, pass it to gdbserver_run. * boards/native-gdbserver.exp: Do not set noargs. * boards/native-extended-gdbserver.exp (gdb_reload): Add inferior_args argument. * boards/stdio-gdbserver-base.exp (gdb_reload): Likewise. * gdb.base/a2-run.exp: Check for use_gdb_stub. * gdb.base/args.exp: Likewise. --- .../boards/native-extended-gdbserver.exp | 2 +- gdb/testsuite/boards/native-gdbserver.exp | 3 -- gdb/testsuite/boards/stdio-gdbserver-base.exp | 2 +- gdb/testsuite/config/gdbserver.exp | 12 +++---- gdb/testsuite/gdb.base/a2-run.exp | 11 +++++- gdb/testsuite/gdb.base/args.exp | 6 ++++ gdb/testsuite/lib/gdb.exp | 34 +++++++++++++------ 7 files changed, 46 insertions(+), 24 deletions(-) diff --git a/gdb/testsuite/boards/native-extended-gdbserver.exp b/gdb/testsuite/boards/native-extended-gdbserver.exp index 465c1cc8ab8a..3d5e78211462 100644 --- a/gdb/testsuite/boards/native-extended-gdbserver.exp +++ b/gdb/testsuite/boards/native-extended-gdbserver.exp @@ -102,7 +102,7 @@ proc gdb_file_cmd { arg } { return [extended_gdbserver_load_last_file] } -proc gdb_reload { } { +proc gdb_reload { {inferior_args {}} } { return [extended_gdbserver_load_last_file] } diff --git a/gdb/testsuite/boards/native-gdbserver.exp b/gdb/testsuite/boards/native-gdbserver.exp index f9a507261fff..823f5cfa3ad1 100644 --- a/gdb/testsuite/boards/native-gdbserver.exp +++ b/gdb/testsuite/boards/native-gdbserver.exp @@ -27,9 +27,6 @@ load_board_description "local-board" # This gdbserver can only run a process once per session. set_board_info gdb,do_reload_on_run 1 -# There's no support for argument-passing (yet). -set_board_info noargs 1 - set_board_info use_gdb_stub 1 set_board_info exit_is_reliable 1 diff --git a/gdb/testsuite/boards/stdio-gdbserver-base.exp b/gdb/testsuite/boards/stdio-gdbserver-base.exp index aafcf6991b2c..720e2e823fa8 100644 --- a/gdb/testsuite/boards/stdio-gdbserver-base.exp +++ b/gdb/testsuite/boards/stdio-gdbserver-base.exp @@ -45,7 +45,7 @@ proc make_gdbserver_stdio_port {} { return "| [get_target_remote_pipe_cmd]" } -proc gdb_reload { } { +proc gdb_reload { {inferior_args {}} } { return [gdb_target_cmd "remote" [make_gdbserver_stdio_port]] } diff --git a/gdb/testsuite/config/gdbserver.exp b/gdb/testsuite/config/gdbserver.exp index cb053b63e4c0..a4e935f214d2 100644 --- a/gdb/testsuite/config/gdbserver.exp +++ b/gdb/testsuite/config/gdbserver.exp @@ -36,12 +36,8 @@ # Unles you have a gdbserver that can handle multiple sessions. # # set_board_info noargs 1 -# At present there is no provision in the remote protocol -# for passing arguments. This test framework does not -# address the issue, so it's best to set this variable -# in your baseboard configuration file. -# FIXME: there's no reason why the test harness couldn't -# pass commandline args when it spawns gdbserver. +# Set this if the board does not support passing arguments to the +# inferior process. # # set_board_info gdb,noinferiorio 1 # Neither the traditional gdbserver nor the one in libremote @@ -77,8 +73,8 @@ proc gdbserver_gdb_load { } { return [gdbserver_spawn ""] } -proc gdb_reload { } { - return [gdbserver_run ""] +proc gdb_reload { {inferior_args {}} } { + return [gdbserver_run $inferior_args] } proc gdb_reconnect { } { diff --git a/gdb/testsuite/gdb.base/a2-run.exp b/gdb/testsuite/gdb.base/a2-run.exp index 2e8ed60ec650..ea8f7ec95f49 100644 --- a/gdb/testsuite/gdb.base/a2-run.exp +++ b/gdb/testsuite/gdb.base/a2-run.exp @@ -135,7 +135,7 @@ gdb_run_cmd 5 gdb_test_stdio "" "120" "" "run \"$testfile\" with arg" # Run again with same arguments. -gdb_run_cmd +gdb_run_cmd 5 setup_xfail "arm-*-coff" gdb_test_stdio "" "120" "" "run \"$testfile\" again with same args" @@ -147,6 +147,15 @@ gdb_run_cmd gdb_test_stdio "" "usage: factorial " "" "run after setting args to nil" +# The remaining tests pass inferior arguments through GDB, so doesn't +# work with stub targets, where GDB connects to debug an already started +# process. + +if [use_gdb_stub] { + verbose "Skipping rest of a2-run.exp because target is a stub." + return +} + # Use "set args" command to specify an argument and run again. gdb_test_no_output "set args 6" diff --git a/gdb/testsuite/gdb.base/args.exp b/gdb/testsuite/gdb.base/args.exp index 6c416fcfc8ee..ee75445c0b7e 100644 --- a/gdb/testsuite/gdb.base/args.exp +++ b/gdb/testsuite/gdb.base/args.exp @@ -23,6 +23,12 @@ if [target_info exists noargs] { return } +# This test requires starting new inferior processes, skip it if the target +# board is a stub. +if [use_gdb_stub] { + return +} + standard_testfile if {[build_executable $testfile.exp $testfile \ diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index 3c6f0d76d67d..ec77cfb0d318 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -245,10 +245,13 @@ proc target_can_use_run_cmd {} { # Using ``.*$'' could swallow up output that we attempt to match # elsewhere. # +# INFERIOR_ARGS is passed as arguments to the start command, so may contain +# inferior arguments. +# # N.B. This function does not wait for gdb to return to the prompt, # that is the caller's responsibility. -proc gdb_run_cmd {args} { +proc gdb_run_cmd { {inferior_args {}} } { global gdb_prompt use_gdb_stub foreach command [gdb_init_commands] { @@ -264,7 +267,7 @@ proc gdb_run_cmd {args} { if $use_gdb_stub { if [target_info exists gdb,do_reload_on_run] { - if { [gdb_reload] != 0 } { + if { [gdb_reload $inferior_args] != 0 } { return } send_gdb "continue\n" @@ -309,7 +312,7 @@ proc gdb_run_cmd {args} { send_gdb "y\n" answer } -re "The program is not being run.*$gdb_prompt $" { - if { [gdb_reload] != 0 } { + if { [gdb_reload $inferior_args] != 0 } { return } send_gdb "jump *$start\n" @@ -324,11 +327,11 @@ proc gdb_run_cmd {args} { } if [target_info exists gdb,do_reload_on_run] { - if { [gdb_reload] != 0 } { + if { [gdb_reload $inferior_args] != 0 } { return } } - send_gdb "run $args\n" + send_gdb "run $inferior_args\n" # This doesn't work quite right yet. # Use -notransfer here so that test cases (like chng-sym.exp) # may test for additional start-up messages. @@ -347,10 +350,13 @@ proc gdb_run_cmd {args} { # Generic start command. Return 0 if we could start the program, -1 # if we could not. # +# INFERIOR_ARGS is passed as arguments to the start command, so may contain +# inferior arguments. +# # N.B. This function does not wait for gdb to return to the prompt, # that is the caller's responsibility. -proc gdb_start_cmd {args} { +proc gdb_start_cmd { {inferior_args {}} } { global gdb_prompt use_gdb_stub foreach command [gdb_init_commands] { @@ -368,7 +374,7 @@ proc gdb_start_cmd {args} { return -1 } - send_gdb "start $args\n" + send_gdb "start $inferior_args\n" # Use -notransfer here so that test cases (like chng-sym.exp) # may test for additional start-up messages. gdb_expect 60 { @@ -386,10 +392,13 @@ proc gdb_start_cmd {args} { # Generic starti command. Return 0 if we could start the program, -1 # if we could not. # +# INFERIOR_ARGS is passed as arguments to the starti command, so may contain +# inferior arguments. +# # N.B. This function does not wait for gdb to return to the prompt, # that is the caller's responsibility. -proc gdb_starti_cmd {args} { +proc gdb_starti_cmd { {inferior_args {}} } { global gdb_prompt use_gdb_stub foreach command [gdb_init_commands] { @@ -407,7 +416,7 @@ proc gdb_starti_cmd {args} { return -1 } - send_gdb "starti $args\n" + send_gdb "starti $inferior_args\n" gdb_expect 60 { -re "The program .* has been started already.*y or n. $" { send_gdb "y\n" answer @@ -4817,8 +4826,13 @@ proc gdb_load { arg } { # either the first time or after already starting the program once, # for remote targets. Most files that override gdb_load should now # override this instead. +# +# INFERIOR_ARGS contains the arguments to pass to the inferiors, as a +# single string to get interpreted by a shell. If the target board +# overriding gdb_reload is a "stub", then it should arrange things such +# these arguments make their way to the inferior process. -proc gdb_reload { } { +proc gdb_reload { {inferior_args {}} } { # For the benefit of existing configurations, default to gdb_load. # Specifying no file defaults to the executable currently being # debugged. -- 2.26.2