From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <brobecker@adacore.com>
Received: from rock.gnat.com (rock.gnat.com
 [IPv6:2620:20:4000:0:a9e:1ff:fe9b:1d1])
 by sourceware.org (Postfix) with ESMTP id 8708C384A034
 for <gdb-patches@sourceware.org>; Mon, 18 May 2020 14:17:14 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8708C384A034
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=adacore.com
Authentication-Results: sourceware.org;
 spf=pass smtp.mailfrom=brobecker@adacore.com
Received: from localhost (localhost.localdomain [127.0.0.1])
 by filtered-rock.gnat.com (Postfix) with ESMTP id 67DCA11714B;
 Mon, 18 May 2020 10:17:14 -0400 (EDT)
X-Virus-Scanned: Debian amavisd-new at gnat.com
Received: from rock.gnat.com ([127.0.0.1])
 by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024)
 with LMTP id T1rKZce1YQo4; Mon, 18 May 2020 10:17:14 -0400 (EDT)
Received: from joel.gnat.com (localhost.localdomain [127.0.0.1])
 by rock.gnat.com (Postfix) with ESMTP id 3743B117112;
 Mon, 18 May 2020 10:17:14 -0400 (EDT)
Received: by joel.gnat.com (Postfix, from userid 1000)
 id 8727D8385B; Mon, 18 May 2020 07:17:12 -0700 (PDT)
Date: Mon, 18 May 2020 07:17:12 -0700
From: Joel Brobecker <brobecker@adacore.com>
To: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Avoid short i386 register names on Solaris/x86 [PR25981]
Message-ID: <20200518141712.GB25590@adacore.com>
References: <yddv9kth3y0.fsf@CeBiTec.Uni-Bielefeld.DE>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <yddv9kth3y0.fsf@CeBiTec.Uni-Bielefeld.DE>
User-Agent: Mutt/1.9.4 (2018-02-28)
X-Spam-Status: No, score=-10.3 required=5.0 tests=BAYES_00, GIT_PATCH_0,
 JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 18 May 2020 14:17:15 -0000

Hi Rainer,

> Like its companion, I mean to apply this patch to master soon.  Also ok
> for the gdb-9 branch?


> 2020-05-13  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
> 
> 	PR build/25981
> 	* i386-sol2-nat.c [PR_MODEL_NATIVE != PR_MODEL_LP64] (regmap):
> 	Hardcode register numbers.

OK for the gdb-9-branch as well.

> # HG changeset patch
> # Parent  5c9d0cbd828af3a966218440022ba7fb248b5ca5
> Avoid short i386 register names on Solaris/x86 [PR25981]
> 
> diff --git a/gdb/i386-sol2-nat.c b/gdb/i386-sol2-nat.c
> --- a/gdb/i386-sol2-nat.c
> +++ b/gdb/i386-sol2-nat.c
> @@ -178,10 +178,22 @@ fill_fpregset (const struct regcache *re
>     format and GDB's register array layout.  */
>  static int regmap[] =
>  {
> -  EAX, ECX, EDX, EBX,
> -  UESP, EBP, ESI, EDI,
> -  EIP, EFL, CS, SS,
> -  DS, ES, FS, GS
> +  11	/* EAX */,
> +  10	/* ECX */,
> +  9	/* EDX */,
> +  8	/* EBX */,
> +  17	/* UESP */,
> +  6	/* EBP */,
> +  5	/* ESI */,
> +  4	/* EDI */,
> +  14	/* EIP */,
> +  16	/* EFL */,
> +  15	/* CS */,
> +  18	/* SS */,
> +  3	/* DS */,
> +  2	/* ES */,
> +  1	/* FS */,
> +  0	/* GS */
>  };
>  
>  /* Fill GDB's register array with the general-purpose register values


-- 
Joel