From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id E09DD3851C29 for ; Mon, 18 May 2020 14:34:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E09DD3851C29 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tdevries@suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id BC271AE25; Mon, 18 May 2020 14:34:39 +0000 (UTC) Date: Mon, 18 May 2020 16:34:35 +0200 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [committed][gdb/testsuite] Use with_test_prefix in gdb.base/gdb-caching-proc.exp Message-ID: <20200518143433.GA17687@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-18.3 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 May 2020 14:34:39 -0000 Hi, When running test-case gdb.base/gdb-caching-proc.exp all passes are unique, but fails might not be. Fix this by using with_test_prefix. Tested on x86_64-linux. Committed to trunk. Thanks, - Tom [gdb/testsuite] Use with_test_prefix in gdb.base/gdb-caching-proc.exp gdb/testsuite/ChangeLog: 2020-05-18 Tom de Vries * gdb.base/gdb-caching-proc.exp: Use with_test_prefix. --- gdb/testsuite/gdb.base/gdb-caching-proc.exp | 42 ++++++++++++++++------------- 1 file changed, 24 insertions(+), 18 deletions(-) diff --git a/gdb/testsuite/gdb.base/gdb-caching-proc.exp b/gdb/testsuite/gdb.base/gdb-caching-proc.exp index 3810347a65..f1dd834cf9 100644 --- a/gdb/testsuite/gdb.base/gdb-caching-proc.exp +++ b/gdb/testsuite/gdb.base/gdb-caching-proc.exp @@ -28,7 +28,9 @@ proc test_proc { name } { set resultlist [list] - set first [gdb_do_cache_wrap $real_name] + with_test_prefix intial { + set first [gdb_do_cache_wrap $real_name] + } lappend resultlist $first # Ten repetitions was enough to trigger target_supports_scheduler_locking, @@ -37,7 +39,9 @@ proc test_proc { name } { set racy 0 for {set i 0} {$i < $repeat} {incr i} { - set rerun [gdb_do_cache_wrap $real_name] + with_test_prefix $i { + set rerun [gdb_do_cache_wrap $real_name] + } lappend resultlist $rerun if { $rerun != $first } { set racy 1 @@ -45,9 +49,9 @@ proc test_proc { name } { } if { $racy == 0 } { - pass "$name consistency" + pass "consistency" } else { - fail "$name consistency" + fail "consistency" verbose -log "$name: $resultlist" } } @@ -77,20 +81,22 @@ proc test_file { file } { } foreach procname $procnames { - switch $procname { - "is_address_zero_readable" { set setup_gdb 1 } - "target_is_gdbserver" { set setup_gdb 1 } - default {set setup_gdb 0 } - } - - if { $setup_gdb } { - clean_restart $obj - } - - test_proc $procname - - if { $setup_gdb } { - gdb_exit + with_test_prefix $procname { + switch $procname { + "is_address_zero_readable" { set setup_gdb 1 } + "target_is_gdbserver" { set setup_gdb 1 } + default {set setup_gdb 0 } + } + + if { $setup_gdb } { + clean_restart $obj + } + + test_proc $procname + + if { $setup_gdb } { + gdb_exit + } } } }