From: Michael Weghorn <m.weghorn@posteo.de>
To: gdb-patches@sourceware.org
Cc: Michael Weghorn <m.weghorn@posteo.de>
Subject: [PATCH v5 7/9] gdbsupport: Drop now unused function 'stringify_argv'
Date: Wed, 20 May 2020 18:21:13 +0200 [thread overview]
Message-ID: <20200520162115.713005-7-m.weghorn@posteo.de> (raw)
In-Reply-To: <20200520162115.713005-1-m.weghorn@posteo.de>
The function did not properly escape special characters
and all uses have been replaced in previous commits, so
drop the now unused function.
gdbsupport/ChangeLog:
2020-05-13 Michael Weghorn <m.weghorn@posteo.de>
* common-utils.cc, common-utils.h (stringify_argv): Drop
now unused function stringify_argv
---
gdbsupport/common-utils.cc | 23 -----------------------
gdbsupport/common-utils.h | 4 ----
2 files changed, 27 deletions(-)
diff --git a/gdbsupport/common-utils.cc b/gdbsupport/common-utils.cc
index ed05d619c7..b5e4d2928e 100644
--- a/gdbsupport/common-utils.cc
+++ b/gdbsupport/common-utils.cc
@@ -375,29 +375,6 @@ free_vector_argv (std::vector<char *> &v)
/* See gdbsupport/common-utils.h. */
-std::string
-stringify_argv (const std::vector<char *> &args)
-{
- std::string ret;
-
- if (!args.empty () && args[0] != NULL)
- {
- for (auto s : args)
- if (s != NULL)
- {
- ret += s;
- ret += ' ';
- }
-
- /* Erase the last whitespace. */
- ret.erase (ret.end () - 1);
- }
-
- return ret;
-}
-
-/* See gdbsupport/common-utils.h. */
-
ULONGEST
align_up (ULONGEST v, int n)
{
diff --git a/gdbsupport/common-utils.h b/gdbsupport/common-utils.h
index ba03427c6f..30ee412365 100644
--- a/gdbsupport/common-utils.h
+++ b/gdbsupport/common-utils.h
@@ -154,10 +154,6 @@ extern const char *skip_to_space (const char *inp);
freeing all the elements. */
extern void free_vector_argv (std::vector<char *> &v);
-/* Given a vector of arguments ARGV, return a string equivalent to
- joining all the arguments with a whitespace separating them. */
-extern std::string stringify_argv (const std::vector<char *> &argv);
-
/* Return true if VALUE is in [LOW, HIGH]. */
template <typename T>
--
2.26.2
next prev parent reply other threads:[~2020-05-20 16:21 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 11:16 Patches for PR 25893 "gdbserver incorrectly handles program args containing space" Michael Weghorn
2020-04-29 11:16 ` [PATCH 0/4] gdb: Move construct_inferior_arguments to gdbsupport Michael Weghorn
2020-05-07 19:31 ` Simon Marchi
2020-05-12 15:50 ` Michael Weghorn
2020-04-29 11:16 ` [PATCH 1/4] gdbsupport: Extend construct_inferior_arguments to allow handling all stringify_args cases Michael Weghorn
2020-04-29 15:25 ` Christian Biesinger
2020-04-29 15:45 ` Christian Biesinger
2020-05-07 19:29 ` Simon Marchi
2020-05-12 15:48 ` Michael Weghorn
2020-05-12 16:11 ` Simon Marchi
2020-05-12 16:24 ` Michael Weghorn
2020-04-30 6:02 ` [PATCH v2 " Michael Weghorn
2020-05-07 19:49 ` Simon Marchi
2020-05-12 15:57 ` Michael Weghorn
2020-04-29 11:16 ` [PATCH 2/4] gdbserver: Don't add extra NULL to program args Michael Weghorn
2020-05-07 19:54 ` Simon Marchi
2020-05-12 16:00 ` Michael Weghorn
2020-04-29 11:16 ` [PATCH 3/4] [PR gdbserver/25893]: Use construct_inferior_arguments which handles special chars Michael Weghorn
2020-05-07 20:09 ` Simon Marchi
2020-05-07 22:09 ` Simon Marchi
2020-05-12 16:10 ` Michael Weghorn
2020-05-12 16:07 ` Michael Weghorn
2020-05-12 17:37 ` Simon Marchi
2020-05-13 1:59 ` Simon Marchi
2020-05-13 9:51 ` Michael Weghorn
2020-04-29 11:16 ` [PATCH 4/4] [PR gdbserver/25893]: Add gdbserver test for argument with space in it Michael Weghorn
2020-05-07 22:15 ` Simon Marchi
2020-05-10 15:59 ` [PATCH 1/2] gdb/testsuite: support passing inferior arguments with native-gdbserver board Simon Marchi
2020-05-10 15:59 ` [PATCH 2/2] gdb/testsuite: add inferior arguments test Simon Marchi
2020-05-15 20:07 ` Pedro Alves
2020-05-19 17:13 ` Simon Marchi
2020-05-20 16:28 ` Michael Weghorn
2020-05-15 20:07 ` [PATCH 1/2] gdb/testsuite: support passing inferior arguments with native-gdbserver board Pedro Alves
2020-05-10 16:09 ` [PATCH 4/4] [PR gdbserver/25893]: Add gdbserver test for argument with space in it Simon Marchi
2020-05-11 14:33 ` Michael Weghorn
2020-05-11 15:04 ` Simon Marchi
2020-05-12 16:20 ` Michael Weghorn
2020-05-12 16:50 ` Simon Marchi
2020-05-13 9:55 ` Michael Weghorn
2020-04-29 15:27 ` Patches for PR 25893 "gdbserver incorrectly handles program args containing space" Simon Marchi
2020-04-30 6:03 ` Michael Weghorn
2020-05-12 15:42 ` [PATCH v3 1/6] gdb: Move construct_inferior_arguments to gdbsupport Michael Weghorn
2020-05-12 15:42 ` [PATCH v3 2/6] gdbsupport: Adapt construct_inferior_arguments Michael Weghorn
2020-05-12 17:53 ` Simon Marchi
2020-05-13 9:56 ` Michael Weghorn
2020-05-12 15:42 ` [PATCH v3 3/6] gdbserver: Don't add extra NULL to program args Michael Weghorn
2020-05-12 15:42 ` [PATCH v3 4/6] nto_process_target::create_inferior: Pass args as char ** Michael Weghorn
2020-05-12 18:34 ` Simon Marchi
2020-05-13 9:56 ` Michael Weghorn
2020-05-12 15:42 ` [PATCH v3 5/6] [PR gdbserver/25893]: Use construct_inferior_arguments which handles special chars Michael Weghorn
2020-05-13 0:52 ` Simon Marchi
2020-05-13 0:54 ` Simon Marchi
2020-05-13 9:58 ` Michael Weghorn
2020-05-12 15:42 ` [PATCH v3 6/6] gdbsupport: Drop now unused function 'stringify_argv' Michael Weghorn
2020-05-13 0:52 ` Simon Marchi
2020-05-13 9:47 ` [PATCH v4 1/9] gdb: Move construct_inferior_arguments to gdbsupport Michael Weghorn
2020-05-13 9:47 ` [PATCH v4 2/9] gdbsupport: Adapt construct_inferior_arguments Michael Weghorn
2020-05-13 9:47 ` [PATCH v4 3/9] gdbsupport: Let construct_inferior_arguments take gdb::array_view param Michael Weghorn
2020-05-13 9:47 ` [PATCH v4 4/9] gdbserver: Don't add extra NULL to program args Michael Weghorn
2020-05-13 9:47 ` [PATCH v4 5/9] nto_process_target::create_inferior: Pass args as char ** Michael Weghorn
2020-05-13 9:47 ` [PATCH v4 6/9] [PR gdbserver/25893]: Use construct_inferior_arguments which handles special chars Michael Weghorn
2020-05-13 9:47 ` [PATCH v4 7/9] gdbsupport: Drop now unused function 'stringify_argv' Michael Weghorn
2020-05-13 9:47 ` [PATCH v4 8/9] gdb/testsuite: support passing inferior arguments with native-gdbserver board Michael Weghorn
2020-05-15 17:29 ` Tom de Vries
2020-05-19 17:11 ` Simon Marchi
2020-05-19 17:22 ` Simon Marchi
2020-05-19 18:46 ` Tom de Vries
2020-05-25 15:14 ` Simon Marchi
2020-05-13 9:47 ` [PATCH v4 9/9] gdb/testsuite: add inferior arguments test Michael Weghorn
2020-05-13 14:39 ` [PATCH v4 1/9] gdb: Move construct_inferior_arguments to gdbsupport Simon Marchi
2020-05-13 15:01 ` Michael Weghorn
2020-05-13 15:05 ` Simon Marchi
2020-05-20 16:37 ` Michael Weghorn
2020-05-20 16:40 ` Simon Marchi
2020-05-20 16:21 ` [PATCH v5 " Michael Weghorn
2020-05-20 16:21 ` [PATCH v5 2/9] gdbsupport: Adapt construct_inferior_arguments Michael Weghorn
2020-05-20 16:21 ` [PATCH v5 3/9] gdbsupport: Let construct_inferior_arguments take gdb::array_view param Michael Weghorn
2020-05-20 16:21 ` [PATCH v5 4/9] gdbserver: Don't add extra NULL to program args Michael Weghorn
2020-05-20 16:21 ` [PATCH v5 5/9] nto_process_target::create_inferior: Pass args as char ** Michael Weghorn
2020-05-20 16:21 ` [PATCH v5 6/9] [PR gdbserver/25893]: Use construct_inferior_arguments which handles special chars Michael Weghorn
2020-05-20 16:21 ` Michael Weghorn [this message]
2020-05-20 16:21 ` [PATCH v5 8/9] gdb/testsuite: support passing inferior arguments with native-gdbserver board Michael Weghorn
2020-05-20 16:21 ` [PATCH v5 9/9] gdb/testsuite: add inferior arguments test Michael Weghorn
2020-05-25 15:42 ` [PATCH v5 1/9] gdb: Move construct_inferior_arguments to gdbsupport Simon Marchi
2020-05-26 6:17 ` Michael Weghorn
2021-09-28 14:33 ` Simon Marchi
2021-09-29 5:53 ` Michael Weghorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200520162115.713005-7-m.weghorn@posteo.de \
--to=m.weghorn@posteo.de \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).