public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Christian Biesinger via gdb-patches <gdb-patches@sourceware.org>,
	simon.marchi@polymtl.ca
Subject: Pushed to gdb-9-branch: [PUSHED/OBVIOUS] Fix base class function call
Date: Sat, 23 May 2020 09:31:30 -0700	[thread overview]
Message-ID: <20200523163130.GA2122@adacore.com> (raw)
In-Reply-To: <20200205175257.197506-1-cbiesinger@google.com>

Hi Christian (and Simon),

On Wed, Feb 05, 2020 at 11:52:57AM -0600, Christian Biesinger via gdb-patches wrote:
> This was a typo introduced in f6ac5f3d63e03a81c4ff3749aba234961cc9090e.
> 
> Found by looking through NetBSD's GDB patches:
> https://github.com/NetBSD/pkgsrc-wip/blob/master/gdb-netbsd/patches/patch-gdb_sparc-nat.h
> 
> This patch can't be tested on Linux because Linux does not use the
> sparc_target template.
> 
> gdb/ChangeLog:
> 
> 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
> 
> 	* sparc-nat.h (struct sparc_target) <xfer_partial>: Fix base class
> 	function call.

As a user stumbled onto the error that this commit fixes, and the correction
is indeed quite obvious, I created a new PR for this issue, and then
backported the patch to the gdb-9-branch:

    https://sourceware.org/bugzilla/show_bug.cgi?id=26029

> 
> Change-Id: I4fa88cbdc365efe89b84cc0619b60db38718d9ce
> ---
>  gdb/sparc-nat.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/gdb/sparc-nat.h b/gdb/sparc-nat.h
> index 1dbdd80b5e..d07bd86d03 100644
> --- a/gdb/sparc-nat.h
> +++ b/gdb/sparc-nat.h
> @@ -75,8 +75,8 @@ struct sparc_target : public BaseTarget
>        return sparc_xfer_wcookie (object, annex, readbuf, writebuf,
>  				 offset, len, xfered_len);
>  
> -    return BaseTarget (object, annex, readbuf, writebuf,
> -		       offset, len, xfered_len);
> +    return BaseTarget::xfer_partial (object, annex, readbuf, writebuf,
> +				     offset, len, xfered_len);
>    }
>  };
>  
> -- 
> 2.25.0.341.g760bfbb309-goog

-- 
Joel

  reply	other threads:[~2020-05-23 16:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-05 17:53 Christian Biesinger via gdb-patches
2020-05-23 16:31 ` Joel Brobecker [this message]
2020-05-23 18:58   ` Pushed to gdb-9-branch: " Christian Biesinger
2020-05-24 22:44     ` Joel Brobecker
2020-05-23 21:24   ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200523163130.GA2122@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).