From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rock.gnat.com (rock.gnat.com [IPv6:2620:20:4000:0:a9e:1ff:fe9b:1d1]) by sourceware.org (Postfix) with ESMTP id 23363384A034 for ; Sat, 23 May 2020 16:31:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 23363384A034 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=brobecker@adacore.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id CA70C1167F2; Sat, 23 May 2020 12:31:32 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at gnat.com Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id XNTeVmluMcRL; Sat, 23 May 2020 12:31:32 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id B18A4116794; Sat, 23 May 2020 12:31:31 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 27D1182CC9; Sat, 23 May 2020 09:31:30 -0700 (PDT) Date: Sat, 23 May 2020 09:31:30 -0700 From: Joel Brobecker To: Christian Biesinger via gdb-patches , simon.marchi@polymtl.ca Subject: Pushed to gdb-9-branch: [PUSHED/OBVIOUS] Fix base class function call Message-ID: <20200523163130.GA2122@adacore.com> References: <20200205175257.197506-1-cbiesinger@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200205175257.197506-1-cbiesinger@google.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Spam-Status: No, score=-10.4 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 May 2020 16:31:34 -0000 Hi Christian (and Simon), On Wed, Feb 05, 2020 at 11:52:57AM -0600, Christian Biesinger via gdb-patches wrote: > This was a typo introduced in f6ac5f3d63e03a81c4ff3749aba234961cc9090e. > > Found by looking through NetBSD's GDB patches: > https://github.com/NetBSD/pkgsrc-wip/blob/master/gdb-netbsd/patches/patch-gdb_sparc-nat.h > > This patch can't be tested on Linux because Linux does not use the > sparc_target template. > > gdb/ChangeLog: > > 2020-02-05 Christian Biesinger > > * sparc-nat.h (struct sparc_target) : Fix base class > function call. As a user stumbled onto the error that this commit fixes, and the correction is indeed quite obvious, I created a new PR for this issue, and then backported the patch to the gdb-9-branch: https://sourceware.org/bugzilla/show_bug.cgi?id=26029 > > Change-Id: I4fa88cbdc365efe89b84cc0619b60db38718d9ce > --- > gdb/sparc-nat.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gdb/sparc-nat.h b/gdb/sparc-nat.h > index 1dbdd80b5e..d07bd86d03 100644 > --- a/gdb/sparc-nat.h > +++ b/gdb/sparc-nat.h > @@ -75,8 +75,8 @@ struct sparc_target : public BaseTarget > return sparc_xfer_wcookie (object, annex, readbuf, writebuf, > offset, len, xfered_len); > > - return BaseTarget (object, annex, readbuf, writebuf, > - offset, len, xfered_len); > + return BaseTarget::xfer_partial (object, annex, readbuf, writebuf, > + offset, len, xfered_len); > } > }; > > -- > 2.25.0.341.g760bfbb309-goog -- Joel