From: Hannes Domani <ssbssa@yahoo.de>
To: gdb-patches@sourceware.org
Subject: [PATCH 2/2] Handle Windows drives in auto-load script paths
Date: Fri, 29 May 2020 17:08:00 +0200 [thread overview]
Message-ID: <20200529150800.2013-2-ssbssa@yahoo.de> (raw)
In-Reply-To: <20200529150800.2013-1-ssbssa@yahoo.de>
Fixes this testsuite fail on Windows:
FAIL: gdb.base/auto-load.exp: print $script_loaded
Converts the debugfile path from c:/dir/file to /c/dir/file, so it can be
appended to the auto-load path.
gdb/ChangeLog:
2020-05-29 Hannes Domani <ssbssa@yahoo.de>
* auto-load.c (auto_load_objfile_script_1): Convert drive part
of debugfile path on Windows.
gdb/doc/ChangeLog:
2020-05-29 Hannes Domani <ssbssa@yahoo.de>
* gdb.texinfo: Document Windows drive conversion of
'set auto-load scripts-directory'.
---
v2:
- Document Windows drive conversion of 'set auto-load scripts-directory'.
---
gdb/auto-load.c | 7 +++++++
gdb/doc/gdb.texinfo | 4 ++++
2 files changed, 11 insertions(+)
diff --git a/gdb/auto-load.c b/gdb/auto-load.c
index 99bd96b971..88221d9f3d 100644
--- a/gdb/auto-load.c
+++ b/gdb/auto-load.c
@@ -784,6 +784,13 @@ auto_load_objfile_script_1 (struct objfile *objfile, const char *realname,
"scripts-directory' path \"%s\".\n"),
auto_load_dir);
+ /* Convert Windows debugfile path from c:/dir/file to /c/dir/file. */
+ if (HAS_DRIVE_SPEC (debugfile))
+ {
+ debugfile_holder = STRIP_DRIVE_SPEC (debugfile);
+ filename = std::string("/") + debugfile[0] + debugfile_holder;
+ }
+
for (const gdb::unique_xmalloc_ptr<char> &dir : vec)
{
/* FILENAME is absolute, so we don't need a "/" here. */
diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index 292fd4d14e..f31d7013b9 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -27266,6 +27266,10 @@ script in the specified extension language.
If this file does not exist, then @value{GDBN} will look for
@var{script-name} file in all of the directories as specified below.
+(On MS-Windows/MS-DOS, the drive letter of the executable's leading
+directories is converted to a one-letter subdirectory, i.e.@:
+@file{d:/usr/bin/} is converted to @file{/d/usr/bin/}, because Windows
+filesystems disallow colons in file names.)
Note that loading of these files requires an accordingly configured
@code{auto-load safe-path} (@pxref{Auto-loading safe path}).
--
2.26.2
next prev parent reply other threads:[~2020-05-29 15:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200529150800.2013-1-ssbssa.ref@yahoo.de>
2020-05-29 15:07 ` [PATCH v2 1/2] Fix function argument and return value locations Hannes Domani
2020-05-29 15:08 ` Hannes Domani [this message]
2020-05-29 15:15 ` [PATCH 2/2] Handle Windows drives in auto-load script paths Eli Zaretskii
2020-10-05 2:06 ` Simon Marchi
2020-10-05 11:23 ` Hannes Domani
2020-10-05 13:03 ` Simon Marchi
2020-07-08 17:23 ` [PATCH v2 1/2] Fix function argument and return value locations Hannes Domani
2020-10-05 1:50 ` Simon Marchi
2020-10-05 12:32 ` Hannes Domani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200529150800.2013-2-ssbssa@yahoo.de \
--to=ssbssa@yahoo.de \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).