From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hera.aquilenet.fr (hera.aquilenet.fr [185.233.100.1]) by sourceware.org (Postfix) with ESMTPS id F070A385DC35 for ; Sat, 30 May 2020 17:22:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org F070A385DC35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=samuel.thibault@gnu.org Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id BD4096B3D; Sat, 30 May 2020 19:22:13 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id T4yfn8EbN_Vz; Sat, 30 May 2020 19:22:12 +0200 (CEST) Received: from function.home (lfbn-bor-1-797-11.w86-234.abo.wanadoo.fr [86.234.239.11]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 867CB69FF; Sat, 30 May 2020 19:22:12 +0200 (CEST) Received: from samy by function.home with local (Exim 4.93) (envelope-from ) id 1jf5BT-00A9G0-BM; Sat, 30 May 2020 19:22:11 +0200 Date: Sat, 30 May 2020 19:22:11 +0200 From: Samuel Thibault To: Simon Marchi Cc: gdb-patches@sourceware.org, Thomas Schwinge , thomas@schwinge.name, bug-hurd@gnu.org Subject: Re: [PATCHv2 6/7] hurd: add gnu_target pointer to fix thread API calls Message-ID: <20200530172211.dt6xh33dhrdpa76r@function> Mail-Followup-To: Simon Marchi , gdb-patches@sourceware.org, Thomas Schwinge , thomas@schwinge.name, bug-hurd@gnu.org References: <20200529220049.gm7vt7gvtw7if6lg@function> <20200529220350.k4g6kca42vs7y3r6@function> <4d1dce2c-84aa-2f05-6f90-705bb2842c90@simark.ca> <20200530155326.o364seuoi6burg3o@function> <4f5f1015-6b4f-1808-f6a4-bfedb0506f08@simark.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4f5f1015-6b4f-1808-f6a4-bfedb0506f08@simark.ca> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_SOFTFAIL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 May 2020 17:22:17 -0000 Simon Marchi, le sam. 30 mai 2020 12:08:53 -0400, a ecrit: > On 2020-05-30 11:53 a.m., Samuel Thibault wrote: > > Simon Marchi, le sam. 30 mai 2020 10:57:42 -0400, a ecrit: > >>> @@ -1106,12 +1109,12 @@ inf_validate_procs (struct inf *inf) > >>> if (inferior_ptid == ptid_t (inf->pid)) > >>> /* This is the first time we're hearing about thread > >>> ids, after a fork-child. */ > >>> - thread_change_ptid (inferior_ptid, ptid); > >>> + thread_change_ptid (gnu_target, inferior_ptid, ptid); > >> > >> > >> I think it would have been more straightforward and clean to use `inf->process_target ()` > >> (assuming it's the correct thing to do), given that you have access to the appropriate > >> inferior everywhere you made changes. > > > > I didn't see a way to access the inferior here (inf is a > > gnu-nat.c-specific structure with no link to struct inferior) > > Ah I see. Well, I didn't check all code paths, but for example, for the one that goes: > > - gnu_nat_target::attach > - inf_attach > - inf_startup > - inf_set_pid > > A solution would be to make all these inf_* functions to be private methods of the > gnu_nat_target class. Ok, I see. thread_change_ptid is however also called from inf_validate_procs, called from inf_update_procs, called from i386_gnu_dr_set_control, referenced from the x86 backend x86_dr_low.set_control = i386_gnu_dr_set_control; For simplicity I'll keep gnu_target for now, but also work on cleaning these should-be-static/private functions. Samuel