From: Samuel Thibault <samuel.thibault@gnu.org>
To: Simon Marchi <simark@simark.ca>
Cc: gdb-patches@sourceware.org,
Thomas Schwinge <thomas@codesourcery.com>,
thomas@schwinge.name, bug-hurd@gnu.org
Subject: Re: [PATCH] gnu-nat: Move local functions inside gnu_nat_target class
Date: Sun, 31 May 2020 09:42:56 +0200 [thread overview]
Message-ID: <20200531074256.ronlpeold7aiywec@function> (raw)
In-Reply-To: <b092a4bf-4787-2f0d-2b4f-493ca0bb731f@simark.ca>
Simon Marchi, le sam. 30 mai 2020 19:59:03 -0400, a ecrit:
> On 2020-05-30 2:04 p.m., Samuel Thibault wrote:
> > This allows to have the process_stratum_target object at hand for future use in
> > the gdb API, and only use gnu_target from external calls.
> >
> > gdb/Changelog:
> >
> > * gnu-nat.h (inf_validate_procs, inf_suspend, inf_set_traced,
> > steal_exc_port, proc_get_state, inf_clear_wait, inf_cleanup,
> > inf_startup, inf_update_suspends, inf_set_pid, inf_steal_exc_ports,
> > inf_validate_procinfo, inf_validate_task_sc, inf_restore_exc_ports,
> > inf_set_threads_resume_sc, inf_set_threads_resume_sc_for_signal_thread,
> > inf_resume, inf_set_step_thread, inf_detach, inf_attach, inf_signal,
> > inf_continue, make_proc, proc_abort, _proc_free, proc_update_sc,
> > proc_get_exception_port, proc_set_exception_port, _proc_get_exc_port,
> > proc_steal_exc_port, proc_restore_exc_port, proc_trace): Move functions
> > to gnu_nat_target class.
> > * gnu-nat.c: Likewise.
> > (inf_update_procs, S_proc_wait_reply, set_task_pause_cmd,
> > set_task_exc_port_cmd, set_signals_cmd, set_thread_pause_cmd,
> > set_thread_exc_port_cmd): Call inf_validate_procs through gnu_target
> > object.
> > (gnu_nat_target::create_inferior, gnu_nat_target::detach): Pass `this'
> > instead of `gnu_target'.
>
> Thanks, this LGTM, I think it's a good step forward.
Applied, thanks!
Samuel
prev parent reply other threads:[~2020-05-31 7:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-30 18:04 Samuel Thibault
2020-05-30 23:59 ` Simon Marchi
2020-05-31 7:42 ` Samuel Thibault [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200531074256.ronlpeold7aiywec@function \
--to=samuel.thibault@gnu.org \
--cc=bug-hurd@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
--cc=thomas@codesourcery.com \
--cc=thomas@schwinge.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).