From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by sourceware.org (Postfix) with ESMTP id 068BB3947422 for ; Thu, 18 Jun 2020 04:09:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 068BB3947422 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-286-5TEtIzBoO76o_rd5FtDvfQ-1; Thu, 18 Jun 2020 00:09:05 -0400 X-MC-Unique: 5TEtIzBoO76o_rd5FtDvfQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 39233464 for ; Thu, 18 Jun 2020 04:09:04 +0000 (UTC) Received: from f32-1.lan (ovpn-115-18.phx2.redhat.com [10.3.115.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 66A6B5C1D6; Thu, 18 Jun 2020 04:09:02 +0000 (UTC) From: Kevin Buettner To: gdb-patches@sourceware.org Subject: [PATCH v3 0/9] Fix BZ 25631 - core file memory access problem Date: Wed, 17 Jun 2020 21:08:15 -0700 Message-Id: <20200618040824.3405657-1-kevinb@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jun 2020 04:09:08 -0000 Nick Clifton has approved patch #1. It hasn't changed since approval. I think that Pedro is okay with patch #2, #4, and #5. They haven't changed for this v3 series. I made the updates that Pedro requested for patch #3, but it should probably be reviewed again just to make sure that I didn't mess anything up. Patch #6 is new, but it will need approval from a binutils maintainer. I'll attempt to CC it to that list. Patch #7 is new and will definitely require careful review. Patches #8 and #9 are also new. They add new tests for the cases which #7 now handles. So, in summary, patches #3, #7, #8, and #9 should be reviewed by a GDB maintainer. Patch #6 requires approval by a binutils maintainer. Kevin Buettner (9): 1) Remove hack for GDB which sets the section size to 0 2) Adjust corefile.exp test to show regression after bfd hack removal 3) section_table_xfer_memory: Replace section name with callback predicate 4) Provide access to non SEC_HAS_CONTENTS core file sections 5) Test ability to access unwritten-to mmap data in core file 6) Update binary_get_section_contents to seek using section's file position 7) Use NT_FILE note section for reading core target memory 8) Add test for accessing read-only mmapped data in a core file 9) New core file tests with mappings over existing program memory bfd/binary.c | 12 +- bfd/elf.c | 8 - gdb/bfd-target.c | 3 +- gdb/corelow.c | 239 ++- gdb/exec.c | 8 +- gdb/exec.h | 13 +- gdb/target.c | 18 +- gdb/testsuite/gdb.base/corefile.exp | 24 +- gdb/testsuite/gdb.base/corefile2.exp | 115 ++ gdb/testsuite/gdb.base/coremaker.c | 30 +- gdb/testsuite/gdb.base/coremaker2.c | 2178 ++++++++++++++++++++++++++ 11 files changed, 2610 insertions(+), 38 deletions(-) create mode 100644 gdb/testsuite/gdb.base/corefile2.exp create mode 100644 gdb/testsuite/gdb.base/coremaker2.c -- 2.26.2