From: Andrew Burgess <andrew.burgess@embecosm.com>
To: gdb-patches@sourceware.org
Cc: Pedro Alves <palves@redhat.com>
Subject: Re: [PATCHv2 0/3] Additional maintenance command for dumping target descriptions
Date: Mon, 22 Jun 2020 19:13:04 +0100 [thread overview]
Message-ID: <20200622181304.GM2737@embecosm.com> (raw)
In-Reply-To: <cover.1591917512.git.andrew.burgess@embecosm.com>
Pedro,
I wonder if you have any feedback on the changes in this version?
Specifically with how I now handle the 'compatibility' tags in a way
that allows the code to be shared between gdbserver and gdb?
Thanks
Andrew
---
* Andrew Burgess <andrew.burgess@embecosm.com> [2020-06-12 00:22:45 +0100]:
> In the first patch of this series the only change is I addressed
> Pedro's feedback.
>
> The second patch is new, this moves the printing of <compatible>
> entities into the gdbsupport/ directory, inside the print_xml_feature
> class.
>
> The third patch is the old second patch. The documentation has not
> changed. The code is now simpler thanks to the new #2 patch. I
> addressed Pedro's feedback including adding some extra tests.
>
> Feedback welcome.
>
> Thanks,
> Andrew
>
>
> ---
>
> Andrew Burgess (3):
> gdb: Allow target description to be dumped even when it is remote
> gdb: Print compatible information within print_xml_feature
> gdb: New maintenance command to print XML target description
>
> gdb/ChangeLog | 30 +++++
> gdb/NEWS | 6 +
> gdb/doc/ChangeLog | 5 +
> gdb/doc/gdb.texinfo | 9 ++
> gdb/target-descriptions.c | 109 ++++++++++++++---
> gdb/testsuite/ChangeLog | 8 ++
> gdb/testsuite/gdb.xml/maint-xml-dump-01.xml | 10 ++
> gdb/testsuite/gdb.xml/maint-xml-dump-02.xml | 27 +++++
> gdb/testsuite/gdb.xml/maint-xml-dump.exp | 124 ++++++++++++++++++++
> gdb/testsuite/gdb.xml/tdesc-reload.c | 22 ++++
> gdb/testsuite/gdb.xml/tdesc-reload.exp | 83 +++++++++++++
> gdbserver/ChangeLog | 6 +
> gdbserver/tdesc.cc | 21 ++++
> gdbsupport/ChangeLog | 22 ++++
> gdbsupport/tdesc.cc | 106 ++++++++++++-----
> gdbsupport/tdesc.h | 44 ++++++-
> 16 files changed, 587 insertions(+), 45 deletions(-)
> create mode 100644 gdb/testsuite/gdb.xml/maint-xml-dump-01.xml
> create mode 100644 gdb/testsuite/gdb.xml/maint-xml-dump-02.xml
> create mode 100644 gdb/testsuite/gdb.xml/maint-xml-dump.exp
> create mode 100644 gdb/testsuite/gdb.xml/tdesc-reload.c
> create mode 100644 gdb/testsuite/gdb.xml/tdesc-reload.exp
>
> --
> 2.25.4
>
next prev parent reply other threads:[~2020-06-22 18:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 23:22 Andrew Burgess
2020-06-11 23:22 ` [PATCHv2 1/3] gdb: Allow target description to be dumped even when it is remote Andrew Burgess
2020-06-11 23:22 ` [PATCHv2 2/3] gdb: Print compatible information within print_xml_feature Andrew Burgess
2020-06-11 23:22 ` [PATCHv2 3/3] gdb: New maintenance command to print XML target description Andrew Burgess
2020-06-23 13:48 ` Pedro Alves
2020-06-22 18:13 ` Andrew Burgess [this message]
2020-06-23 13:58 ` [PATCHv2 0/3] Additional maintenance command for dumping target descriptions Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200622181304.GM2737@embecosm.com \
--to=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).