From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by sourceware.org (Postfix) with ESMTPS id DC652384B0C1 for ; Mon, 22 Jun 2020 18:13:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DC652384B0C1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-wr1-x441.google.com with SMTP id k6so5186756wrn.3 for ; Mon, 22 Jun 2020 11:13:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ITyleTNIrEIG2bE3oETUk2PP9WYntlXpy5qUAhwHIUQ=; b=KTZUK5foADsS2PUkz+bkTrsMQUqleP8VC+NMxXZyAUoFV9t5eZjk2rE33r8vzkCruB bxJ/lS1kYUHyzyoOim4diQmcz7EfwtGTGfyB/MwAV4XDrvCftAVdI6aOr0LoyT+xaWwv GacwU7gOC+keCDES+cWotO6jS1pRTr6cjClmfcB5UFD2cKY4u0C3Prdy20X04B+kS6RM i594O+nguCTFlTimkNQ0HIe291PcOWZ9/DMgt+a6WOwX+OaEgB5+b+yC0doVkLTmmIAe MYsq7JWbw6QJPVddKQjsv1KsyPv1dnbvvwENv87Dc4AQviDOT9eqZyRNgbqpN4UKajWl OLGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ITyleTNIrEIG2bE3oETUk2PP9WYntlXpy5qUAhwHIUQ=; b=hKou1Q1I5Fp+DQQGblKxesmARmnNb9rlOn4akeqmoph5QrsbZu76EcbnajOYyuxHvK yfM8cd7ZWDtYxT3r4Aqph45I2wH/77abinSBrFc6Ir49KTZnvy4BrVVTOx42XfX7XVyQ NygBT2eSfFoaobQ0N+2dgFJ81oEV9bPAkcS+cjUwV1hlHrxuuMsynWcfz79JJYzq2JMo NVCLhxHBileEadINcnWtT8+w/f33CVAsJVTErVF9zFNDuF3duffp9NT9edOU+cIukIKj vFllSCIiR128NoCiCtVg1uUuBZbmSzVnzJVC2s46T153TdUM8XFxBJLMfqvXN4dkWsyv 53cg== X-Gm-Message-State: AOAM532YvN4TTSA+hDN2ptLnEs7m8F3LHufq6xR4enTtLmyd1LOLiqaV xT0LvEN2hbMqU77qFC2TzVwJd5S0Mfk= X-Google-Smtp-Source: ABdhPJxHPtbUsuTOZGvR6aMR0MPXtMU0DI5YAmufw1XESf271K/Zwm2ui37mXobFUcd2OLSXmwlh2w== X-Received: by 2002:adf:8091:: with SMTP id 17mr18521660wrl.244.1592849585822; Mon, 22 Jun 2020 11:13:05 -0700 (PDT) Received: from localhost (host86-128-12-16.range86-128.btcentralplus.com. [86.128.12.16]) by smtp.gmail.com with ESMTPSA id g195sm389337wme.38.2020.06.22.11.13.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jun 2020 11:13:05 -0700 (PDT) Date: Mon, 22 Jun 2020 19:13:04 +0100 From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Pedro Alves Subject: Re: [PATCHv2 0/3] Additional maintenance command for dumping target descriptions Message-ID: <20200622181304.GM2737@embecosm.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux/5.6.15-200.fc31.x86_64 (x86_64) X-Uptime: 19:11:16 up 14 days, 8:18, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jun 2020 18:13:09 -0000 Pedro, I wonder if you have any feedback on the changes in this version? Specifically with how I now handle the 'compatibility' tags in a way that allows the code to be shared between gdbserver and gdb? Thanks Andrew --- * Andrew Burgess [2020-06-12 00:22:45 +0100]: > In the first patch of this series the only change is I addressed > Pedro's feedback. > > The second patch is new, this moves the printing of > entities into the gdbsupport/ directory, inside the print_xml_feature > class. > > The third patch is the old second patch. The documentation has not > changed. The code is now simpler thanks to the new #2 patch. I > addressed Pedro's feedback including adding some extra tests. > > Feedback welcome. > > Thanks, > Andrew > > > --- > > Andrew Burgess (3): > gdb: Allow target description to be dumped even when it is remote > gdb: Print compatible information within print_xml_feature > gdb: New maintenance command to print XML target description > > gdb/ChangeLog | 30 +++++ > gdb/NEWS | 6 + > gdb/doc/ChangeLog | 5 + > gdb/doc/gdb.texinfo | 9 ++ > gdb/target-descriptions.c | 109 ++++++++++++++--- > gdb/testsuite/ChangeLog | 8 ++ > gdb/testsuite/gdb.xml/maint-xml-dump-01.xml | 10 ++ > gdb/testsuite/gdb.xml/maint-xml-dump-02.xml | 27 +++++ > gdb/testsuite/gdb.xml/maint-xml-dump.exp | 124 ++++++++++++++++++++ > gdb/testsuite/gdb.xml/tdesc-reload.c | 22 ++++ > gdb/testsuite/gdb.xml/tdesc-reload.exp | 83 +++++++++++++ > gdbserver/ChangeLog | 6 + > gdbserver/tdesc.cc | 21 ++++ > gdbsupport/ChangeLog | 22 ++++ > gdbsupport/tdesc.cc | 106 ++++++++++++----- > gdbsupport/tdesc.h | 44 ++++++- > 16 files changed, 587 insertions(+), 45 deletions(-) > create mode 100644 gdb/testsuite/gdb.xml/maint-xml-dump-01.xml > create mode 100644 gdb/testsuite/gdb.xml/maint-xml-dump-02.xml > create mode 100644 gdb/testsuite/gdb.xml/maint-xml-dump.exp > create mode 100644 gdb/testsuite/gdb.xml/tdesc-reload.c > create mode 100644 gdb/testsuite/gdb.xml/tdesc-reload.exp > > -- > 2.25.4 >