From: Gary Benson <gbenson@redhat.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [committed][gdb/testsuite] Update psym-external-decl.exp for gcc-10/clang
Date: Fri, 26 Jun 2020 10:37:27 +0100 [thread overview]
Message-ID: <20200626093727.GA8682@blade.nx> (raw)
In-Reply-To: <6dd30362-e9dd-6bc9-bf40-8b846b926e5a@suse.de>
Tom de Vries wrote:
> On 6/19/20 4:00 PM, Gary Benson wrote:
> > Tom de Vries wrote:
> > > On 6/18/20 6:10 PM, Gary Benson wrote:
> > > > Tom de Vries wrote:
> > > > > On 6/17/20 2:24 PM, Gary Benson wrote:
> > > > > > Tom, I'd like this testcase to not fail silently. Is the
> > > > > > functionality under test something that isn't ever
> > > > > > expected to work with clang, or is this a test that should
> > > > > > pass with clang (but it currently doesn't, for whatever
> > > > > > reason)?
> > > > >
> > > > > I'm not sure. The test can pass with clang, provided it
> > > > > generates the required debug info. It currently doesn't.
> > > > > Why that is the case, I have no idea.
> > > >
> > > > I think that means the test should work but it doesn't. Would
> > > > you object if I push a patch removing the test-skipping logic?
> > > > It will mean an extra FAIL when tested using clang
> > >
> > > I don't think having a fail for a compiler bug/missing-feature
> > > is a good idea.
> > >
> > > If this is due to a bug/missing-feature in clang, then we need to:
> > > - xfail the test,
> > > - file the PR in clang, and
> > > - reference the PR at the xfail.
> >
> > Is this a bug/missing feature in clang though?
> > How sure are you GDB isn't at fault?
>
> Clang emits less debug info than GCC. Whether that's a bug, a
> missing feature or an explicit unsupported feature in clang, I
> don't known.
>
> I known that gdb isn't at fault. It can't do anything without the
> missing debug info. The test was specifically written to use that
> debug info.
I'm not really sure what's the right thing to do here.
On the one hand, my current task is ensuring GDB can debug
clang-compiled with clang as well as it can debug GCC-compiled
code. From that perspective the skip-if-clang logic in this
test is hiding a failure I need to investigate.
On the other hand, I'm an engineer working on GDB, and from that
perspective I want to be able to run the GDB testsuite and see
100% pass, on whatever setup I test it on. And yes, I know it
doesn't... but it *should*.
Is there a way to pass a "don't skip clang failures" flag to the
testcases, such that people running the testsuite normally would
see tests like these return UNSUPPORTED, but I could run the
testsuite with the flag so it'd not skip but FAIL wherever the
problem is?
Thanks,
Gary
--
Gary Benson - he / him / his
Principal Software Engineer, Red Hat
next prev parent reply other threads:[~2020-06-26 9:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-02 7:51 Tom de Vries
2020-06-17 12:24 ` Gary Benson
2020-06-17 13:56 ` Tom de Vries
2020-06-18 16:10 ` Gary Benson
2020-06-18 16:27 ` Tom de Vries
2020-06-19 14:00 ` Gary Benson
2020-06-19 14:06 ` Tom de Vries
2020-06-26 9:37 ` Gary Benson [this message]
2020-06-28 10:50 ` Tom de Vries
2020-06-29 12:32 ` Pedro Alves
2020-06-30 8:14 ` Tom de Vries
2020-07-03 9:21 ` Gary Benson
2020-07-03 11:20 ` Pedro Alves
2020-07-03 11:24 ` Tom de Vries
2020-07-03 11:32 ` Pedro Alves
2020-07-03 12:50 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200626093727.GA8682@blade.nx \
--to=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).