From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from barracuda.ebox.ca (barracuda.ebox.ca [96.127.255.19]) by sourceware.org (Postfix) with ESMTPS id 864F2385BF81 for ; Sat, 27 Jun 2020 18:40:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 864F2385BF81 X-ASG-Debug-ID: 1593283201-0c856e14ef1609c0001-fS2M51 Received: from smtp.ebox.ca (smtp.ebox.ca [96.127.255.82]) by barracuda.ebox.ca with ESMTP id L1bOAcuJPBReUKq9 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 27 Jun 2020 14:40:01 -0400 (EDT) X-Barracuda-Envelope-From: simon.marchi@polymtl.ca X-Barracuda-RBL-Trusted-Forwarder: 96.127.255.82 Received: from localhost.localdomain (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) by smtp.ebox.ca (Postfix) with ESMTP id 96900441B21; Sat, 27 Jun 2020 14:40:01 -0400 (EDT) From: Simon Marchi X-Barracuda-Effective-Source-IP: 173-246-6-90.qc.cable.ebox.net[173.246.6.90] X-Barracuda-Apparent-Source-IP: 173.246.6.90 X-Barracuda-RBL-IP: 173.246.6.90 To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [pushed] gdbsupport: add format attribute to print_xml_feature::add_line Date: Sat, 27 Jun 2020 14:40:01 -0400 X-ASG-Orig-Subj: [pushed] gdbsupport: add format attribute to print_xml_feature::add_line Message-Id: <20200627184001.1284219-1-simon.marchi@polymtl.ca> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Barracuda-Connect: smtp.ebox.ca[96.127.255.82] X-Barracuda-Start-Time: 1593283201 X-Barracuda-Encrypted: DHE-RSA-AES256-SHA X-Barracuda-URL: https://96.127.255.19:443/cgi-mod/mark.cgi X-Barracuda-Scan-Msg-Size: 1708 X-Virus-Scanned: by bsmtpd at ebox.ca X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.50 X-Barracuda-Spam-Status: No, SCORE=0.50 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=8.0 tests=WEIRD_PORT X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.82849 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.50 WEIRD_PORT URI: Uses non-standard port number for HTTP X-Spam-Status: No, score=-15.5 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_QUARANTINE, KAM_DMARC_STATUS, KAM_SHORT, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_SOFTFAIL, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Jun 2020 18:40:05 -0000 From: Simon Marchi Fixes this clang error: CXX tdesc.o /home/smarchi/src/binutils-gdb/gdbsupport/tdesc.cc:444:25: error: format string is not a string literal [-Werror,-Wformat-nonliteral] string_vappendf (tmp, fmt, ap); ^~~ There is already a but about GCC not emitting this warning: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82206 gdbsupport/ChangeLog: * tdesc.h (class print_xml_feature) : Add ATTRIBUTE_PRINTF. Change-Id: I7014075e83717f6d7e19d044a3675ff9981ebe17 --- gdbsupport/ChangeLog | 5 +++++ gdbsupport/tdesc.h | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gdbsupport/ChangeLog b/gdbsupport/ChangeLog index b2fbc56b1b95..4db482b15196 100644 --- a/gdbsupport/ChangeLog +++ b/gdbsupport/ChangeLog @@ -1,3 +1,8 @@ +2020-06-27 Simon Marchi + + * tdesc.h (class print_xml_feature) : Add + ATTRIBUTE_PRINTF. + 2020-06-23 Andrew Burgess * tdesc.cc (print_xml_feature::visit_pre): Use add_line to add diff --git a/gdbsupport/tdesc.h b/gdbsupport/tdesc.h index 73caf24536f3..456e8e070b12 100644 --- a/gdbsupport/tdesc.h +++ b/gdbsupport/tdesc.h @@ -438,7 +438,7 @@ class print_xml_feature : public tdesc_element_visitor functions appends a newline, so don't include one in the strings being passed. */ void add_line (const std::string &str); - void add_line (const char *fmt, ...); + void add_line (const char *fmt, ...) ATTRIBUTE_PRINTF (2, 3); /* The buffer we are writing too. */ std::string *m_buffer; -- 2.27.0