From: Joel Brobecker <brobecker@adacore.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: Building today's snapshot of GDB with MinGW
Date: Wed, 1 Jul 2020 12:30:26 -0700 [thread overview]
Message-ID: <20200701193026.GE5340@adacore.com> (raw)
In-Reply-To: <83ftaczfvl.fsf@gnu.org>
> Last, but not least: the test we do in gdbserver/configure for the
> socklen_t data type declaration doesn't work on Windows. We do this:
>
> AC_CHECK_TYPES(socklen_t, [], [],
> [#include <sys/types.h>
> #include <sys/socket.h>
> ])
>
> But on Windows this fails, because sys/socket.h doesn't exist;
> instead, socklen_t is supposed to be defined in ws2tcpip.h. So the
> correct headers inclusion for the test program would be
>
> #include <sys/types.h>
> #if HAVE_SYS_SOCKET_H
> # include <sys/socket.h>
> #elif HAVE_WS2TCPIP_H
> # include <ws2tcpip.h>
>
> Can we please fix this minor issue?
Would you be able to submit a patch?
--
Joel
next prev parent reply other threads:[~2020-07-01 19:30 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 18:27 Eli Zaretskii
2020-06-29 20:36 ` Christian Biesinger
2020-06-30 14:09 ` Eli Zaretskii
2020-06-30 22:24 ` Simon Marchi
2020-07-01 15:09 ` Eli Zaretskii
2020-07-02 13:50 ` Eli Zaretskii
2020-07-02 14:25 ` Simon Marchi
2020-07-02 14:30 ` Simon Marchi
2020-07-02 17:47 ` Eli Zaretskii
2020-07-02 14:40 ` Pedro Alves
2020-07-02 17:46 ` Eli Zaretskii
2020-07-02 18:21 ` Pedro Alves
2020-07-02 18:33 ` Eli Zaretskii
2020-07-02 18:34 ` Pedro Alves
2020-07-01 15:20 ` Eli Zaretskii
2020-07-01 19:25 ` Christian Biesinger
2020-07-02 2:29 ` Eli Zaretskii
2020-07-02 10:18 ` Hannes Domani
2020-07-02 13:20 ` Eli Zaretskii
2020-07-06 10:39 ` Hannes Domani
2020-07-06 16:35 ` Eli Zaretskii
2020-07-01 19:25 ` Joel Brobecker
2020-07-02 13:46 ` Eli Zaretskii
2020-06-30 16:18 ` Eli Zaretskii
2020-06-30 18:21 ` Christian Biesinger
2020-06-30 18:28 ` Eli Zaretskii
2020-07-01 19:29 ` Joel Brobecker
2020-07-02 2:31 ` Eli Zaretskii
2020-07-01 19:30 ` Joel Brobecker [this message]
2020-07-02 13:39 ` Eli Zaretskii
2020-07-03 15:25 ` Joel Brobecker
2020-07-27 9:49 ` Tom de Vries
2020-07-27 10:05 ` Tom de Vries
2020-07-27 10:26 ` Tom de Vries
2020-07-27 11:48 ` [committed][gdb/build] Fix typo sys/sockets.h -> sys/socket.h Tom de Vries
2020-07-27 12:51 ` Joel Brobecker
2020-07-27 14:18 ` Building today's snapshot of GDB with MinGW Eli Zaretskii
2020-07-02 14:12 ` Eli Zaretskii
2020-07-03 15:08 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200701193026.GE5340@adacore.com \
--to=brobecker@adacore.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).