public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Jon Turney <jon.turney@dronecode.org.uk>
To: gdb-patches@sourceware.org
Cc: Jon Turney <jon.turney@dronecode.org.uk>
Subject: [PATCH 1/7] Read tid from correct offset in win32pstatus NOTE_INFO_THREAD
Date: Wed,  1 Jul 2020 22:32:19 +0100	[thread overview]
Message-ID: <20200701213225.14144-2-jon.turney@dronecode.org.uk> (raw)
In-Reply-To: <20200701213225.14144-1-jon.turney@dronecode.org.uk>

Fix the offset used to read the tid from a win32pstatus ELF note.

This probably meant that registers were only being correctly recovered
from the core dump for the current thread.

Also improve comment.

bfd/ChangeLog:

2020-07-01  Jon Turney  <jon.turney@dronecode.org.uk>

	* elf.c (elfcore_grok_win32pstatus): Fix the offset used to read
	the tid from a win32pstatus ELF note.
---
 bfd/ChangeLog | 5 +++++
 bfd/elf.c     | 5 +++--
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/bfd/elf.c b/bfd/elf.c
index 9ca42e10d8e..5a184d14c66 100644
--- a/bfd/elf.c
+++ b/bfd/elf.c
@@ -10157,9 +10157,10 @@ elfcore_grok_win32pstatus (bfd *abfd, Elf_Internal_Note *note)
       break;
 
     case 2 /* NOTE_INFO_THREAD */:
-      /* Make a ".reg/999" section.  */
+      /* Make a ".reg/<tid>" section containing the Win32 API thread CONTEXT
+         structure. */
       /* thread_info.tid */
-      sprintf (buf, ".reg/%ld", (long) bfd_get_32 (abfd, note->descdata + 8));
+      sprintf (buf, ".reg/%ld", (long) bfd_get_32 (abfd, note->descdata + 4));
 
       len = strlen (buf) + 1;
       name = (char *) bfd_alloc (abfd, len);
-- 
2.27.0


  reply	other threads:[~2020-07-01 21:33 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-01 21:32 [PATCH 0/7] Add gdb support for Cygwin x86_64 core dumps Jon Turney
2020-07-01 21:32 ` Jon Turney [this message]
2020-07-01 21:32 ` [PATCH 2/7] Don't apply size constraint to all win32pstatus ELF notes Jon Turney
2020-07-01 21:32 ` [PATCH 3/7] Don't hardcode CONTEXT size for a NOTE_INFO_THREAD win32pstatus note Jon Turney
2020-07-06 20:12   ` Christian Biesinger
2020-07-01 21:32 ` [PATCH 4/7] Add sniffer for Cygwin x86_64 core dumps Jon Turney
2020-07-02 23:59   ` Simon Marchi
2020-07-03 13:30     ` Jon Turney
2020-07-03 14:17       ` Simon Marchi
2020-07-06 18:46         ` Jon Turney
2020-07-01 21:32 ` [PATCH 5/7] Add amd64_windows_gregset_reg_offset Jon Turney
2020-07-03 14:11   ` Pedro Alves
2020-07-01 21:32 ` [PATCH 6/7] Promote windows_core_xfer_shared_libraries and windows_core_pid_to_str Jon Turney
2020-07-02 23:53   ` Simon Marchi
2020-07-02 23:56     ` Simon Marchi
2020-07-03 13:14       ` Jon Turney
2020-07-01 21:32 ` [PATCH 7/7] Add handling for 64-bit module addresses in Cygwin core dumps Jon Turney
2020-07-06 20:13   ` Christian Biesinger
2020-07-08 15:50     ` Jon Turney
2020-07-08 16:11       ` Christian Biesinger
2020-07-12 12:58         ` Jon Turney
2020-07-02 21:17 ` [PATCH 0/7] Add gdb support for Cygwin x86_64 " Tom Tromey
2020-07-03 13:30   ` Jon Turney
2020-07-03  0:00 ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200701213225.14144-2-jon.turney@dronecode.org.uk \
    --to=jon.turney@dronecode.org.uk \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).