From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by sourceware.org (Postfix) with ESMTP id ACBD53858D34 for ; Fri, 3 Jul 2020 09:21:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org ACBD53858D34 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-244-dRu2jx5bNuiPHs8ZIAS0MA-1; Fri, 03 Jul 2020 05:21:13 -0400 X-MC-Unique: dRu2jx5bNuiPHs8ZIAS0MA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1B1E68015FE; Fri, 3 Jul 2020 09:21:12 +0000 (UTC) Received: from blade.nx (ovpn-113-167.ams2.redhat.com [10.36.113.167]) by smtp.corp.redhat.com (Postfix) with ESMTP id E11F7B3A79; Fri, 3 Jul 2020 09:21:11 +0000 (UTC) Received: by blade.nx (Postfix, from userid 1000) id 8EAFF816CCA9; Fri, 3 Jul 2020 10:21:07 +0100 (BST) Date: Fri, 3 Jul 2020 10:21:07 +0100 From: Gary Benson To: Tom de Vries Cc: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [committed][gdb/testsuite] Update psym-external-decl.exp for gcc-10/clang Message-ID: <20200703092107.GA8482@blade.nx> References: <20200617122432.GA28940@blade.nx> <20200618161044.GA1032@blade.nx> <21d9fcc8-62c4-d1a5-f085-0c7f26783255@suse.de> <20200619140041.GB31823@blade.nx> <6dd30362-e9dd-6bc9-bf40-8b846b926e5a@suse.de> <20200626093727.GA8682@blade.nx> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-9.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jul 2020 09:21:22 -0000 Tom de Vries wrote: > On 6/29/20 2:32 PM, Pedro Alves wrote: > > On 6/28/20 11:50 AM, Tom de Vries wrote: > > > I think the following is a good way of dealing with this. > > > > > > We introduce a proc in gdb.exp called debug_info_for_decl or > > > some such, that returns false by default for clang. > > > > I think it would be useful to include an intro description to > > > > gdb.base/psym-external-decl.exp > > > > since it currently doesn't describe what it is testing. Looking > > at the commit log of the patch that introduced it helps, but > > one shouldn't have to do that. > > > > So the difference between gcc and clang AFAIU is that gcc emits > > debug info for the extern variable declaration (and with newer GCCs, > > only if there's a reference to the variable in the CU, otherwise > > not even so), while seemingly clang would only emit debug info for > > the variable's definition, which isn't compiled with -g, so we > > end up with no debug info for the variable. > > > > I would suggest filing a bug with clang, to confirm whether > > this is intentional, or whether they see it as a bug. I would > > think it is a bug, but I'm not sure. If indeed a bug, we would > > XFAIL the test. > > I've filed https://bugs.llvm.org/show_bug.cgi?id=46514 . > > Thanks, > - Tom Thank for filing it Tom. Cheers, Gary -- Gary Benson - he / him / his Principal Software Engineer, Red Hat