From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sourceware.org
Subject: [PATCH v4 11/14] xfail gdb.base/coredump-filter.exp test which now works without a binary
Date: Sun, 5 Jul 2020 15:58:04 -0700 [thread overview]
Message-ID: <20200705225807.2264705-12-kevinb@redhat.com> (raw)
In-Reply-To: <20200705225807.2264705-1-kevinb@redhat.com>
See comment in patch for a description of what this is about. In
a nutshell, a certain memory access was expected to not work in
order to PASS, but due to recent changes, the memory access now
works causing the test to FAIL.
gdb/testsuite/ChangeLog:
* gdb.base/coredump-filter.exp (test_disasm): Call
setup_xfail for test "disassemble function with corefile and
without a binary".
---
gdb/testsuite/gdb.base/coredump-filter.exp | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/gdb/testsuite/gdb.base/coredump-filter.exp b/gdb/testsuite/gdb.base/coredump-filter.exp
index ff398f2b85..fd4e0352d8 100644
--- a/gdb/testsuite/gdb.base/coredump-filter.exp
+++ b/gdb/testsuite/gdb.base/coredump-filter.exp
@@ -96,6 +96,27 @@ proc test_disasm { core address should_fail } {
}
if { $should_fail == 1 } {
+ # As originally conceived, an attempt here to disassemble
+ # addresses in main() with the core file loaded, but with
+ # the executable not loaded shouldn't work . This was a
+ # good idea because it demonstrates that executable-backed
+ # memory was not dumped to the core file. However, this
+ # test now fails (i.e. now successfully disassembles
+ # addresses in main()) due to the fact that GDB loads the
+ # file-based mappings in Linux's NT_FILE note. So, even
+ # though the executable wasn't explicitly loaded, GDB will
+ # still be able to find the file-backed memory via the
+ # note (referencing the file) within the core file. The
+ # data in question is not actually stored in the core
+ # file, but is instead found in one of the files mentioned
+ # in the core file note.
+ #
+ # It's tempting to simply remove this test because it's
+ # apparently no longer useful. However, the idea behind
+ # the test is useful, so it's marked as xfail, along with
+ # this comment, as a reminder for someone to come up with
+ # a new approach.
+ setup_xfail "*-*-*"
gdb_test "x/i \$pc" "=> $hex:\tCannot access memory at address $hex" \
"disassemble function with corefile and without a binary"
} else {
--
2.26.2
next prev parent reply other threads:[~2020-07-05 22:59 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-05 22:57 [PATCH v4 00/14] Fix BZ 25631 - core file memory access problem Kevin Buettner
2020-07-05 22:57 ` [PATCH v4 01/14] Remove hack for GDB which sets the section size to 0 Kevin Buettner
2020-07-05 22:57 ` [PATCH v4 02/14] Adjust corefile.exp test to show regression after bfd hack removal Kevin Buettner
2020-07-05 22:57 ` [PATCH v4 03/14] section_table_xfer_memory: Replace section name with callback predicate Kevin Buettner
2020-07-05 22:57 ` [PATCH v4 04/14] Provide access to non SEC_HAS_CONTENTS core file sections Kevin Buettner
2020-07-05 22:57 ` [PATCH v4 05/14] Test ability to access unwritten-to mmap data in core file Kevin Buettner
2020-07-05 22:57 ` [PATCH v4 06/14] Update binary_get_section_contents to seek using section's file position Kevin Buettner
2020-07-05 22:58 ` [PATCH v4 07/14] Add new gdbarch method, read_core_file_mappings Kevin Buettner
2020-07-05 22:58 ` [PATCH v4 08/14] Use NT_FILE note section for reading core target memory Kevin Buettner
2020-07-10 20:08 ` Pedro Alves
2020-07-14 7:53 ` Kevin Buettner
2020-07-21 18:21 ` Tom Tromey
2020-07-21 2:09 ` Kevin Buettner
2020-07-05 22:58 ` [PATCH v4 09/14] Add test for accessing read-only mmapped data in a core file Kevin Buettner
2020-07-05 22:58 ` [PATCH v4 10/14] gcore command: Place all file-backed mappings in NT_FILE note Kevin Buettner
2020-07-05 22:58 ` Kevin Buettner [this message]
2020-07-10 20:07 ` [PATCH v4 11/14] xfail gdb.base/coredump-filter.exp test which now works without a binary Pedro Alves
2020-07-13 11:38 ` Strasuns, Mihails
2020-07-13 17:04 ` Kevin Buettner
2020-07-05 22:58 ` [PATCH v4 12/14] Add new command "maint print core-file-backed-mappings" Kevin Buettner
2020-07-10 20:08 ` Pedro Alves
2020-07-10 20:10 ` Pedro Alves
2020-07-13 17:33 ` Kevin Buettner
2020-07-05 22:58 ` [PATCH v4 13/14] Add documentation for " Kevin Buettner
2020-07-06 2:26 ` Eli Zaretskii
2020-07-05 22:58 ` [PATCH v4 14/14] New core file tests with mappings over existing program memory Kevin Buettner
2020-07-10 20:08 ` Pedro Alves
2020-07-10 20:13 ` [PATCH v4 00/14] Fix BZ 25631 - core file memory access problem Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200705225807.2264705-12-kevinb@redhat.com \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).