From: Gary Benson <gbenson@redhat.com>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] gdb: Improve formatting of 'show endian' messages
Date: Wed, 8 Jul 2020 11:06:44 +0100 [thread overview]
Message-ID: <20200708100644.GB10907@blade.nx> (raw)
In-Reply-To: <556fa65f8daa47ce8776fb12f0be0c06099f1a5c.1594198122.git.andrew.burgess@embecosm.com>
Andrew Burgess wrote:
> This commit changes the output of 'show endian'. Here is a
> session before this commit:
>
> (gdb) show endian
> The target endianness is set automatically (currently little endian)
> (gdb) set endian big
> The target is assumed to be big endian
> (gdb) show endian
> The target is assumed to be big endian
> (gdb)
>
> After this commit the session now looks like this:
>
> (gdb) show endian
> The target endianness is set automatically (currently little endian).
> (gdb) set endian big
> The target is set to big endian.
> (gdb) show endian
> The target is set to big endian.
> (gdb)
>
> The changes are:
>
> 1. Each line ends with '.', and
> 2. After setting the endianness GDB is now a little more assertive;
> 'target is set to' not 'target is assumed to be', the user did just
> tell us after all!
LGTM.
Cheers,
Gary
--
Gary Benson - he / him / his
Principal Software Engineer, Red Hat
next prev parent reply other threads:[~2020-07-08 10:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 8:54 [PATCH 0/2] Changes to show architecture/endian message Andrew Burgess
2020-07-08 8:54 ` [PATCH 1/2] gdb: Improve formatting of 'show architecture' messages Andrew Burgess
2020-07-08 10:06 ` Gary Benson
2020-07-15 2:06 ` Simon Marchi
2020-07-15 9:36 ` Andrew Burgess
2020-07-17 15:52 ` Gary Benson
2020-07-08 8:54 ` [PATCH 2/2] gdb: Improve formatting of 'show endian' messages Andrew Burgess
2020-07-08 10:06 ` Gary Benson [this message]
2020-07-13 18:24 ` [PATCH 0/2] Changes to show architecture/endian message Tom Tromey
2020-07-14 12:27 ` [PUSHED " Andrew Burgess
2020-07-14 12:27 ` [PUSHED 1/2] gdb: Improve formatting of 'show architecture' messages Andrew Burgess
2020-07-14 12:27 ` [PUSHED 2/2] gdb: Improve formatting of 'show endian' messages Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200708100644.GB10907@blade.nx \
--to=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).