From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by sourceware.org (Postfix) with ESMTP id 70F813870914 for ; Fri, 10 Jul 2020 12:00:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 70F813870914 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-26-gJxkQ_PqOqCuGr8UuK4dXA-1; Fri, 10 Jul 2020 08:00:22 -0400 X-MC-Unique: gJxkQ_PqOqCuGr8UuK4dXA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8CEA51009600; Fri, 10 Jul 2020 12:00:20 +0000 (UTC) Received: from blade.nx (ovpn-114-254.ams2.redhat.com [10.36.114.254]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5DC7A2DE79; Fri, 10 Jul 2020 12:00:20 +0000 (UTC) Received: by blade.nx (Postfix, from userid 1000) id A9DAE816CCA9; Fri, 10 Jul 2020 13:00:19 +0100 (BST) Date: Fri, 10 Jul 2020 13:00:19 +0100 From: Gary Benson To: Luis Machado Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2] Skip VLA structure field tests when compiling with clang Message-ID: <20200710120019.GA3062@blade.nx> References: <1594223215-21455-1-git-send-email-gbenson@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-8.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jul 2020 12:00:25 -0000 Luis Machado wrote: > Hi Gary, > > On 7/8/20 12:46 PM, Gary Benson wrote: > > Hi Luis, > > > > Luis Machado wrote: > > > As a general comment (for this and other patches like this), I > > > think the preprocessor blocks intermixed with the test code make > > > it harder to follow and update the test. > > > > > > If clang claims it will never support a particular feature, then > > > maybe we should ... separate the bits clang doesn't support and > > > put it into a separate test that clang-compiled hosts should > > > skip? > > > > Thanks for the review. I've made that change, the updated patch > > is below. I checked it on Fedora 31 x86_64, GCC and clang. Is it > > ok to commit? > > Thanks. That looks cleaner. Just a gotcha below... > [snip] > > + > > +# Clang says it will never support variable length arrays in structures. > > +if {[test_compiler_info clang*]} { > > + unsupported "compiler does not variable length arrays in structure" > > ^^^ support? > > Otherwise this looks good to me. Can't approve a commit though. Good catch. Thanks for your review, I've fixed this in my tree. Cheers, Gary -- Gary Benson - he / him / his Principal Software Engineer, Red Hat