From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by sourceware.org (Postfix) with ESMTP id 93EA63858D37 for ; Mon, 13 Jul 2020 17:04:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 93EA63858D37 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-8-VVM-KR_fPBWBZ8jCa7nLOw-1; Mon, 13 Jul 2020 13:04:08 -0400 X-MC-Unique: VVM-KR_fPBWBZ8jCa7nLOw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5C9FD1937FC4 for ; Mon, 13 Jul 2020 17:04:06 +0000 (UTC) Received: from f32-m1.lan (ovpn-112-21.phx2.redhat.com [10.3.112.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 05EDD3D4222 for ; Mon, 13 Jul 2020 17:04:04 +0000 (UTC) Date: Mon, 13 Jul 2020 10:04:04 -0700 From: Kevin Buettner To: gdb-patches@sourceware.org Subject: Re: [PATCH v4 11/14] xfail gdb.base/coredump-filter.exp test which now works without a binary Message-ID: <20200713100404.77ec42bf@f32-m1.lan> In-Reply-To: References: <20200705225807.2264705-1-kevinb@redhat.com> <20200705225807.2264705-12-kevinb@redhat.com> <82d59409-4466-26a5-e272-0ac979fbe8b3@palves.net> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jul 2020 17:04:12 -0000 On Mon, 13 Jul 2020 11:38:49 +0000 "Strasuns, Mihails via Gdb-patches" wrote: > Idea: now that NT_FILE works, it probably makes sense to replace this test with two sequential ones: > > 1) First test that it still works if file is accessible in the filesystem > 2) Temporarily move / rename the file and test that disassemble doesn't work anymore That's a good idea. I'll give it a try... Thanks, Kevin