From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by sourceware.org (Postfix) with ESMTPS id 6A78D386197E for ; Wed, 15 Jul 2020 09:36:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6A78D386197E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-wm1-x344.google.com with SMTP id w3so4881615wmi.4 for ; Wed, 15 Jul 2020 02:36:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=R8uxcAQbFfUuvxL4KaeMgnQrt49sb6PtWi8DQFoT2Hw=; b=d3p/hPHbQ2+YYZKaU7ByCJxyGQ4kHfhW13M9O4ayBnAeZcQZATu8g9KbXRWsgwDGwn aEkOLvw8jqJAY7O79swItiz3iaU5AnX41e+d6bBlHqGfsLWQBBZsTuB7u5CLOpJk3VyB H63KJzDu/QYclQXN9L5li9NrOfRbhbGt1aDHOxHAhkZkV/evuuStnRtp7hQjlnqvSx3J 3xgYEpLZ/stgLIC1YVcWJ7iQZc/eAdg0sZXngRGtsGumFTmwMdarf4m1PMjhtxar/NfG MLok8oe1M3OCPrPWj/Xm/fdqgzvcZF4G5RXU2Zw//K17ErQaN0SSIVLnJU3tPjsu7107 7p2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=R8uxcAQbFfUuvxL4KaeMgnQrt49sb6PtWi8DQFoT2Hw=; b=Z2R3NBs4g9GaeLJOSzKSqLcxnTqP/P/OrN7R6cXvX2BS5xF5D5IxpXHK/EVYjhAMIx BqsZq5TnL+NQiDF0H7excgUm3+/4EzVmBN8yFdARzw3Cj3kUAT6pyuW4qj7LH/FeIeL6 d1RBC5ORKNZO284CQKor5a0l0FKkyOb/e27RDUMKoFf+OZtrMkdYr0AmmFQ4n53U55lc h18Q7GL/qt58jE48zrIyM83T/4qVRL0EI/fxza4DiKwVOhD+ulq4W7ncMTq2055lEjhl TZon4aRJ4eHwQa8sAkDm9sEWu3ekfEgwJ55zuQqTEOEtTBrm3rDuD+kvKBHip6Zns9CP BKsA== X-Gm-Message-State: AOAM530q4K4T3nyyDY/gSGolgNVoA8iae/YWGRQ8/LM4wscdrZm8kj45 JQRpG2MtaVBkRvqlhtE1CyaApg== X-Google-Smtp-Source: ABdhPJyHZPPtx0JgzibsgsV2MzfOmJtWL3J1L5EdQE/yG6ikbtGMDb2sfek2smEDRpCqilbQk+2+lA== X-Received: by 2002:a1c:19c5:: with SMTP id 188mr7703873wmz.124.1594805792515; Wed, 15 Jul 2020 02:36:32 -0700 (PDT) Received: from localhost (host86-128-12-23.range86-128.btcentralplus.com. [86.128.12.23]) by smtp.gmail.com with ESMTPSA id a22sm2480740wmb.4.2020.07.15.02.36.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 02:36:31 -0700 (PDT) Date: Wed, 15 Jul 2020 10:36:30 +0100 From: Andrew Burgess To: Simon Marchi Cc: Gary Benson , gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] gdb: Improve formatting of 'show architecture' messages Message-ID: <20200715093630.GE2737@embecosm.com> References: <2d73efe4dc489f06fd4e67aa18979e5b655b7100.1594198122.git.andrew.burgess@embecosm.com> <20200708100600.GA10907@blade.nx> <0ceca48f-a952-ceb3-eb4c-09c65f11bdf3@simark.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0ceca48f-a952-ceb3-eb4c-09c65f11bdf3@simark.ca> X-Operating-System: Linux/5.6.15-200.fc31.x86_64 (x86_64) X-Uptime: 10:35:31 up 36 days, 23:42, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jul 2020 09:36:34 -0000 * Simon Marchi [2020-07-14 22:06:05 -0400]: > On 2020-07-08 6:06 a.m., Gary Benson via Gdb-patches wrote: > > This is potentially bikeshedding, but should the i386 in this > > line be enclosed in quotes also? > > This is not bikeshedding, IMO. Consistency and attention to details make a tool look much better! I agree, and I'm always happy to get feedback like this. FYI - this change made it into the final patch I merged. Thanks, Andrew