From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x743.google.com (mail-qk1-x743.google.com [IPv6:2607:f8b0:4864:20::743]) by sourceware.org (Postfix) with ESMTPS id C728E383F861 for ; Wed, 15 Jul 2020 19:49:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C728E383F861 Received: by mail-qk1-x743.google.com with SMTP id 80so3033387qko.7 for ; Wed, 15 Jul 2020 12:49:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=xQgszBdODpFdyP/L5nmddEv+oEzudiq4xPIg4Sgm1Tw=; b=t6hgFJn100D6skK2naZbrRARrga7qDRQH+RzEsivLWtvnIIMscD+b3ZSf3jwKbejcd 51GGIP/EAwZ7Ri1sGwg/6hrxlKkrH22jtK2SjtFHO/313Zt1XOA126U+V3sxk/PmJeB+ nJ3i6rngZqC3VzgYd6lK7FxN6BiU++XtGpmeFTtY0zU6hx9duQLdQNrq++iXjbj9bGer ZWaCdWYuUdfCfWgeBXpYgx3ZRk/U27qP+Y/OyIp1hi46jMZQu7I7kUSZTy5kV0YEkkLW wxshL6eQYB5iEbc9yhcxhw3qinVWBVoP0MQtCWGdkyGatbiiXUuNqJInUJrZzzo6V9qR iZBg== X-Gm-Message-State: AOAM53237agqlsgwYWOq9cNMh+l6FO/plJCJJ+UyCdYU+WOlgJUwRRSQ vJLK/xQc2DcA+6IQkH7p4NFQ+f2zyee7rQ== X-Google-Smtp-Source: ABdhPJxWrHexPlb7ueh83qmxE16RAarRf8QJNov6n2su4ZPGmfpHHvpGjMff9p3pY244dXWgAD5btA== X-Received: by 2002:a37:a582:: with SMTP id o124mr787634qke.100.1594842559123; Wed, 15 Jul 2020 12:49:19 -0700 (PDT) Received: from localhost.localdomain ([2804:7f0:8283:82c3:9daa:7611:ebe6:931]) by smtp.gmail.com with ESMTPSA id z18sm4340537qta.51.2020.07.15.12.49.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 12:49:18 -0700 (PDT) From: Luis Machado To: gdb-patches@sourceware.org, Alan.Hayward@arm.com Cc: omair.javaid@linaro.org, catalin.marinas@arm.com, david.spickett@linaro.org, jose.marchesi@oracle.com Subject: [PATCH 17/23] AArch64: Add gdbserver MTE support Date: Wed, 15 Jul 2020 16:45:07 -0300 Message-Id: <20200715194513.16641-18-luis.machado@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200715194513.16641-1-luis.machado@linaro.org> References: <20200715194513.16641-1-luis.machado@linaro.org> X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jul 2020 19:49:21 -0000 Adds the AArch64-specific memory tagging support (MTE) by implementing the required hooks and checks for GDBserver. gdbserver/ChangeLog: YYYY-MM-DD Luis Machado * Makefile.in (SFILES): Add /../gdb/nat/aarch64-mte-linux-ptrace.c. * configure.srv (aarch64*-*-linux*): Add arch/aarch64-mte-linux.o and nat/aarch64-mte-linux-ptrace.o. * linux-aarch64-low.cc: Include nat/aarch64-mte-linux-ptrace.h. (class aarch64_target) : New method overrides. (aarch64_target::supports_memory_tagging) (aarch64_target::fetch_memtags) (aarch64_target::store_memtags): New methods. --- gdbserver/Makefile.in | 1 + gdbserver/configure.srv | 2 ++ gdbserver/linux-aarch64-low.cc | 53 ++++++++++++++++++++++++++++++++++ 3 files changed, 56 insertions(+) diff --git a/gdbserver/Makefile.in b/gdbserver/Makefile.in index 9d7687be53..8e54e1fd09 100644 --- a/gdbserver/Makefile.in +++ b/gdbserver/Makefile.in @@ -212,6 +212,7 @@ SFILES = \ $(srcdir)/../gdb/arch/ppc-linux-common.c \ $(srcdir)/../gdb/arch/riscv.c \ $(srcdir)/../gdb/nat/aarch64-sve-linux-ptrace.c \ + $(srcdir)/../gdb/nat/aarch64-mte-linux-ptrace.c \ $(srcdir)/../gdb/nat/linux-btrace.c \ $(srcdir)/../gdb/nat/linux-namespaces.c \ $(srcdir)/../gdb/nat/linux-osdata.c \ diff --git a/gdbserver/configure.srv b/gdbserver/configure.srv index 5e33bd9c54..e8d599e866 100644 --- a/gdbserver/configure.srv +++ b/gdbserver/configure.srv @@ -52,8 +52,10 @@ case "${gdbserver_host}" in srv_tgtobj="$srv_tgtobj nat/aarch64-linux.o" srv_tgtobj="$srv_tgtobj arch/aarch64-insn.o" srv_tgtobj="$srv_tgtobj arch/aarch64.o" + srv_tgtobj="$srv_tgtobj arch/aarch64-mte-linux.o" srv_tgtobj="$srv_tgtobj linux-aarch64-tdesc.o" srv_tgtobj="$srv_tgtobj nat/aarch64-sve-linux-ptrace.o" + srv_tgtobj="$srv_tgtobj nat/aarch64-mte-linux-ptrace.o" srv_tgtobj="${srv_tgtobj} $srv_linux_obj" srv_linux_regsets=yes srv_linux_thread_db=yes diff --git a/gdbserver/linux-aarch64-low.cc b/gdbserver/linux-aarch64-low.cc index 22485d9466..f8d2511fff 100644 --- a/gdbserver/linux-aarch64-low.cc +++ b/gdbserver/linux-aarch64-low.cc @@ -44,12 +44,17 @@ #include "linux-aarch32-tdesc.h" #include "linux-aarch64-tdesc.h" #include "nat/aarch64-sve-linux-ptrace.h" +#include "nat/aarch64-mte-linux-ptrace.h" #include "tdesc.h" #ifdef HAVE_SYS_REG_H #include #endif +#ifdef HAVE_GETAUXVAL +#include +#endif + /* Linux target op definitions for the AArch64 architecture. */ class aarch64_target : public linux_process_target @@ -82,6 +87,14 @@ public: struct emit_ops *emit_ops () override; + bool supports_memory_tagging () override; + + int fetch_memtags (CORE_ADDR address, size_t len, + gdb::byte_vector &tags) override; + + int store_memtags (CORE_ADDR address, size_t len, + const gdb::byte_vector &tags) override; + protected: void low_arch_setup () override; @@ -3201,6 +3214,46 @@ aarch64_target::breakpoint_kind_from_current_state (CORE_ADDR *pcptr) return arm_breakpoint_kind_from_current_state (pcptr); } +/* Returns true if memory tagging is supported. */ +bool +aarch64_target::supports_memory_tagging () +{ + if (current_thread == NULL) + { + /* We don't have any processes running, so don't attempt to + use linux_get_hwcap2 as it will try to fetch the current + thread id. Instead, just fetch the auxv from the self + PID. */ +#ifdef HAVE_GETAUXVAL + return (getauxval (AT_HWCAP2) & HWCAP2_MTE) != 0; +#else + return true; +#endif + } + + return (linux_get_hwcap2 (8) & HWCAP2_MTE) != 0; +} + +int +aarch64_target::fetch_memtags (CORE_ADDR address, size_t len, + gdb::byte_vector &tags) +{ + /* Allocation tags are per-process, so any tid is fine. */ + int tid = lwpid_of (current_thread); + + return aarch64_mte_fetch_memtags (tid, address, len, tags); +} + +int +aarch64_target::store_memtags (CORE_ADDR address, size_t len, + const gdb::byte_vector &tags) +{ + /* Allocation tags are per-process, so any tid is fine. */ + int tid = lwpid_of (current_thread); + + return aarch64_mte_store_memtags (tid, address, len, tags); +} + /* The linux target ops object. */ linux_process_target *the_linux_target = &the_aarch64_target; -- 2.17.1