From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rock.gnat.com (rock.gnat.com [205.232.38.15]) by sourceware.org (Postfix) with ESMTP id C00083858D34 for ; Sat, 18 Jul 2020 19:00:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C00083858D34 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=brobecker@adacore.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 8D8295611C; Sat, 18 Jul 2020 15:00:40 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at gnat.com Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 46pvZ+HiDyeJ; Sat, 18 Jul 2020 15:00:40 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 5CEE95611A; Sat, 18 Jul 2020 15:00:40 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 896D283464; Sat, 18 Jul 2020 12:00:38 -0700 (PDT) Date: Sat, 18 Jul 2020 12:00:38 -0700 From: Joel Brobecker To: Simon Marchi Cc: Ludovic =?iso-8859-1?Q?Court=E8s?= , gdb-patches@sourceware.org Subject: Re: [PATCH v4 1/2] guile: Add support for Guile 2.2. Message-ID: <20200718190038.GA582@adacore.com> References: <87v9jbi855.fsf@gnu.org> <20200628142540.11320-1-ludo@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Jul 2020 19:00:41 -0000 Hi Simon, > > This primarily updates code that uses the I/O port API of Guile. > > I know nothing about Guile, so I just scanned the patch for any obvious > red flags, but didn't see any. The mess of #if statements sure is not > the best, but I don't have a concrete suggestion to make it better. I'm not confident that we'll be able to find a reviewer who has more experience with this part of the Code. What do you think of approving this patch series based on your review? -- Joel