public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Andrew Burgess <andrew.burgess@embecosm.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCHv2 1/2] gdb/fortran: resolve dynamic types when readjusting after an indirection
Date: Sat, 25 Jul 2020 01:31:31 +0100	[thread overview]
Message-ID: <20200725003131.GR853475@embecosm.com> (raw)
In-Reply-To: <87lfjbbc38.fsf@tromey.com>

* Tom Tromey <tom@tromey.com> [2020-07-22 13:10:03 -0600]:

> >>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:
> 
> Andrew> gdb/ChangeLog:
> 
> Andrew> 	PR fortran/23051
> Andrew> 	PR fortran/26139
> Andrew> 	* valops.c (value_ind): Pass address to
> Andrew> 	readjust_indirect_value_type.
> Andrew> 	* value.c (readjust_indirect_value_type): Make parameter
> Andrew> 	non-const, and add extra address parameter.  Resolve original type
> Andrew> 	before using it.
> Andrew> 	* value.h (readjust_indirect_value_type): Update function
> Andrew> 	signature and comment.
> 
> Thanks.  I think this is ok.

Thanks.  I've pushed this patch, I guess #2 will wait while I think
over the feedback you've provided.

Thanks,
Andrew

  reply	other threads:[~2020-07-25  0:31 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-10 15:22 [PATCH 0/2] Fortran dynamic type related fixes Andrew Burgess
2020-07-10 15:22 ` [PATCH 1/2] gdb/fortran: resolve dynamic types when readjusting after an indirection Andrew Burgess
2020-07-10 15:22 ` [PATCH 2/2] gdb/fortran: Access elements of a structure with dynamic type Andrew Burgess
2020-07-13 13:33 ` [PATCHv2 0/2] Fortran dynamic type related fixes Andrew Burgess
2020-07-13 13:33   ` [PATCHv2 1/2] gdb/fortran: resolve dynamic types when readjusting after an indirection Andrew Burgess
2020-07-22 19:10     ` Tom Tromey
2020-07-25  0:31       ` Andrew Burgess [this message]
2020-07-13 13:33   ` [PATCHv2 2/2] gdb/fortran: Access elements of a structure with dynamic type Andrew Burgess
2020-07-22 19:19     ` Tom Tromey
2020-07-23 10:28       ` Andrew Burgess
2020-07-24 20:03         ` Tom Tromey
2020-07-26 19:31           ` Tom Tromey
2020-08-04 19:19           ` Tom Tromey
2020-08-06 15:38             ` Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200725003131.GR853475@embecosm.com \
    --to=andrew.burgess@embecosm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).